You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2022/07/20 03:57:27 UTC
[kudu-CR] [tserver] add TabletServerTest.InvalidScanRequestNoGreaterKey
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18756
Change subject: [tserver] add TabletServerTest.InvalidScanRequestNoGreaterKey
......................................................................
[tserver] add TabletServerTest.InvalidScanRequestNoGreaterKey
This patch adds a new test scenario into TabletServerTest to cover
the case when client sends INT32_MAX value in last_primary_key with
ScanRequestPB::new_scan_request field. That's to verify that tablet
server sends back an error with TabletServerErrorPB::INVALID_SCAN_SPEC
code.
I also updated log message in TabletServiceImpl::Scan() to output
information about scanner identifier upon an error setting up scanner
for a scan request. In addition, I took the liberty to update the code
around, getting rid of unused variables and making it more style guide
compliant.
Change-Id: I0992997e82114142e7f93c7898491b08208e1823
---
M src/kudu/tserver/tablet_server-test.cc
M src/kudu/tserver/tablet_service.cc
2 files changed, 31 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/56/18756/1
--
To view, visit http://gerrit.cloudera.org:8080/18756
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0992997e82114142e7f93c7898491b08208e1823
Gerrit-Change-Number: 18756
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] [tserver] add TabletServerTest.InvalidScanRequestNoGreaterKey
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18756 )
Change subject: [tserver] add TabletServerTest.InvalidScanRequestNoGreaterKey
......................................................................
[tserver] add TabletServerTest.InvalidScanRequestNoGreaterKey
This patch adds a new test scenario into TabletServerTest to cover
the case when client sends INT32_MAX value in last_primary_key with
ScanRequestPB::new_scan_request field. That's to verify that tablet
server sends back an error with TabletServerErrorPB::INVALID_SCAN_SPEC
code.
I also updated log message in TabletServiceImpl::Scan() to output
information about scanner identifier upon an error setting up scanner
for a scan request. In addition, I took the liberty to update the code
around, getting rid of unused variables and making it more style guide
compliant.
Change-Id: I0992997e82114142e7f93c7898491b08208e1823
Reviewed-on: http://gerrit.cloudera.org:8080/18756
Tested-by: Kudu Jenkins
Reviewed-by: Yifan Zhang <ch...@163.com>
---
M src/kudu/tserver/tablet_server-test.cc
M src/kudu/tserver/tablet_service.cc
2 files changed, 31 insertions(+), 12 deletions(-)
Approvals:
Kudu Jenkins: Verified
Yifan Zhang: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/18756
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0992997e82114142e7f93c7898491b08208e1823
Gerrit-Change-Number: 18756
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
[kudu-CR] [tserver] add TabletServerTest.InvalidScanRequestNoGreaterKey
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18756 )
Change subject: [tserver] add TabletServerTest.InvalidScanRequestNoGreaterKey
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18756
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0992997e82114142e7f93c7898491b08208e1823
Gerrit-Change-Number: 18756
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Wed, 20 Jul 2022 14:04:36 +0000
Gerrit-HasComments: No