You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by josephw <gi...@git.apache.org> on 2015/06/07 15:32:31 UTC
[GitHub] maven pull request: MNG-5837: Use a subshell, rather than the 'loc...
GitHub user josephw opened a pull request:
https://github.com/apache/maven/pull/50
MNG-5837: Use a subshell, rather than the 'local' keyword, for POSIX compliance
'local' is not POSIX, but supported by most shells. However, it's not
supported by Solaris's /bin/sh, so use a subshell instead.
Tested on OS X by invoking with `/bin/ksh`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/josephw/maven MNG-5837-avoid-non-posix-local-keyword
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/maven/pull/50.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #50
----
commit 1efce60e0594f7445f946aeb34f89e36907fdaf1
Author: Joseph Walton <jo...@kafsemo.org>
Date: 2015-06-07T13:29:39Z
MNG-5837: Use a subshell, rather than the 'local' keyword, for POSIX compliance.
'local' is not POSIX, but supported by most shells. However, it's not
supported by Solaris's /bin/sh, so use a subshell instead.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: MNG-5837: Use a subshell, rather than the 'loc...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/maven/pull/50
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: MNG-5837: Use a subshell, rather than the 'loc...
Posted by josephw <gi...@git.apache.org>.
Github user josephw commented on the pull request:
https://github.com/apache/maven/pull/50#issuecomment-138297741
@birkedal, does this change look okay after the switch to backticks? Or, if you're a Solaris user, does that other idiom seem better?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: MNG-5837: Use a subshell, rather than the 'loc...
Posted by josephw <gi...@git.apache.org>.
Github user josephw commented on the pull request:
https://github.com/apache/maven/pull/50#issuecomment-110022166
I've pushed a further change to switch $(..) to backticks. However, perhaps [this idiom](https://bugs.freedesktop.org/show_bug.cgi?id=5278) would be a better way to ensure a POSIX shell on Solaris:
# Do the Solaris Dance:
if [ ! -d ~root ] ; then
exec /usr/xpg4/bin/sh $0 "$@"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: MNG-5837: Use a subshell, rather than the 'loc...
Posted by birkedal <gi...@git.apache.org>.
Github user birkedal commented on the pull request:
https://github.com/apache/maven/pull/50#issuecomment-138463968
It works just fine after the switch to backticks :+1:
I have no opinion on whether that other idiom is better or not.
One more little detail; if JAVA_HOME is not set I get `mvn: !: not found` from the exclamation mark in the test on line 175. I would guess the same applies for lines 144 and 147 as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: MNG-5837: Use a subshell, rather than the 'loc...
Posted by birkedal <gi...@git.apache.org>.
Github user birkedal commented on the pull request:
https://github.com/apache/maven/pull/50#issuecomment-109946813
Looks like there are still problems on Solaris after applying the patch. It seams like it's the `$()` that is problematic. See this comment on [MNG-5658](https://issues.apache.org/jira/browse/MNG-5658): https://issues.apache.org/jira/browse/MNG-5658?focusedCommentId=14420034&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14420034
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: MNG-5837: Use a subshell, rather than the 'loc...
Posted by ChristianSchulte <gi...@git.apache.org>.
Github user ChristianSchulte commented on the pull request:
https://github.com/apache/maven/pull/50#issuecomment-165627334
Can you please 'rebase' the commit onto 'origin/master' so that I can merge it without conflicts?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org