You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Stefan Huehner (JIRA)" <ji...@apache.org> on 2006/12/01 00:56:21 UTC

[jira] Created: (OFBIZ-511) Patch to remove unnecessary casts

Patch to remove unnecessary casts
---------------------------------

                 Key: OFBIZ-511
                 URL: http://issues.apache.org/jira/browse/OFBIZ-511
             Project: OFBiz (The Open for Business Project)
          Issue Type: Improvement
    Affects Versions: SVN trunk
            Reporter: Stefan Huehner
            Priority: Trivial


Hi,

this patch removes some casts where the source-type and the casted-to type are identical. Therefore these casts are unnecessary and can/should be removed.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (OFBIZ-511) Patch to remove unnecessary casts

Posted by "Stefan Huehner (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/OFBIZ-511?page=all ]

Stefan Huehner updated OFBIZ-511:
---------------------------------

    Attachment: ofbiz_cast1a.diff

Please use this patch instead, which reverts one change in the previous diff (framework/base/src/base/org/ofbiz/base/util/KeyStoreUtil.java).
The former patch triggers a compile error when using the ant build script which i've missed as it didn't show up while building inside the ide.

> Patch to remove unnecessary casts
> ---------------------------------
>
>                 Key: OFBIZ-511
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-511
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>            Reporter: Stefan Huehner
>            Priority: Trivial
>         Attachments: ofbiz_cast1.diff, ofbiz_cast1a.diff
>
>
> Hi,
> this patch removes some casts where the source-type and the casted-to type are identical. Therefore these casts are unnecessary and can/should be removed.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Assigned: (OFBIZ-511) Patch to remove unnecessary casts

Posted by "Jacopo Cappellato (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/OFBIZ-511?page=all ]

Jacopo Cappellato reassigned OFBIZ-511:
---------------------------------------

    Assignee: Jacopo Cappellato

> Patch to remove unnecessary casts
> ---------------------------------
>
>                 Key: OFBIZ-511
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-511
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>            Reporter: Stefan Huehner
>         Assigned To: Jacopo Cappellato
>            Priority: Trivial
>         Attachments: ofbiz_cast1a.diff
>
>
> Hi,
> this patch removes some casts where the source-type and the casted-to type are identical. Therefore these casts are unnecessary and can/should be removed.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (OFBIZ-511) Patch to remove unnecessary casts

Posted by "Jacopo Cappellato (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/OFBIZ-511?page=all ]

Jacopo Cappellato updated OFBIZ-511:
------------------------------------

    Attachment:     (was: ofbiz_cast1.diff)

> Patch to remove unnecessary casts
> ---------------------------------
>
>                 Key: OFBIZ-511
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-511
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>            Reporter: Stefan Huehner
>            Priority: Trivial
>         Attachments: ofbiz_cast1a.diff
>
>
> Hi,
> this patch removes some casts where the source-type and the casted-to type are identical. Therefore these casts are unnecessary and can/should be removed.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (OFBIZ-511) Patch to remove unnecessary casts

Posted by "Jacopo Cappellato (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/OFBIZ-511?page=all ]

Jacopo Cappellato closed OFBIZ-511.
-----------------------------------

    Resolution: Fixed

Thanks Stefan,

your patch is in svn with rev. 481546

> Patch to remove unnecessary casts
> ---------------------------------
>
>                 Key: OFBIZ-511
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-511
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>            Reporter: Stefan Huehner
>         Assigned To: Jacopo Cappellato
>            Priority: Trivial
>         Attachments: ofbiz_cast1a.diff
>
>
> Hi,
> this patch removes some casts where the source-type and the casted-to type are identical. Therefore these casts are unnecessary and can/should be removed.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (OFBIZ-511) Patch to remove unnecessary casts

Posted by "Stefan Huehner (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/OFBIZ-511?page=all ]

Stefan Huehner updated OFBIZ-511:
---------------------------------

    Attachment: ofbiz_cast1.diff

> Patch to remove unnecessary casts
> ---------------------------------
>
>                 Key: OFBIZ-511
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-511
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>            Reporter: Stefan Huehner
>            Priority: Trivial
>         Attachments: ofbiz_cast1.diff
>
>
> Hi,
> this patch removes some casts where the source-type and the casted-to type are identical. Therefore these casts are unnecessary and can/should be removed.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira