[GitHub] [eventmesh] pandaapo commented on a diff in pull request #3981: [ISSUE #3978]Remove unnecessary annotations in TopicCreateRequest and add unit test.

["pandaapo (via GitHub)" <gi...@apache.org>]

pandaapo commented on code in PR #3981:
URL: https://github.com/apache/eventmesh/pull/3981#discussion_r1206469976


##########
eventmesh-admin/eventmesh-admin-rocketmq/src/main/java/org/apache/eventmesh/admin/rocketmq/request/TopicCreateRequest.java:
##########
@@ -30,16 +30,13 @@ public class TopicCreateRequest {
 
     @JsonCreator
     public TopicCreateRequest(@JsonProperty("name") String topic) {
-        super();
         this.name = topic;

Review Comment:
   I'm not sure. Maybe the author plan to add more fields to this class in the future.
   Will it be more readable than now when more fields are added to this class?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org