You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by GitBox <gi...@apache.org> on 2022/01/03 19:11:05 UTC
[GitHub] [mina-ftpserver] XenoAmess opened a new pull request #7: add checkstyle.
XenoAmess opened a new pull request #7:
URL: https://github.com/apache/mina-ftpserver/pull/7
you can invoke it by opening profile "enforce", for example, "mvn install -Penforce"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org
[GitHub] [mina-ftpserver] elecharny commented on pull request #7: add checkstyle.
Posted by GitBox <gi...@apache.org>.
elecharny commented on pull request #7:
URL: https://github.com/apache/mina-ftpserver/pull/7#issuecomment-1004690275
One of the issue is that it does not accept lines longer than 80 chars, despite the configuration that says 160 chars.
Do you have any idea how to get that fixed ?
Thanks !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org
[GitHub] [mina-ftpserver] elecharny commented on pull request #7: add checkstyle.
Posted by GitBox <gi...@apache.org>.
elecharny commented on pull request #7:
URL: https://github.com/apache/mina-ftpserver/pull/7#issuecomment-1004689350
Applied your patch, and forced the checkstyle version to 9.2.1.
There are many errors to be fixed in the source code now :-)
```
[INFO]
[INFO] ------------------< org.apache.ftpserver:ftplet-api >-------------------
[INFO] Building Apache Ftplet API 1.1.3-SNAPSHOT [2/8]
[INFO] -------------------------------[ bundle ]-------------------------------
[INFO]
[INFO] --- maven-checkstyle-plugin:3.1.2:checkstyle (default-cli) @ ftplet-api ---
[INFO] There are 383 errors reported by Checkstyle 9.2.1 with sun_checks.xml ruleset.
[INFO]
[INFO] ----------------< org.apache.ftpserver:ftpserver-core >-----------------
[INFO] Building Apache FtpServer Core 1.1.3-SNAPSHOT [3/8]
[INFO] -------------------------------[ bundle ]-------------------------------
[INFO]
[INFO] --- maven-checkstyle-plugin:3.1.2:checkstyle (default-cli) @ ftpserver-core ---
[INFO] There are 4423 errors reported by Checkstyle 9.2.1 with sun_checks.xml ruleset.
[WARNING] Unable to locate Source XRef to link to - DISABLED
[INFO]
[INFO] ---------< org.apache.ftpserver.examples:ftpserver-spring-war >---------
[INFO] Building FtpServer Spring web project example 1.1.3-SNAPSHOT [4/8]
[INFO] --------------------------------[ war ]---------------------------------
[INFO]
[INFO] --- maven-checkstyle-plugin:3.1.2:checkstyle (default-cli) @ ftpserver-spring-war ---
[INFO] There are 48 errors reported by Checkstyle 9.2.1 with sun_checks.xml ruleset.
[WARNING] Unable to locate Source XRef to link to - DISABLED
[INFO]
[INFO] ----< org.apache.ftpserver.examples:ftpserver-osgi-ftplet-service >-----
[INFO] Building FtpServer OSGi Ftplet service example 1.1.3-SNAPSHOT [5/8]
[INFO] -------------------------------[ bundle ]-------------------------------
[INFO]
[INFO] --- maven-checkstyle-plugin:3.1.2:checkstyle (default-cli) @ ftpserver-osgi-ftplet-service ---
[INFO] There are 18 errors reported by Checkstyle 9.2.1 with sun_checks.xml ruleset.
[WARNING] Unable to locate Source XRef to link to - DISABLED
[INFO]
[INFO] ----< org.apache.ftpserver.examples:ftpserver-osgi-spring-service >-----
[INFO] Building FtpServer OSGi Spring-DM example 1.1.3-SNAPSHOT [6/8]
[INFO] -------------------------------[ bundle ]-------------------------------
[INFO]
[INFO] --- maven-checkstyle-plugin:3.1.2:checkstyle (default-cli) @ ftpserver-osgi-spring-service ---
[INFO] There are 13 errors reported by Checkstyle 9.2.1 with sun_checks.xml ruleset.
[WARNING] Unable to locate Source XRef to link to - DISABLED
...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org
[GitHub] [mina-ftpserver] elecharny commented on pull request #7: add checkstyle.
Posted by GitBox <gi...@apache.org>.
elecharny commented on pull request #7:
URL: https://github.com/apache/mina-ftpserver/pull/7#issuecomment-1004705429
Also I'm trying to get rid of errors like:
```
<error line="33" column="22" severity="error" message="Le paramètre ftpletContext devrait être final." source="com.puppycrawl.tools.checkstyle.checks.FinalParametersCheck"/>
```
I tried to add it to the ```checkstyle-suppressions.xml ``` file:
```
...
<suppress checks="FinalParametersCheck" files=".*"/>
...
```
but that is not activated...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org
[GitHub] [mina-ftpserver] elecharny merged pull request #7: add checkstyle.
Posted by GitBox <gi...@apache.org>.
elecharny merged pull request #7:
URL: https://github.com/apache/mina-ftpserver/pull/7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org