You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by ygy <gi...@git.apache.org> on 2015/08/06 16:11:04 UTC
[GitHub] incubator-brooklyn pull request: [BROOKLYN-162] Renaming of the No...
GitHub user ygy opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/800
[BROOKLYN-162] Renaming of the NoSQL packages
- From brooklyn.entity.nosql to org.apache.brooklyn.entity.nosql
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ygy/incubator-brooklyn fix/nosql_package_org.apache
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/800.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #800
----
commit 69a113916fd499e8b336002145e07d43b33042c6
Author: Yavor Yanchev <ya...@yanchev.com>
Date: 2015-08-06T14:05:21Z
[BROOKLYN-162] Renaming of the NoSQL packages
- From brooklyn.entity.nosql to org.apache.brooklyn.entity.nosql
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: [BROOKLYN-162] Renaming of the No...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/800#discussion_r36435392
--- Diff: examples/simple-nosql-cluster/src/main/java/org/apache/brooklyn/demo/CumulusRDFApplication.java ---
@@ -138,8 +139,8 @@ public void initApp() {
cassandra = addChild(EntitySpec.create(CassandraFabric.class)
.configure(CassandraDatacenter.CLUSTER_NAME, "Brooklyn")
.configure(CassandraDatacenter.INITIAL_SIZE, getConfig(CASSANDRA_CLUSTER_SIZE)) // per location
- .configure(CassandraDatacenter.ENDPOINT_SNITCH_NAME, "brooklyn.entity.nosql.cassandra.customsnitch.MultiCloudSnitch")
- .configure(CassandraNode.CUSTOM_SNITCH_JAR_URL, "classpath://brooklyn/entity/nosql/cassandra/cassandra-multicloud-snitch.jar")
+ .configure(CassandraDatacenter.ENDPOINT_SNITCH_NAME, "org.apache.brooklyn.entity.nosql.cassandra.customsnitch.MultiCloudSnitch")
--- End diff --
Note that this will require us re-building the jar for MultiCloudSnitch (which shouldn't even be in brooklyn!).
See the comment at https://github.com/apache/incubator-brooklyn/pull/802#issuecomment-128424637
Also see docs/_extra/big_examples/nosql-cassandra/cassandra.include.md lines 191 and 205, where the `MultiCloudSnitch` is mentioned. We should do a global search for "MultiCloudSnitch".
Don't worry about it here. Let's fix it by moving MultiCloudSnitch somewhere more sensible in a completely different PR!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: [BROOKLYN-162] Renaming of the No...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/800
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: [BROOKLYN-162] Renaming of the No...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/800#issuecomment-128427836
Merging now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---