[GitHub] spark pull request #19525: [SPARK-22289] [ML] Add JSON support for Matrix pa...

[yanboliang <gi...@git.apache.org>]

Github user yanboliang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19525#discussion_r149534129
  
    --- Diff: mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala ---
    @@ -2769,6 +2769,20 @@ class LogisticRegressionSuite
           LogisticRegressionSuite.allParamSettings, checkModelData)
       }
     
    +  test("read/write with BoundsOnCoefficients") {
    +    def checkModelData(model: LogisticRegressionModel, model2: LogisticRegressionModel): Unit = {
    +      assert(model.getLowerBoundsOnCoefficients === model2.getLowerBoundsOnCoefficients)
    +      assert(model.getUpperBoundsOnCoefficients === model2.getUpperBoundsOnCoefficients)
    --- End diff --
    
    Or we can merge this test case with existing read/write test.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org