You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@thrift.apache.org by jf...@apache.org on 2014/02/22 01:37:55 UTC
git commit: THRIFT-2372:thrift/json_protocol.go:160: function ends
without a return statement Client: go Patch: jfarrell
Repository: thrift
Updated Branches:
refs/heads/master 8dbff98ae -> 3fa14a399
THRIFT-2372:thrift/json_protocol.go:160: function ends without a return statement
Client: go
Patch: jfarrell
Removes else block from function and just returns.
Project: http://git-wip-us.apache.org/repos/asf/thrift/repo
Commit: http://git-wip-us.apache.org/repos/asf/thrift/commit/3fa14a39
Tree: http://git-wip-us.apache.org/repos/asf/thrift/tree/3fa14a39
Diff: http://git-wip-us.apache.org/repos/asf/thrift/diff/3fa14a39
Branch: refs/heads/master
Commit: 3fa14a3990e973f0354059191bec34dcc8184af8
Parents: 8dbff98
Author: jfarrell <jf...@apache.org>
Authored: Fri Feb 21 19:37:13 2014 -0500
Committer: jfarrell <jf...@apache.org>
Committed: Fri Feb 21 19:37:13 2014 -0500
----------------------------------------------------------------------
lib/go/thrift/json_protocol.go | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/thrift/blob/3fa14a39/lib/go/thrift/json_protocol.go
----------------------------------------------------------------------
diff --git a/lib/go/thrift/json_protocol.go b/lib/go/thrift/json_protocol.go
index 7a5e16e..17fe530 100644
--- a/lib/go/thrift/json_protocol.go
+++ b/lib/go/thrift/json_protocol.go
@@ -158,12 +158,10 @@ func (p *TJSONProtocol) WriteSetEnd() error {
}
func (p *TJSONProtocol) WriteBool(b bool) error {
- //return p.OutputBool(b) - not for Thrift JSON
if b {
return p.WriteI32(1)
- } else {
- return p.WriteI32(0)
}
+ return p.WriteI32(0)
}
func (p *TJSONProtocol) WriteByte(b byte) error {