You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/30 03:59:42 UTC
[GitHub] [arrow-rs] aarashy opened a new pull request, #3232: Remove unwraps from 'create_primitive_array'
aarashy opened a new pull request, #3232:
URL: https://github.com/apache/arrow-rs/pull/3232
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Addresses part of https://github.com/apache/arrow-rs/issues/3215, but there is a separate mystery at play - what types of inputs were triggering panics at these unwraps - so I don't want to close the issue.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
See issue - attempting to read IPC bytes is sometimes triggering panic.
# What changes are included in this PR?
An internal function returns a result now instead of unwrapping.
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
No, the function is not `pub`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold merged pull request #3232: Remove unwraps from 'create_primitive_array'
Posted by GitBox <gi...@apache.org>.
tustvold merged PR #3232:
URL: https://github.com/apache/arrow-rs/pull/3232
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] ursabot commented on pull request #3232: Remove unwraps from 'create_primitive_array'
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #3232:
URL: https://github.com/apache/arrow-rs/pull/3232#issuecomment-1331883102
Benchmark runs are scheduled for baseline = afa83166bfe517b4f932b9ed0e527396b2023115 and contender = 54587e0dd49690a008d616750f23cdfc5f828c93. 54587e0dd49690a008d616750f23cdfc5f828c93 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/02d30e2af41c4bc58b1cba33ebbd2c3d...1f593ef70ba44b73a0a58fce01441e92/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/f33b541824094174b14733f947890dc9...ee6cb2035be54d5985914bff9f48a618/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/80d3a1c13d3b4e049a00e61d636b98c7...453933423fa9493c8dd458238268a519/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/ee6bf1ff266b45f2808f7ff92f463961...da49eb0557a84a709538d00635d36bae/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org