You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2018/03/30 15:01:27 UTC
[GitHub] csantanapr commented on issue #42: Update Swift 4.1 to swift-4.1-RELEASE
csantanapr commented on issue #42: Update Swift 4.1 to swift-4.1-RELEASE
URL: https://github.com/apache/incubator-openwhisk-runtime-swift/pull/42#issuecomment-377543170
Ah in comment
On Fri, Mar 30, 2018 at 11:00 AM David Grove <no...@github.com>
wrote:
> *@dgrove-oss* requested changes on this pull request.
>
> actually
> ------------------------------
>
> In core/swift41Action/Dockerfile
> <https://github.com/apache/incubator-openwhisk-runtime-swift/pull/42#discussion_r178306691>
> :
>
> > @@ -5,9 +5,10 @@ LABEL Description="Linux Ubuntu 14.04 image with the Swift binaries and tools."
> USER root
>
> # Set environment variables for image
> -# Using git hash https://github.com/apple/swift/commit/05b1b2be7c2bb1c238d3365a62d37d5e50a451c2
> -ENV <https://github.com/apple/swift/commit/05b1b2be7c2bb1c238d3365a62d37d5e50a451c2-ENV> SWIFT_SNAPSHOT swift-4.1-DEVELOPMENT-SNAPSHOT-2018-03-26-a
> -ENV SWIFT_SNAPSHOT_LOWERCASE swift-4.1-branch
> +# Using git hash https://github.com/apple/swift/commit/f01501c324876fc07820dc28923d7088fb7af847
> +https://swift.org/builds/swift-4.1-release/ubuntu1404/swift-4.1-RELEASE/swift-4.1-RELEASE-ubuntu14.04.tar.gz
> +ENV SWIFT_SNAPSHOT swift-4.1-RELEASE
>
> https is breaking travis. Supposed to be in a comment?
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/incubator-openwhisk-runtime-swift/pull/42#pullrequestreview-108351477>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ABC03l_889gIP6QuK1h5NLEKjSXxCtE9ks5tjkh0gaJpZM4TBMA4>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services