You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@griffin.apache.org by nezhazheng <gi...@git.apache.org> on 2018/05/24 10:06:05 UTC

[GitHub] incubator-griffin pull request #286: Fix livy parmas escape bug.

GitHub user nezhazheng opened a pull request:

    https://github.com/apache/incubator-griffin/pull/286

    Fix livy parmas escape bug.

    We escape '`' on SparkSubmitJob, but no unescpae when parse json on org.apache.griffin.measure.Application, so it will be encounter parse error when running job.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nezhazheng/incubator-griffin master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-griffin/pull/286.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #286
    
----
commit 2216f0cb89df35503e2b33c1796c628fda7304b1
Author: zhengshuli <zh...@...>
Date:   2018-05-24T10:04:05Z

    fix livy parmas escape bug.

----


---

[GitHub] incubator-griffin issue #286: Fix livy parmas escape bug.

Posted by bhlx3lyx7 <gi...@git.apache.org>.

Github user bhlx3lyx7 commented on the issue:

    https://github.com/apache/incubator-griffin/pull/286
  
    Hi @nezhazheng , I'll merge it ASAP, thanks for your PR.


---

[GitHub] incubator-griffin issue #286: Fix livy parmas escape bug.

Posted by guotechfin <gi...@git.apache.org>.

Github user guotechfin commented on the issue:

    https://github.com/apache/incubator-griffin/pull/286
  
    hi nezhazheng,
    
    Could you give us the livy bug id?
    
    Thanks,
    William


---

[GitHub] incubator-griffin pull request #286: Fix livy parmas escape bug.

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-griffin/pull/286


---

[GitHub] incubator-griffin issue #286: Fix livy parmas escape bug.

Posted by nezhazheng <gi...@git.apache.org>.

Github user nezhazheng commented on the issue:

    https://github.com/apache/incubator-griffin/pull/286
  
    @bhlx3lyx7 Could you give a review please.


---

[GitHub] incubator-griffin issue #286: Fix livy parmas escape bug.

Posted by bhlx3lyx7 <gi...@git.apache.org>.

Github user bhlx3lyx7 commented on the issue:

    https://github.com/apache/incubator-griffin/pull/286
  
    Hi @nezhazheng , thanks for your PR, I've reviewed the code, but it seems to be only in some specific case.
    For measure module alone, it should not fix the issues caused by the previous component. 
    If livy has such bug, it should fix it, or give some workaround. I'm afraid it's not a common solution here.


---

[GitHub] incubator-griffin issue #286: Fix livy parmas escape bug.

Posted by bhlx3lyx7 <gi...@git.apache.org>.

Github user bhlx3lyx7 commented on the issue:

    https://github.com/apache/incubator-griffin/pull/286
  
    Hi @nezhazheng , we had also handled that situation in service module before submit to livy [here](https://github.com/apache/incubator-griffin/blob/master/service/src/main/java/org/apache/griffin/core/job/SparkSubmitJob.java#L181), I think in your case you can just add one escape character '\\' before '`', measure module will work well without doing anything.


---