You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2015/01/09 00:21:59 UTC
Review Request 29730: Added more overloads for path::join.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29730/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Repository: mesos-git
Description
-------
Added more overloads for path::join.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp 4f7153eb873e9b843fa6d8067bfbfcbf8932cb40
Diff: https://reviews.apache.org/r/29730/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 29730: Added more overloads for path::join.
Posted by Cody Maloney <co...@mesosphere.io>.
> On Jan. 9, 2015, 12:12 a.m., Ben Mahler wrote:
> > Keep in mind Cody was planning to re-add the variadic version (MESOS-1878), not sure where that stuff stands.
This looks good to me for now. The variadic as we found out last time is surprisingly difficult.
Waiting for some time to work on it since it's just a nice to have / not mandatory for any projects (Some bugs in "files/" came up but aren't a pressing issue). I still need to get back to https://reviews.apache.org/r/27606/. After that there will probably be 1 or 2 patches followed by the variadic switch.
- Cody
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29730/#review67338
-----------------------------------------------------------
On Jan. 8, 2015, 11:21 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29730/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2015, 11:21 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Added more overloads for path::join.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp 4f7153eb873e9b843fa6d8067bfbfcbf8932cb40
>
> Diff: https://reviews.apache.org/r/29730/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 29730: Added more overloads for path::join.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29730/#review67338
-----------------------------------------------------------
Ship it!
Keep in mind Cody was planning to re-add the variadic version (MESOS-1878), not sure where that stuff stands.
- Ben Mahler
On Jan. 8, 2015, 11:21 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29730/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2015, 11:21 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Added more overloads for path::join.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp 4f7153eb873e9b843fa6d8067bfbfcbf8932cb40
>
> Diff: https://reviews.apache.org/r/29730/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>