You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/08/23 17:02:43 UTC
[GitHub] [tvm] trahman-quic opened a new pull request, #12559: [TOPI][Hexagon] Add test and schedule for uint8 resize2d
trahman-quic opened a new pull request, #12559:
URL: https://github.com/apache/tvm/pull/12559
Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @ them in the pull request thread.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mehrdadh commented on pull request #12559: [TOPI][Hexagon] Add test and schedule for uint8 resize2d
Posted by GitBox <gi...@apache.org>.
mehrdadh commented on PR #12559:
URL: https://github.com/apache/tvm/pull/12559#issuecomment-1234807229
@trahman-quic please update the PR description. The link that you provided is not open to public
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] kparzysz-quic merged pull request #12559: [TOPI][Hexagon] Add test and schedule for uint8 resize2d
Posted by GitBox <gi...@apache.org>.
kparzysz-quic merged PR #12559:
URL: https://github.com/apache/tvm/pull/12559
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] trahman-quic commented on pull request #12559: [TOPI][Hexagon] Add test and schedule for uint8 resize2d
Posted by GitBox <gi...@apache.org>.
trahman-quic commented on PR #12559:
URL: https://github.com/apache/tvm/pull/12559#issuecomment-1224422346
The details for the changes in this [commit ](https://github.com/apache/tvm/pull/12559/commits/8362a560c329e3235ac5e93bfbaadc417e4b6ede) for this PR can be referred to [here](https://octoml.atlassian.net/servicedesk/customer/portal/13/OEHD-40)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] jverma-quic commented on a diff in pull request #12559: [TOPI][Hexagon] Add test and schedule for uint8 resize2d
Posted by GitBox <gi...@apache.org>.
jverma-quic commented on code in PR #12559:
URL: https://github.com/apache/tvm/pull/12559#discussion_r965462006
##########
tests/python/contrib/test_hexagon/topi/test_resize2d.py:
##########
@@ -26,26 +26,46 @@
@tvm.testing.fixture
def expected_output_np(
- input_np, in_height, in_width, out_height, out_width, layout, method, coord_trans
+ input_np,
+ in_height,
+ in_width,
+ out_height,
+ out_width,
+ layout,
+ method,
+ coord_trans,
+ dtype,
):
scale_h = out_height / in_height
scale_w = out_width / in_width
+
return resize2d_python(input_np, (scale_h, scale_w), layout, method, coord_trans)
@tvm.testing.fixture
def input_np(input_shape, dtype):
- return np.random.random(input_shape).astype(dtype)
+ if dtype == "float16":
+ return np.random.random(input_shape).astype(dtype)
+ elif dtype == "uint8":
Review Comment:
unnecessary 'elif' after 'return'. elif-> if
same issue at a few other places where else appears after 'return'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org