You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/02/27 00:43:56 UTC
[GitHub] [superset] eschutho opened a new pull request #13365: add more documentation around python testing and linting
eschutho opened a new pull request #13365:
URL: https://github.com/apache/superset/pull/13365
### SUMMARY
I was recently writing some python tests and found that there were a few common ways of testing and linting that weren't documented.
### TEST PLAN
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on pull request #13365: docs: add more documentation around python testing and linting
Posted by GitBox <gi...@apache.org>.
eschutho commented on pull request #13365:
URL: https://github.com/apache/superset/pull/13365#issuecomment-788322788
@betodealmeida wdyt?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] betodealmeida merged pull request #13365: docs: add more documentation around python testing and linting
Posted by GitBox <gi...@apache.org>.
betodealmeida merged pull request #13365:
URL: https://github.com/apache/superset/pull/13365
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho removed a comment on pull request #13365: docs: add more documentation around python testing and linting
Posted by GitBox <gi...@apache.org>.
eschutho removed a comment on pull request #13365:
URL: https://github.com/apache/superset/pull/13365#issuecomment-788479790
great, thanks!
🏷 ready-to-merge
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho edited a comment on pull request #13365: docs: add more documentation around python testing and linting
Posted by GitBox <gi...@apache.org>.
eschutho edited a comment on pull request #13365:
URL: https://github.com/apache/superset/pull/13365#issuecomment-788479790
great, thanks!
🏷 ready-to-merge
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on pull request #13365: docs: add more documentation around python testing and linting
Posted by GitBox <gi...@apache.org>.
eschutho commented on pull request #13365:
URL: https://github.com/apache/superset/pull/13365#issuecomment-788479790
great, thanks! 🏷 ready-to-merge
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #13365: docs: add more documentation around python testing and linting
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #13365:
URL: https://github.com/apache/superset/pull/13365#issuecomment-786974905
# [Codecov](https://codecov.io/gh/apache/superset/pull/13365?src=pr&el=h1) Report
> Merging [#13365](https://codecov.io/gh/apache/superset/pull/13365?src=pr&el=desc) (a585788) into [master](https://codecov.io/gh/apache/superset/commit/b4ca39ceeba557d4a8dfaa219e62389716cf76e8?el=desc) (b4ca39c) will **decrease** coverage by `4.41%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13365/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13365?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13365 +/- ##
==========================================
- Coverage 77.12% 72.70% -4.42%
==========================================
Files 894 596 -298
Lines 45672 21260 -24412
Branches 5492 5497 +5
==========================================
- Hits 35223 15457 -19766
+ Misses 10325 5679 -4646
Partials 124 124
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.59% <ø> (-0.49%)` | :arrow_down: |
| hive | `?` | |
| javascript | `62.49% <ø> (+0.09%)` | :arrow_up: |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `?` | |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13365?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/ChartErrorMessage.tsx](https://codecov.io/gh/apache/superset/pull/13365/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0RXJyb3JNZXNzYWdlLnRzeA==) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...rontend/src/components/ErrorMessage/ErrorAlert.tsx](https://codecov.io/gh/apache/superset/pull/13365/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0Vycm9yQWxlcnQudHN4) | `20.40% <0.00%> (-36.74%)` | :arrow_down: |
| [...onents/ErrorMessage/ErrorMessageWithStackTrace.tsx](https://codecov.io/gh/apache/superset/pull/13365/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0Vycm9yTWVzc2FnZVdpdGhTdGFja1RyYWNlLnRzeA==) | `27.77% <0.00%> (-33.34%)` | :arrow_down: |
| [...t-frontend/src/common/hooks/apiResources/charts.ts](https://codecov.io/gh/apache/superset/pull/13365/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy9hcGlSZXNvdXJjZXMvY2hhcnRzLnRz) | `50.00% <0.00%> (-25.00%)` | :arrow_down: |
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13365/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `64.15% <0.00%> (-15.10%)` | :arrow_down: |
| [.../explore/components/controls/DatasourceControl.jsx](https://codecov.io/gh/apache/superset/pull/13365/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRhc291cmNlQ29udHJvbC5qc3g=) | `62.68% <0.00%> (-1.50%)` | :arrow_down: |
| [...set-frontend/src/common/components/Modal/Modal.tsx](https://codecov.io/gh/apache/superset/pull/13365/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL01vZGFsL01vZGFsLnRzeA==) | `100.00% <0.00%> (ø)` | |
| [superset/jinja\_context.py](https://codecov.io/gh/apache/superset/pull/13365/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | | |
| [superset/models/reports.py](https://codecov.io/gh/apache/superset/pull/13365/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3JlcG9ydHMucHk=) | | |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13365/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | | |
| ... and [301 more](https://codecov.io/gh/apache/superset/pull/13365/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13365?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13365?src=pr&el=footer). Last update [b4ca39c...3cc6b9a](https://codecov.io/gh/apache/superset/pull/13365?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org