You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by "Ayasaz (via GitHub)" <gi...@apache.org> on 2026/06/18 07:07:27 UTC

Re: [I] SelectStatementContext#isSameGroupByAndOrderByItems has bug [shardingsphere]

Ayasaz commented on issue #23014:
URL: https://github.com/apache/shardingsphere/issues/23014#issuecomment-4738945400

   I've opened #38863 implementing the fix along the lines of @terrymanu's analysis: `isSameGroupByAndOrderByItems` now compares the group by / order by item index sequence only and ignores sort direction, so `GROUP BY col1, col2 ORDER BY col1 DESC, col2 DESC` no longer expands pagination to `LIMIT 0, 2147483647` or falls back to memory group merge. Direction stays honored by `GroupByRowComparator`. Affected-module tests (`infra/binder/core`, `infra/rewrite/core`, `features/sharding/core`) pass locally. Review and feedback welcome.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org