[GitHub] xtinec commented on a change in pull request #5759: Bug: fixing async syntax for python 3.7

[GitBox <gi...@apache.org>]

xtinec commented on a change in pull request #5759: Bug: fixing async syntax for python 3.7
URL: https://github.com/apache/incubator-superset/pull/5759#discussion_r213485366
 
 

 ##########
 File path: superset/db_engine_specs.py
 ##########
 @@ -1276,8 +1276,8 @@ def get_configuration_for_impersonation(cls, uri, impersonate_user, username):
         return configuration
 
     @staticmethod
-    def execute(cursor, query, async=False):
-        cursor.execute(query, async=async)
+    def execute(cursor, query, async_=False):
 
 Review comment:
   Should this one be `def execute(cursor, query, **kwargs):`? Then downstream systems like PyHive can specify `async_`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org