You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@grails.apache.org by "codeconsole (via GitHub)" <gi...@apache.org> on 2026/06/17 22:51:01 UTC

[PR] Do not close an externally-supplied MongoClient in GORM for MongoDB [grails-core]

codeconsole opened a new pull request, #15743:
URL: https://github.com/apache/grails-core/pull/15743

## What

GORM's connection-source shutdown closes any `Closeable` source, and `com.mongodb.client.MongoClient` is `Closeable`, so a client handed to GORM — a Spring-managed bean, or one passed to `new MongoDatastore(mongoClient, ...)` — was closed when the datastore shut down. That double-closes a client whose lifecycle is owned elsewhere.

This makes GORM **not close a `MongoClient` it did not create**:

- `DefaultConnectionSource` gains a non-closeable mode (new 4-arg constructor + `isCloseable()`); the existing constructor is unchanged, so there is no behavior change for current callers.
- `MongoDatastore.createDefaultConnectionSources` wraps an externally-supplied client as non-closeable.
- `MongoDbGormAutoConfiguration` implements `DisposableBean` and closes only the client it created itself; a client supplied as a bean is left for the application context to close.

GORM still closes clients it creates from `grails.mongodb.*` configuration.

## Why

- Removes a redundant double-close in the common Spring Boot setup (Spring already owns and closes the `MongoClient` bean).
- Establishes "whoever creates the client owns closing it" — the safe basis for sharing one `MongoClient` across GORM and other consumers.

## Behavior change

The only externally-visible change: callers that relied on `MongoDatastore.close()` to also close a client they passed in must now close it themselves. Documented in the upgrade notes.

## Tests

- `DefaultConnectionSourceSpec` — closes by default; no-op when non-closeable; closes an `AutoCloseable` when closeable.
- `MongoDatastoreExternalClientSpec` — a supplied client is not closed on datastore shutdown.
- `MongoDbGormAutoConfigurationCloseSpec` — the auto-config closes only an internally-created client.

Targets `8.0.x`.

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Do not close an externally-supplied MongoClient in GORM for MongoDB [grails-core]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.

codecov[bot] commented on PR #15743:
URL: https://github.com/apache/grails-core/pull/15743#issuecomment-4774226552

   ## [Codecov](https://app.codecov.io/gh/apache/grails-core/pull/15743?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 0.0000%. Comparing base ([`098660a`](https://app.codecov.io/gh/apache/grails-core/commit/098660ad3ceea412bd8b25eb1bb19ebf6aecd441?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d95eb44`](https://app.codecov.io/gh/apache/grails-core/commit/d95eb4418714bf912ce3003ce4ac98ce5854be47?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 203 commits behind head on 8.0.x.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   [![Impacted file tree graph](https://app.codecov.io/gh/apache/grails-core/pull/15743/graphs/tree.svg?width=650&height=150&src=pr&token=qJrryhpk7u&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)](https://app.codecov.io/gh/apache/grails-core/pull/15743?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   ```diff
   @@                Coverage Diff                @@
   ##                8.0.x   #15743         +/-   ##
   =================================================
   - Coverage     48.3729%        0   -48.3729%     
   =================================================
     Files            1870        0       -1870     
     Lines           85457        0      -85457     
     Branches        14900        0      -14900     
   =================================================
   - Hits            41338        0      -41338     
   + Misses          37784        0      -37784     
   + Partials         6335        0       -6335     
   ```
   [see 1870 files with indirect coverage changes](https://app.codecov.io/gh/apache/grails-core/pull/15743/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Do not close an externally-supplied MongoClient in GORM for MongoDB [grails-core]

Posted by "borinquenkid (via GitHub)" <gi...@apache.org>.

borinquenkid commented on PR #15743:
URL: https://github.com/apache/grails-core/pull/15743#issuecomment-4759258258

   I'm sure this is not a totally rational fear, but I would point to https://github.com/apache/grails-core/pull/15678 since there was reworking of datastore creation


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org