You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/03 05:57:56 UTC

[GitHub] [pulsar] michaeljmarshall commented on a diff in pull request #15637: [Broker][Proxy][Function worker] Remove duplicate servlet filter instances to fix backpressure

michaeljmarshall commented on code in PR #15637:
URL: https://github.com/apache/pulsar/pull/15637#discussion_r888633378


##########
pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/WorkerServer.java:
##########
@@ -171,18 +174,52 @@ private void init() {
         server.setConnectors(connectors.toArray(new ServerConnector[connectors.size()]));
     }
 
-    public static ServletContextHandler newServletContextHandler(String contextPath,
+    private static class FilterInitializer {

Review Comment:
   I see that this class is duplicated across several classes. What is the motivation for duplicating the code?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org