[GitHub] [spark] HyukjinKwon commented on a diff in pull request #42744: [SPARK-44990][SQL][FOLLOWUP] Add benchmark for write null value to csv

["HyukjinKwon (via GitHub)" <gi...@apache.org>]

HyukjinKwon commented on code in PR #42744:
URL: https://github.com/apache/spark/pull/42744#discussion_r1311078655


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/csv/UnivocityGenerator.scala:
##########
@@ -60,7 +60,7 @@ class UnivocityGenerator(
     options.locale,
     legacyFormat = FAST_DATE_FORMAT,
     isParsing = false)
-  private lazy val nullAsQuotedEmptyString =
+  private val nullAsQuotedEmptyString =

Review Comment:
   I don't think there'd be meaningful result in the benchmark :-). LGTM



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org