You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/03/22 08:58:59 UTC
[GitHub] [superset] simcha90 opened a new pull request #13726: feat(native-filters): Add default first value to select filter
simcha90 opened a new pull request #13726:
URL: https://github.com/apache/superset/pull/13726
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
This PR add option to choose by default first value for select filter plugin. This feature has more priority then default value, so if this feature enabled it will used instead of default value
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
https://user-images.githubusercontent.com/56388545/111964632-7ccb7680-8afd-11eb-8842-46efb6dfb2cb.mov
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] simcha90 commented on a change in pull request #13726: feat(native-filters): Add default first value to select filter
Posted by GitBox <gi...@apache.org>.
simcha90 commented on a change in pull request #13726:
URL: https://github.com/apache/superset/pull/13726#discussion_r611343047
##########
File path: superset-frontend/src/filters/components/Select/SelectFilterPlugin.tsx
##########
@@ -51,39 +53,62 @@ export default function PluginFilterSelect(props: PluginFilterSelectProps) {
currentValue,
inverseSelection,
inputRef,
+ defaultToFirstItem,
} = formData;
- const [values, setValues] = useState<(string | number | boolean)[]>(
- defaultValue ?? [],
- );
+ const forceFirstValue =
+ appSection === AppSection.FILTER_CONFIG_MODAL && defaultToFirstItem;
+
const groupby = ensureIsArray<string>(formData.groupby);
+ // Correct initial value for Ant Select
+ const initSelectValue: SelectValue =
+ // `defaultValue` can be `FIRST_VALUE` if `defaultToFirstItem` is checked, so need convert it to correct value for Select
+ defaultValue === FIRST_VALUE ? [] : defaultValue ?? [];
+
+ const firstItem: SelectValue = data[0]
+ ? (groupby.map(col => data[0][col]) as string[]) ?? initSelectValue
+ : initSelectValue;
+
+ // If we are in config modal we always need show empty select for `defaultToFirstItem`
+ const [values, setValues] = useState<SelectValue>(
+ defaultToFirstItem && appSection !== AppSection.FILTER_CONFIG_MODAL
+ ? firstItem
+ : initSelectValue,
+ );
const [col] = groupby;
const datatype: GenericDataType = coltypeMap[col];
const labelFormatter = getDataRecordFormatter({
timeFormatter: smartDateDetailedFormatter,
});
- const handleChange = (
- value?: (number | string)[] | number | string | null,
- ) => {
- const resultValue: (number | string)[] = ensureIsArray<number | string>(
- value,
- );
- setValues(resultValue);
+ const handleChange = (value?: SelectValue | number | string) => {
+ let selectValue: (number | string)[];
+ if (value === FIRST_VALUE) {
+ selectValue = forceFirstValue ? [] : firstItem;
+ } else {
+ selectValue = ensureIsArray<number | string>(value);
+ }
+ setValues(selectValue);
const emptyFilter =
- enableEmptyFilter && !inverseSelection && resultValue?.length === 0;
+ enableEmptyFilter && !inverseSelection && selectValue?.length === 0;
+
+ // Set currentState value for a case of non-`defaultToFirstItem`
+ const stateValue = selectValue.length ? selectValue : null;
const dataMask = {
extraFormData: getSelectExtraFormData(
col,
- resultValue,
+ selectValue,
emptyFilter,
inverseSelection,
),
currentState: {
- value: resultValue.length ? resultValue : null,
+ // We need to save in state `FIRST_VALUE` as some const and not as REAL value,
+ // because when FiltersBar check if all filters initialized it compares `defaultValue` with this value
+ // and because REAL value can be unpredictable for users that have different data for same dashboard we use `FIRST_VALUE`
+ value: value === FIRST_VALUE ? FIRST_VALUE : stateValue,
Review comment:
I simplified logic can you look please one more time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13726: feat(native-filters): Add default first value to select filter
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13726:
URL: https://github.com/apache/superset/pull/13726#issuecomment-804173881
# [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=h1) Report
> Merging [#13726](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=desc) (7a4b38c) into [master](https://codecov.io/gh/apache/superset/commit/abd4051f7a94b7e1a653ae6c0590645b0fe1dd33?el=desc) (abd4051) will **decrease** coverage by `4.93%`.
> The diff coverage is `75.00%`.
> :exclamation: Current head 7a4b38c differs from pull request most recent head 58b9199. Consider uploading reports for the commit 58b9199 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13726 +/- ##
==========================================
- Coverage 78.03% 73.10% -4.94%
==========================================
Files 934 626 -308
Lines 47349 22229 -25120
Branches 5943 5797 -146
==========================================
- Hits 36950 16251 -20699
+ Misses 10254 5836 -4418
+ Partials 145 142 -3
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.50% <85.71%> (+2.82%)` | :arrow_up: |
| hive | `?` | |
| javascript | `63.12% <0.00%> (-3.21%)` | :arrow_down: |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `?` | |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tend/src/filters/components/Select/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvY29udHJvbFBhbmVsLnRz) | `18.18% <0.00%> (-1.82%)` | :arrow_down: |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `100.00% <ø> (ø)` | |
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `80.43% <85.71%> (-0.52%)` | :arrow_down: |
| [...controls/DndColumnSelectControl/DndSelectLabel.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZFNlbGVjdExhYmVsLnRzeA==) | `35.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...trols/DateFilterControl/components/CustomFrame.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0N1c3RvbUZyYW1lLnRzeA==) | `42.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...ols/DateFilterControl/components/AdvancedFrame.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0FkdmFuY2VkRnJhbWUudHN4) | `53.84% <0.00%> (-46.16%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLnRz) | `46.66% <0.00%> (-40.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `63.63% <0.00%> (-36.37%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `63.63% <0.00%> (-36.37%)` | :arrow_down: |
| [...ontrols/DndColumnSelectControl/DndFilterSelect.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZEZpbHRlclNlbGVjdC50c3g=) | `9.23% <0.00%> (-36.16%)` | :arrow_down: |
| ... and [453 more](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=footer). Last update [abd4051...58b9199](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on a change in pull request #13726: feat(native-filters): Add default first value to select filter
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #13726:
URL: https://github.com/apache/superset/pull/13726#discussion_r598702354
##########
File path: superset-frontend/src/filters/components/Select/SelectFilterPlugin.tsx
##########
@@ -118,18 +122,22 @@ export default function PluginFilterSelect(props: PluginFilterSelectProps) {
handleChange(currentValue ?? []);
}, [
JSON.stringify(currentValue),
+ defaultToFirstItem,
multiSelect,
enableEmptyFilter,
inverseSelection,
]);
useEffect(() => {
- handleChange(defaultValue ?? []);
+ handleChange(defaultToFirstItem ? firstItem : initValues);
}, [
JSON.stringify(defaultValue),
+ JSON.stringify(firstItem),
+ defaultToFirstItem,
multiSelect,
enableEmptyFilter,
inverseSelection,
+ defaultToFirstItem,
Review comment:
`defaultToFirstItem` seems to be here twice
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13726: feat(native-filters): Add default first value to select filter
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13726:
URL: https://github.com/apache/superset/pull/13726#issuecomment-804173881
# [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=h1) Report
> Merging [#13726](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=desc) (7a4b38c) into [master](https://codecov.io/gh/apache/superset/commit/56dc74e09f1665c1030a8e6ccf66e27fb4f24e9b?el=desc) (56dc74e) will **decrease** coverage by `5.51%`.
> The diff coverage is `75.00%`.
> :exclamation: Current head 7a4b38c differs from pull request most recent head 5e0e87a. Consider uploading reports for the commit 5e0e87a to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13726 +/- ##
==========================================
- Coverage 78.62% 73.10% -5.52%
==========================================
Files 936 626 -310
Lines 47408 22229 -25179
Branches 5941 5797 -144
==========================================
- Hits 37275 16251 -21024
+ Misses 10001 5836 -4165
- Partials 132 142 +10
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.50% <85.71%> (-2.59%)` | :arrow_down: |
| javascript | `63.12% <0.00%> (-5.33%)` | :arrow_down: |
| mysql | `?` | |
| postgres | `?` | |
| python | `?` | |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tend/src/filters/components/Select/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvY29udHJvbFBhbmVsLnRz) | `18.18% <0.00%> (-1.82%)` | :arrow_down: |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `100.00% <ø> (ø)` | |
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `80.43% <85.71%> (-0.52%)` | :arrow_down: |
| [...tend/src/dashboard/util/getFilterFieldNodesTree.js](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlckZpZWxkTm9kZXNUcmVlLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...end/src/dashboard/util/getKeyForFilterScopeTree.js](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEtleUZvckZpbHRlclNjb3BlVHJlZS5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...nd/src/dashboard/util/getFilterScopeParentNodes.js](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlUGFyZW50Tm9kZXMuanM=) | `0.00% <0.00%> (-91.67%)` | :arrow_down: |
| [...ponents/filterscope/renderFilterFieldTreeNodes.jsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL3JlbmRlckZpbHRlckZpZWxkVHJlZU5vZGVzLmpzeA==) | `0.00% <0.00%> (-90.00%)` | :arrow_down: |
| [...ponents/filterscope/renderFilterScopeTreeNodes.jsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL3JlbmRlckZpbHRlclNjb3BlVHJlZU5vZGVzLmpzeA==) | `0.00% <0.00%> (-86.67%)` | :arrow_down: |
| [...ard/components/filterscope/FilterScopeSelector.jsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlclNjb3BlU2VsZWN0b3IuanN4) | `2.05% <0.00%> (-85.62%)` | :arrow_down: |
| [...board/util/getSelectedChartIdForFilterScopeTree.js](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldFNlbGVjdGVkQ2hhcnRJZEZvckZpbHRlclNjb3BlVHJlZS5qcw==) | `0.00% <0.00%> (-80.00%)` | :arrow_down: |
| ... and [523 more](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=footer). Last update [56dc74e...5e0e87a](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13726: feat(native-filters): Add default first value to select filter
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13726:
URL: https://github.com/apache/superset/pull/13726#issuecomment-804173881
# [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=h1) Report
> Merging [#13726](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=desc) (8ccb6f0) into [master](https://codecov.io/gh/apache/superset/commit/a4fd6b8f33e9e780084a71f3e5b579468cdd635b?el=desc) (a4fd6b8) will **decrease** coverage by `0.26%`.
> The diff coverage is `86.20%`.
> :exclamation: Current head 8ccb6f0 differs from pull request most recent head 5f37308. Consider uploading reports for the commit 5f37308 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13726 +/- ##
==========================================
- Coverage 79.30% 79.04% -0.27%
==========================================
Files 939 939
Lines 47541 47541
Branches 5938 5938
==========================================
- Hits 37703 37579 -124
- Misses 9717 9841 +124
Partials 121 121
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `80.71% <ø> (ø)` | |
| postgres | `80.74% <ø> (ø)` | |
| presto | `?` | |
| python | `80.82% <ø> (-0.49%)` | :arrow_down: |
| sqlite | `80.34% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tend/src/filters/components/Select/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvY29udHJvbFBhbmVsLnRz) | `20.00% <0.00%> (ø)` | |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `100.00% <ø> (ø)` | |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <ø> (ø)` | |
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `80.48% <84.21%> (ø)` | |
| [...tersConfigModal/FiltersConfigForm/DefaultValue.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0RlZmF1bHRWYWx1ZS50c3g=) | `100.00% <100.00%> (ø)` | |
| [...nd/src/filters/components/Select/transformProps.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHJhbnNmb3JtUHJvcHMudHM=) | `81.81% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.42% <0.00%> (-16.42%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.79% <0.00%> (-8.16%)` | :arrow_down: |
| ... and [7 more](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=footer). Last update [a4fd6b8...5f37308](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13726: feat(native-filters): Add default first value to select filter
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13726:
URL: https://github.com/apache/superset/pull/13726#issuecomment-804173881
# [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=h1) Report
> Merging [#13726](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=desc) (57ff3b1) into [master](https://codecov.io/gh/apache/superset/commit/a4fd6b8f33e9e780084a71f3e5b579468cdd635b?el=desc) (a4fd6b8) will **decrease** coverage by `0.02%`.
> The diff coverage is `79.16%`.
> :exclamation: Current head 57ff3b1 differs from pull request most recent head 9db8487. Consider uploading reports for the commit 9db8487 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13726 +/- ##
==========================================
- Coverage 79.30% 79.28% -0.03%
==========================================
Files 939 939
Lines 47541 47552 +11
Branches 5938 5947 +9
==========================================
- Hits 37703 37702 -1
- Misses 9717 9729 +12
Partials 121 121
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.06% <85.71%> (+1.82%)` | :arrow_up: |
| hive | `?` | |
| javascript | `69.37% <4.16%> (-0.04%)` | :arrow_down: |
| mysql | `80.71% <ø> (ø)` | |
| postgres | `80.74% <ø> (+<0.01%)` | :arrow_up: |
| presto | `?` | |
| python | `80.82% <ø> (-0.49%)` | :arrow_down: |
| sqlite | `80.34% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tend/src/filters/components/Select/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvY29udHJvbFBhbmVsLnRz) | `18.18% <0.00%> (-1.82%)` | :arrow_down: |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <ø> (ø)` | |
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `78.00% <80.00%> (-2.49%)` | :arrow_down: |
| [...tersConfigModal/FiltersConfigForm/DefaultValue.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0RlZmF1bHRWYWx1ZS50c3g=) | `100.00% <100.00%> (ø)` | |
| [...nd/src/filters/components/Select/transformProps.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHJhbnNmb3JtUHJvcHMudHM=) | `81.81% <100.00%> (ø)` | |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.42% <0.00%> (-16.42%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.79% <0.00%> (-8.16%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| ... and [20 more](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=footer). Last update [a4fd6b8...9db8487](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13726: feat(native-filters): Add default first value to select filter
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13726:
URL: https://github.com/apache/superset/pull/13726#issuecomment-804173881
# [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=h1) Report
> Merging [#13726](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=desc) (de733f3) into [master](https://codecov.io/gh/apache/superset/commit/56dc74e09f1665c1030a8e6ccf66e27fb4f24e9b?el=desc) (56dc74e) will **decrease** coverage by `0.30%`.
> The diff coverage is `48.78%`.
[](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13726 +/- ##
==========================================
- Coverage 78.87% 78.56% -0.31%
==========================================
Files 936 936
Lines 47408 47459 +51
Branches 5941 5965 +24
==========================================
- Hits 37393 37287 -106
- Misses 9883 10031 +148
- Partials 132 141 +9
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `51.81% <85.71%> (-7.29%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tend/src/filters/components/Select/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvY29udHJvbFBhbmVsLnRz) | `16.66% <0.00%> (-3.34%)` | :arrow_down: |
| [...nd/src/filters/components/Select/transformProps.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHJhbnNmb3JtUHJvcHMudHM=) | `50.00% <12.50%> (-31.82%)` | :arrow_down: |
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `55.55% <55.17%> (-25.40%)` | :arrow_down: |
| [...tersConfigModal/FiltersConfigForm/DefaultValue.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0RlZmF1bHRWYWx1ZS50c3g=) | `96.29% <100.00%> (-3.71%)` | :arrow_down: |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `66.66% <100.00%> (-33.34%)` | :arrow_down: |
| [...ontend/src/dashboard/util/serializeFilterScopes.js](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3NlcmlhbGl6ZUZpbHRlclNjb3Blcy5qcw==) | `40.00% <0.00%> (-60.00%)` | :arrow_down: |
| [...et-frontend/src/dashboard/components/SaveModal.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NhdmVNb2RhbC50c3g=) | `47.16% <0.00%> (-33.97%)` | :arrow_down: |
| [...hboard/components/resizable/ResizableContainer.jsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVDb250YWluZXIuanN4) | `71.87% <0.00%> (-28.13%)` | :arrow_down: |
| [...ntrols/MetricControl/AdhocMetricPopoverTrigger.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljUG9wb3ZlclRyaWdnZXIudHN4) | `70.00% <0.00%> (-25.00%)` | :arrow_down: |
| [...rontend/src/dashboard/components/DashboardGrid.jsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Rhc2hib2FyZEdyaWQuanN4) | `66.66% <0.00%> (-22.81%)` | :arrow_down: |
| ... and [51 more](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=footer). Last update [56dc74e...de733f3](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13726: feat(native-filters): Add default first value to select filter
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13726:
URL: https://github.com/apache/superset/pull/13726#issuecomment-804173881
# [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=h1) Report
> Merging [#13726](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=desc) (de733f3) into [master](https://codecov.io/gh/apache/superset/commit/56dc74e09f1665c1030a8e6ccf66e27fb4f24e9b?el=desc) (56dc74e) will **decrease** coverage by `0.30%`.
> The diff coverage is `48.78%`.
[](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13726 +/- ##
==========================================
- Coverage 78.87% 78.56% -0.31%
==========================================
Files 936 936
Lines 47408 47459 +51
Branches 5941 5965 +24
==========================================
- Hits 37393 37287 -106
- Misses 9883 10031 +148
- Partials 132 141 +9
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `51.81% <85.71%> (-7.29%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tend/src/filters/components/Select/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvY29udHJvbFBhbmVsLnRz) | `16.66% <0.00%> (-3.34%)` | :arrow_down: |
| [...nd/src/filters/components/Select/transformProps.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHJhbnNmb3JtUHJvcHMudHM=) | `50.00% <12.50%> (-31.82%)` | :arrow_down: |
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `55.55% <55.17%> (-25.40%)` | :arrow_down: |
| [...tersConfigModal/FiltersConfigForm/DefaultValue.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0RlZmF1bHRWYWx1ZS50c3g=) | `96.29% <100.00%> (-3.71%)` | :arrow_down: |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `66.66% <100.00%> (-33.34%)` | :arrow_down: |
| [...ontend/src/dashboard/util/serializeFilterScopes.js](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3NlcmlhbGl6ZUZpbHRlclNjb3Blcy5qcw==) | `40.00% <0.00%> (-60.00%)` | :arrow_down: |
| [...et-frontend/src/dashboard/components/SaveModal.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NhdmVNb2RhbC50c3g=) | `47.16% <0.00%> (-33.97%)` | :arrow_down: |
| [...hboard/components/resizable/ResizableContainer.jsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVDb250YWluZXIuanN4) | `71.87% <0.00%> (-28.13%)` | :arrow_down: |
| [...ntrols/MetricControl/AdhocMetricPopoverTrigger.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljUG9wb3ZlclRyaWdnZXIudHN4) | `70.00% <0.00%> (-25.00%)` | :arrow_down: |
| [...rontend/src/dashboard/components/DashboardGrid.jsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Rhc2hib2FyZEdyaWQuanN4) | `66.66% <0.00%> (-22.81%)` | :arrow_down: |
| ... and [51 more](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=footer). Last update [56dc74e...de733f3](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] simcha90 commented on a change in pull request #13726: feat(native-filters): Add default first value to select filter
Posted by GitBox <gi...@apache.org>.
simcha90 commented on a change in pull request #13726:
URL: https://github.com/apache/superset/pull/13726#discussion_r607870924
##########
File path: superset-frontend/src/filters/components/Select/SelectFilterPlugin.tsx
##########
@@ -115,18 +140,27 @@ export default function PluginFilterSelect(props: PluginFilterSelectProps) {
};
useEffect(() => {
- handleChange(currentValue ?? []);
+ // For currentValue we need set always `FIRST_VALUE` only if we in config modal for `defaultToFirstItem` mode
+ handleChange(
+ isDefaultToFirstItemInFilterConfigModal
+ ? FIRST_VALUE
+ : currentValue ?? [],
+ );
}, [
JSON.stringify(currentValue),
+ defaultToFirstItem,
Review comment:
I think no, because it's also relevant for a case when user had in filter bar not first value, and then in filter modal changed it to firstValue and clicked Save, so now it should be also updater in filter bar
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13726: feat(native-filters): Add default first value to select filter
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13726:
URL: https://github.com/apache/superset/pull/13726#issuecomment-804173881
# [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=h1) Report
> Merging [#13726](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=desc) (7a4b38c) into [master](https://codecov.io/gh/apache/superset/commit/56dc74e09f1665c1030a8e6ccf66e27fb4f24e9b?el=desc) (56dc74e) will **decrease** coverage by `5.76%`.
> The diff coverage is `75.00%`.
> :exclamation: Current head 7a4b38c differs from pull request most recent head de733f3. Consider uploading reports for the commit de733f3 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13726 +/- ##
==========================================
- Coverage 78.87% 73.10% -5.77%
==========================================
Files 936 626 -310
Lines 47408 22229 -25179
Branches 5941 5797 -144
==========================================
- Hits 37393 16251 -21142
+ Misses 9883 5836 -4047
- Partials 132 142 +10
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.50% <85.71%> (-2.59%)` | :arrow_down: |
| hive | `?` | |
| javascript | `63.12% <0.00%> (-5.33%)` | :arrow_down: |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `?` | |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tend/src/filters/components/Select/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvY29udHJvbFBhbmVsLnRz) | `18.18% <0.00%> (-1.82%)` | :arrow_down: |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `100.00% <ø> (ø)` | |
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `80.43% <85.71%> (-0.52%)` | :arrow_down: |
| [...tend/src/dashboard/util/getFilterFieldNodesTree.js](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlckZpZWxkTm9kZXNUcmVlLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...end/src/dashboard/util/getKeyForFilterScopeTree.js](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEtleUZvckZpbHRlclNjb3BlVHJlZS5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...nd/src/dashboard/util/getFilterScopeParentNodes.js](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlUGFyZW50Tm9kZXMuanM=) | `0.00% <0.00%> (-91.67%)` | :arrow_down: |
| [...ponents/filterscope/renderFilterFieldTreeNodes.jsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL3JlbmRlckZpbHRlckZpZWxkVHJlZU5vZGVzLmpzeA==) | `0.00% <0.00%> (-90.00%)` | :arrow_down: |
| [...ponents/filterscope/renderFilterScopeTreeNodes.jsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL3JlbmRlckZpbHRlclNjb3BlVHJlZU5vZGVzLmpzeA==) | `0.00% <0.00%> (-86.67%)` | :arrow_down: |
| [...ard/components/filterscope/FilterScopeSelector.jsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlclNjb3BlU2VsZWN0b3IuanN4) | `2.05% <0.00%> (-85.62%)` | :arrow_down: |
| [...board/util/getSelectedChartIdForFilterScopeTree.js](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldFNlbGVjdGVkQ2hhcnRJZEZvckZpbHRlclNjb3BlVHJlZS5qcw==) | `0.00% <0.00%> (-80.00%)` | :arrow_down: |
| ... and [523 more](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=footer). Last update [56dc74e...de733f3](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] simcha90 closed pull request #13726: feat(native-filters): Add default first value to select filter
Posted by GitBox <gi...@apache.org>.
simcha90 closed pull request #13726:
URL: https://github.com/apache/superset/pull/13726
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13726: feat(native-filters): Add default first value to select filter
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13726:
URL: https://github.com/apache/superset/pull/13726#issuecomment-804173881
# [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=h1) Report
> Merging [#13726](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=desc) (60ff6e1) into [master](https://codecov.io/gh/apache/superset/commit/b427a80a4f7e760e9fa8e9937a53995e1d076b6e?el=desc) (b427a80) will **increase** coverage by `0.32%`.
> The diff coverage is `72.58%`.
> :exclamation: Current head 60ff6e1 differs from pull request most recent head 1c2f278. Consider uploading reports for the commit 1c2f278 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13726 +/- ##
==========================================
+ Coverage 78.71% 79.03% +0.32%
==========================================
Files 936 936
Lines 47408 47452 +44
Branches 5938 5966 +28
==========================================
+ Hits 37315 37506 +191
+ Misses 9949 9819 -130
+ Partials 144 127 -17
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| javascript | `68.81% <4.16%> (-0.04%)` | :arrow_down: |
| mysql | `80.78% <95.23%> (+0.21%)` | :arrow_up: |
| postgres | `?` | |
| python | `80.82% <95.23%> (-0.18%)` | :arrow_down: |
| sqlite | `80.38% <95.23%> (+0.21%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tend/src/filters/components/Select/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvY29udHJvbFBhbmVsLnRz) | `16.66% <0.00%> (-3.34%)` | :arrow_down: |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `33.33% <0.00%> (-66.67%)` | :arrow_down: |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <ø> (ø)` | |
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `45.94% <56.66%> (-35.01%)` | :arrow_down: |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `92.82% <66.66%> (-0.41%)` | :arrow_down: |
| [...nd/src/filters/components/Select/transformProps.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHJhbnNmb3JtUHJvcHMudHM=) | `50.00% <87.50%> (-31.82%)` | :arrow_down: |
| [...tersConfigModal/FiltersConfigForm/DefaultValue.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0RlZmF1bHRWYWx1ZS50c3g=) | `96.29% <100.00%> (-3.71%)` | :arrow_down: |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.84% <100.00%> (+0.09%)` | :arrow_up: |
| [superset/reports/commands/alert.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9hbGVydC5weQ==) | `96.42% <100.00%> (+0.22%)` | :arrow_up: |
| [superset/reports/dao.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9kYW8ucHk=) | `82.50% <100.00%> (+2.32%)` | :arrow_up: |
| ... and [57 more](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=footer). Last update [b427a80...1c2f278](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13726: feat(native-filters): Add default first value to select filter
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13726:
URL: https://github.com/apache/superset/pull/13726#issuecomment-804173881
# [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=h1) Report
> Merging [#13726](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=desc) (95baf89) into [master](https://codecov.io/gh/apache/superset/commit/b427a80a4f7e760e9fa8e9937a53995e1d076b6e?el=desc) (b427a80) will **decrease** coverage by `0.06%`.
> The diff coverage is `60.97%`.
[](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13726 +/- ##
==========================================
- Coverage 78.71% 78.64% -0.07%
==========================================
Files 936 936
Lines 47408 47460 +52
Branches 5938 5966 +28
==========================================
+ Hits 37315 37323 +8
- Misses 9949 9992 +43
- Partials 144 145 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `68.81% <4.16%> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tend/src/filters/components/Select/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvY29udHJvbFBhbmVsLnRz) | `16.66% <0.00%> (-3.34%)` | :arrow_down: |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `33.33% <0.00%> (-66.67%)` | :arrow_down: |
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `45.94% <56.66%> (-35.01%)` | :arrow_down: |
| [...nd/src/filters/components/Select/transformProps.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHJhbnNmb3JtUHJvcHMudHM=) | `50.00% <87.50%> (-31.82%)` | :arrow_down: |
| [...tersConfigModal/FiltersConfigForm/DefaultValue.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0RlZmF1bHRWYWx1ZS50c3g=) | `96.29% <100.00%> (-3.71%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=footer). Last update [b427a80...95baf89](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #13726: feat(native-filters): Add default first value to select filter
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #13726:
URL: https://github.com/apache/superset/pull/13726#issuecomment-804173881
# [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=h1) Report
> Merging [#13726](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=desc) (7a4b38c) into [master](https://codecov.io/gh/apache/superset/commit/daefebb49deb255dad8514d62b6887ca1a00a723?el=desc) (daefebb) will **decrease** coverage by `4.28%`.
> The diff coverage is `75.00%`.
> :exclamation: Current head 7a4b38c differs from pull request most recent head b070c1c. Consider uploading reports for the commit b070c1c to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13726 +/- ##
==========================================
- Coverage 77.39% 73.10% -4.29%
==========================================
Files 928 626 -302
Lines 47024 22229 -24795
Branches 5812 5797 -15
==========================================
- Hits 36393 16251 -20142
+ Misses 10488 5836 -4652
+ Partials 143 142 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.50% <85.71%> (+0.06%)` | :arrow_up: |
| hive | `?` | |
| javascript | `63.12% <0.00%> (-0.02%)` | :arrow_down: |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `?` | |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tend/src/filters/components/Select/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvY29udHJvbFBhbmVsLnRz) | `18.18% <0.00%> (-1.82%)` | :arrow_down: |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `100.00% <ø> (ø)` | |
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `80.43% <85.71%> (-0.52%)` | :arrow_down: |
| [...tend/src/dashboard/containers/DashboardBuilder.jsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZEJ1aWxkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ponents/nativeFilters/FilterBar/CascadePopover.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nhc2NhZGVQb3BvdmVyLnRzeA==) | `63.38% <0.00%> (-19.72%)` | :arrow_down: |
| [...components/nativeFilters/FilterBar/FilterValue.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclZhbHVlLnRzeA==) | `69.09% <0.00%> (-16.37%)` | :arrow_down: |
| [...d/components/nativeFilters/FilterBar/FilterBar.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckJhci50c3g=) | `81.25% <0.00%> (-11.18%)` | :arrow_down: |
| [...tend/src/dashboard/components/DashboardBuilder.jsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Rhc2hib2FyZEJ1aWxkZXIuanN4) | `76.54% <0.00%> (-9.88%)` | :arrow_down: |
| [...nd/src/dashboard/containers/DashboardComponent.jsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZENvbXBvbmVudC5qc3g=) | `95.65% <0.00%> (-4.35%)` | :arrow_down: |
| [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `90.90% <0.00%> (ø)` | |
| ... and [327 more](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=footer). Last update [daefebb...b070c1c](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13726: feat(native-filters): Add default first value to select filter
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13726:
URL: https://github.com/apache/superset/pull/13726#issuecomment-804173881
# [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=h1) Report
> Merging [#13726](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=desc) (60ff6e1) into [master](https://codecov.io/gh/apache/superset/commit/b427a80a4f7e760e9fa8e9937a53995e1d076b6e?el=desc) (b427a80) will **increase** coverage by `0.25%`.
> The diff coverage is `86.66%`.
> :exclamation: Current head 60ff6e1 differs from pull request most recent head 1c2f278. Consider uploading reports for the commit 1c2f278 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13726 +/- ##
==========================================
+ Coverage 78.71% 78.96% +0.25%
==========================================
Files 936 936
Lines 47408 47411 +3
Branches 5938 5949 +11
==========================================
+ Hits 37315 37436 +121
+ Misses 9949 9846 -103
+ Partials 144 129 -15
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `55.26% <85.71%> (+3.59%)` | :arrow_up: |
| hive | `?` | |
| javascript | `68.81% <4.16%> (-0.04%)` | :arrow_down: |
| mysql | `80.78% <95.23%> (+0.21%)` | :arrow_up: |
| postgres | `?` | |
| python | `80.82% <95.23%> (-0.18%)` | :arrow_down: |
| sqlite | `80.38% <95.23%> (+0.21%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tend/src/filters/components/Select/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvY29udHJvbFBhbmVsLnRz) | `18.18% <0.00%> (-1.82%)` | :arrow_down: |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <ø> (ø)` | |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `92.82% <66.66%> (-0.41%)` | :arrow_down: |
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `78.43% <80.00%> (-2.53%)` | :arrow_down: |
| [...tersConfigModal/FiltersConfigForm/DefaultValue.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0RlZmF1bHRWYWx1ZS50c3g=) | `100.00% <100.00%> (ø)` | |
| [...nd/src/filters/components/Select/transformProps.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHJhbnNmb3JtUHJvcHMudHM=) | `81.81% <100.00%> (ø)` | |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `100.00% <100.00%> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.84% <100.00%> (+0.09%)` | :arrow_up: |
| [superset/reports/commands/alert.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9hbGVydC5weQ==) | `96.42% <100.00%> (+0.22%)` | :arrow_up: |
| [superset/reports/dao.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9kYW8ucHk=) | `82.50% <100.00%> (+2.32%)` | :arrow_up: |
| ... and [62 more](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=footer). Last update [b427a80...1c2f278](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13726: feat(native-filters): Add default first value to select filter
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13726:
URL: https://github.com/apache/superset/pull/13726#issuecomment-804173881
# [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=h1) Report
> Merging [#13726](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=desc) (be2a1b6) into [master](https://codecov.io/gh/apache/superset/commit/b427a80a4f7e760e9fa8e9937a53995e1d076b6e?el=desc) (b427a80) will **decrease** coverage by `0.48%`.
> The diff coverage is `8.33%`.
> :exclamation: Current head be2a1b6 differs from pull request most recent head 1c2f278. Consider uploading reports for the commit 1c2f278 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13726 +/- ##
==========================================
- Coverage 78.71% 78.22% -0.49%
==========================================
Files 936 936
Lines 47408 47419 +11
Branches 5938 5949 +11
==========================================
- Hits 37315 37093 -222
- Misses 9949 10187 +238
+ Partials 144 139 -5
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `49.86% <50.00%> (-1.81%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [...tend/src/filters/components/Select/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvY29udHJvbFBhbmVsLnRz) | `18.18% <0.00%> (-1.82%)` | :arrow_down: |
| [...nd/src/filters/components/Select/transformProps.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHJhbnNmb3JtUHJvcHMudHM=) | `0.00% <0.00%> (-81.82%)` | :arrow_down: |
| [...tersConfigModal/FiltersConfigForm/DefaultValue.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0RlZmF1bHRWYWx1ZS50c3g=) | `88.88% <100.00%> (-11.12%)` | :arrow_down: |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `100.00% <100.00%> (ø)` | |
| [...tend/src/visualizations/FilterBox/controlPanel.jsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9jb250cm9sUGFuZWwuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ponents/Select/WindowedSelect/WindowedMenuList.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1dpbmRvd2VkU2VsZWN0L1dpbmRvd2VkTWVudUxpc3QudHN4) | `10.71% <0.00%> (-85.72%)` | :arrow_down: |
| [...ontend/src/filters/components/Select/buildQuery.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvYnVpbGRRdWVyeS50cw==) | `0.00% <0.00%> (-77.78%)` | :arrow_down: |
| [superset-frontend/src/filters/components/common.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9jb21tb24udHM=) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
| [...ontend/src/dashboard/util/serializeFilterScopes.js](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3NlcmlhbGl6ZUZpbHRlclNjb3Blcy5qcw==) | `40.00% <0.00%> (-60.00%)` | :arrow_down: |
| ... and [82 more](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=footer). Last update [b427a80...1c2f278](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13726: feat(native-filters): Add default first value to select filter
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13726:
URL: https://github.com/apache/superset/pull/13726#issuecomment-804173881
# [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=h1) Report
> Merging [#13726](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=desc) (60ff6e1) into [master](https://codecov.io/gh/apache/superset/commit/b427a80a4f7e760e9fa8e9937a53995e1d076b6e?el=desc) (b427a80) will **increase** coverage by `0.16%`.
> The diff coverage is `90.19%`.
> :exclamation: Current head 60ff6e1 differs from pull request most recent head 1c2f278. Consider uploading reports for the commit 1c2f278 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13726 +/- ##
==========================================
+ Coverage 78.71% 78.87% +0.16%
==========================================
Files 936 936
Lines 47408 47400 -8
Branches 5938 5938
==========================================
+ Hits 37315 37387 +72
+ Misses 9949 9887 -62
+ Partials 144 126 -18
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| python | `80.38% <95.23%> (-0.62%)` | :arrow_down: |
| sqlite | `80.38% <95.23%> (+0.21%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tend/src/filters/components/Select/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvY29udHJvbFBhbmVsLnRz) | `20.00% <0.00%> (ø)` | |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `100.00% <ø> (ø)` | |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <ø> (ø)` | |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `92.82% <66.66%> (-0.41%)` | :arrow_down: |
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `80.95% <85.00%> (ø)` | |
| [...tersConfigModal/FiltersConfigForm/DefaultValue.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0RlZmF1bHRWYWx1ZS50c3g=) | `100.00% <100.00%> (ø)` | |
| [...nd/src/filters/components/Select/transformProps.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHJhbnNmb3JtUHJvcHMudHM=) | `81.81% <100.00%> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.84% <100.00%> (+0.09%)` | :arrow_up: |
| [superset/reports/commands/alert.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9hbGVydC5weQ==) | `96.42% <100.00%> (+0.22%)` | :arrow_up: |
| [superset/reports/dao.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9kYW8ucHk=) | `82.50% <100.00%> (+2.32%)` | :arrow_up: |
| ... and [70 more](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=footer). Last update [b427a80...1c2f278](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13726: feat(native-filters): Add default first value to select filter
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13726:
URL: https://github.com/apache/superset/pull/13726#issuecomment-804173881
# [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=h1) Report
> Merging [#13726](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=desc) (60ff6e1) into [master](https://codecov.io/gh/apache/superset/commit/b427a80a4f7e760e9fa8e9937a53995e1d076b6e?el=desc) (b427a80) will **increase** coverage by `0.54%`.
> The diff coverage is `86.66%`.
> :exclamation: Current head 60ff6e1 differs from pull request most recent head 1c2f278. Consider uploading reports for the commit 1c2f278 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13726 +/- ##
==========================================
+ Coverage 78.71% 79.25% +0.54%
==========================================
Files 936 936
Lines 47408 47438 +30
Branches 5938 5949 +11
==========================================
+ Hits 37315 37596 +281
+ Misses 9949 9713 -236
+ Partials 144 129 -15
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `55.26% <85.71%> (+3.59%)` | :arrow_up: |
| hive | `80.49% <95.23%> (+0.21%)` | :arrow_up: |
| javascript | `68.81% <4.16%> (-0.04%)` | :arrow_down: |
| mysql | `80.78% <95.23%> (+0.21%)` | :arrow_up: |
| postgres | `80.82% <95.23%> (+0.21%)` | :arrow_up: |
| presto | `80.51% <95.23%> (?)` | |
| python | `81.37% <95.23%> (+0.37%)` | :arrow_up: |
| sqlite | `80.38% <95.23%> (+0.21%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tend/src/filters/components/Select/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvY29udHJvbFBhbmVsLnRz) | `18.18% <0.00%> (-1.82%)` | :arrow_down: |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <ø> (ø)` | |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `92.82% <66.66%> (-0.41%)` | :arrow_down: |
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `78.43% <80.00%> (-2.53%)` | :arrow_down: |
| [...tersConfigModal/FiltersConfigForm/DefaultValue.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0RlZmF1bHRWYWx1ZS50c3g=) | `100.00% <100.00%> (ø)` | |
| [...nd/src/filters/components/Select/transformProps.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHJhbnNmb3JtUHJvcHMudHM=) | `81.81% <100.00%> (ø)` | |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `100.00% <100.00%> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.84% <100.00%> (+0.09%)` | :arrow_up: |
| [superset/reports/commands/alert.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9hbGVydC5weQ==) | `96.42% <100.00%> (+0.22%)` | :arrow_up: |
| [superset/reports/dao.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9kYW8ucHk=) | `82.50% <100.00%> (+2.32%)` | :arrow_up: |
| ... and [48 more](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=footer). Last update [b427a80...1c2f278](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13726: feat(native-filters): Add default first value to select filter
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13726:
URL: https://github.com/apache/superset/pull/13726#issuecomment-804173881
# [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=h1) Report
> Merging [#13726](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=desc) (7a4b38c) into [master](https://codecov.io/gh/apache/superset/commit/abd4051f7a94b7e1a653ae6c0590645b0fe1dd33?el=desc) (abd4051) will **decrease** coverage by `4.93%`.
> The diff coverage is `75.00%`.
> :exclamation: Current head 7a4b38c differs from pull request most recent head 37b3f0e. Consider uploading reports for the commit 37b3f0e to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13726 +/- ##
==========================================
- Coverage 78.03% 73.10% -4.94%
==========================================
Files 934 626 -308
Lines 47349 22229 -25120
Branches 5943 5797 -146
==========================================
- Hits 36950 16251 -20699
+ Misses 10254 5836 -4418
+ Partials 145 142 -3
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.50% <85.71%> (+2.82%)` | :arrow_up: |
| hive | `?` | |
| javascript | `63.12% <0.00%> (-3.21%)` | :arrow_down: |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `?` | |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tend/src/filters/components/Select/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvY29udHJvbFBhbmVsLnRz) | `18.18% <0.00%> (-1.82%)` | :arrow_down: |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `100.00% <ø> (ø)` | |
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `80.43% <85.71%> (-0.52%)` | :arrow_down: |
| [...controls/DndColumnSelectControl/DndSelectLabel.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZFNlbGVjdExhYmVsLnRzeA==) | `35.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...trols/DateFilterControl/components/CustomFrame.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0N1c3RvbUZyYW1lLnRzeA==) | `42.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...ols/DateFilterControl/components/AdvancedFrame.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0FkdmFuY2VkRnJhbWUudHN4) | `53.84% <0.00%> (-46.16%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLnRz) | `46.66% <0.00%> (-40.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `63.63% <0.00%> (-36.37%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `63.63% <0.00%> (-36.37%)` | :arrow_down: |
| [...ontrols/DndColumnSelectControl/DndFilterSelect.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZEZpbHRlclNlbGVjdC50c3g=) | `9.23% <0.00%> (-36.16%)` | :arrow_down: |
| ... and [453 more](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=footer). Last update [abd4051...37b3f0e](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13726: feat(native-filters): Add default first value to select filter
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13726:
URL: https://github.com/apache/superset/pull/13726#issuecomment-804173881
# [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=h1) Report
> Merging [#13726](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=desc) (8ccb6f0) into [master](https://codecov.io/gh/apache/superset/commit/a4fd6b8f33e9e780084a71f3e5b579468cdd635b?el=desc) (a4fd6b8) will **decrease** coverage by `0.51%`.
> The diff coverage is `86.20%`.
> :exclamation: Current head 8ccb6f0 differs from pull request most recent head 5f37308. Consider uploading reports for the commit 5f37308 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13726 +/- ##
==========================================
- Coverage 79.30% 78.78% -0.52%
==========================================
Files 939 939
Lines 47541 47514 -27
Branches 5938 5938
==========================================
- Hits 37703 37435 -268
- Misses 9717 9958 +241
Partials 121 121
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `80.34% <ø> (-0.97%)` | :arrow_down: |
| sqlite | `80.34% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tend/src/filters/components/Select/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvY29udHJvbFBhbmVsLnRz) | `20.00% <0.00%> (ø)` | |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `100.00% <ø> (ø)` | |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <ø> (ø)` | |
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `80.48% <84.21%> (ø)` | |
| [...tersConfigModal/FiltersConfigForm/DefaultValue.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0RlZmF1bHRWYWx1ZS50c3g=) | `100.00% <100.00%> (ø)` | |
| [...nd/src/filters/components/Select/transformProps.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHJhbnNmb3JtUHJvcHMudHM=) | `81.81% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `31.37% <0.00%> (-60.79%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/models/sql\_types/base.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF90eXBlcy9iYXNlLnB5) | `52.63% <0.00%> (-31.58%)` | :arrow_down: |
| ... and [30 more](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=footer). Last update [a4fd6b8...5f37308](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13726: feat(native-filters): Add default first value to select filter
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13726:
URL: https://github.com/apache/superset/pull/13726#issuecomment-804173881
# [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=h1) Report
> Merging [#13726](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=desc) (57ff3b1) into [master](https://codecov.io/gh/apache/superset/commit/a4fd6b8f33e9e780084a71f3e5b579468cdd635b?el=desc) (a4fd6b8) will **decrease** coverage by `0.53%`.
> The diff coverage is `79.16%`.
> :exclamation: Current head 57ff3b1 differs from pull request most recent head 5f37308. Consider uploading reports for the commit 5f37308 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13726 +/- ##
==========================================
- Coverage 79.30% 78.77% -0.54%
==========================================
Files 939 939
Lines 47541 47551 +10
Branches 5938 5947 +9
==========================================
- Hits 37703 37457 -246
- Misses 9717 9960 +243
- Partials 121 134 +13
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.75% <85.71%> (+2.51%)` | :arrow_up: |
| hive | `?` | |
| javascript | `69.37% <4.16%> (-0.04%)` | :arrow_down: |
| mysql | `80.71% <ø> (ø)` | |
| postgres | `80.74% <ø> (+<0.01%)` | :arrow_up: |
| presto | `?` | |
| python | `80.82% <ø> (-0.49%)` | :arrow_down: |
| sqlite | `80.34% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tend/src/filters/components/Select/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvY29udHJvbFBhbmVsLnRz) | `18.18% <0.00%> (-1.82%)` | :arrow_down: |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <ø> (ø)` | |
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `78.00% <80.00%> (-2.49%)` | :arrow_down: |
| [...tersConfigModal/FiltersConfigForm/DefaultValue.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0RlZmF1bHRWYWx1ZS50c3g=) | `100.00% <100.00%> (ø)` | |
| [...nd/src/filters/components/Select/transformProps.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHJhbnNmb3JtUHJvcHMudHM=) | `81.81% <100.00%> (ø)` | |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...tend/src/visualizations/FilterBox/controlPanel.jsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9jb250cm9sUGFuZWwuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [...trols/DateFilterControl/components/CommonFrame.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0NvbW1vbkZyYW1lLnRzeA==) | `41.66% <0.00%> (-41.67%)` | :arrow_down: |
| ... and [50 more](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=footer). Last update [a4fd6b8...5f37308](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13726: feat(native-filters): Add default first value to select filter
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13726:
URL: https://github.com/apache/superset/pull/13726#issuecomment-804173881
# [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=h1) Report
> Merging [#13726](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=desc) (60ff6e1) into [master](https://codecov.io/gh/apache/superset/commit/b427a80a4f7e760e9fa8e9937a53995e1d076b6e?el=desc) (b427a80) will **increase** coverage by `0.57%`.
> The diff coverage is `86.66%`.
> :exclamation: Current head 60ff6e1 differs from pull request most recent head 1c2f278. Consider uploading reports for the commit 1c2f278 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13726 +/- ##
==========================================
+ Coverage 78.71% 79.28% +0.57%
==========================================
Files 936 936
Lines 47408 47489 +81
Branches 5938 5966 +28
==========================================
+ Hits 37315 37652 +337
+ Misses 9949 9710 -239
+ Partials 144 127 -17
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `55.72% <85.71%> (+4.05%)` | :arrow_up: |
| hive | `80.49% <95.23%> (+0.21%)` | :arrow_up: |
| javascript | `68.81% <4.16%> (-0.04%)` | :arrow_down: |
| mysql | `80.78% <95.23%> (+0.21%)` | :arrow_up: |
| postgres | `80.82% <95.23%> (+0.21%)` | :arrow_up: |
| presto | `80.51% <95.23%> (?)` | |
| python | `81.37% <95.23%> (+0.37%)` | :arrow_up: |
| sqlite | `80.38% <95.23%> (+0.21%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tend/src/filters/components/Select/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvY29udHJvbFBhbmVsLnRz) | `18.18% <0.00%> (-1.82%)` | :arrow_down: |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <ø> (ø)` | |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `92.82% <66.66%> (-0.41%)` | :arrow_down: |
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `78.43% <80.00%> (-2.53%)` | :arrow_down: |
| [...tersConfigModal/FiltersConfigForm/DefaultValue.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0RlZmF1bHRWYWx1ZS50c3g=) | `100.00% <100.00%> (ø)` | |
| [...nd/src/filters/components/Select/transformProps.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHJhbnNmb3JtUHJvcHMudHM=) | `81.81% <100.00%> (ø)` | |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `100.00% <100.00%> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.84% <100.00%> (+0.09%)` | :arrow_up: |
| [superset/reports/commands/alert.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9hbGVydC5weQ==) | `96.42% <100.00%> (+0.22%)` | :arrow_up: |
| [superset/reports/dao.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9kYW8ucHk=) | `82.50% <100.00%> (+2.32%)` | :arrow_up: |
| ... and [43 more](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=footer). Last update [b427a80...1c2f278](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13726: feat(native-filters): Add default first value to select filter
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13726:
URL: https://github.com/apache/superset/pull/13726#issuecomment-804173881
# [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=h1) Report
> Merging [#13726](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=desc) (60ff6e1) into [master](https://codecov.io/gh/apache/superset/commit/b427a80a4f7e760e9fa8e9937a53995e1d076b6e?el=desc) (b427a80) will **increase** coverage by `0.54%`.
> The diff coverage is `86.66%`.
> :exclamation: Current head 60ff6e1 differs from pull request most recent head 1c2f278. Consider uploading reports for the commit 1c2f278 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13726 +/- ##
==========================================
+ Coverage 78.71% 79.25% +0.54%
==========================================
Files 936 936
Lines 47408 47438 +30
Branches 5938 5949 +11
==========================================
+ Hits 37315 37596 +281
+ Misses 9949 9713 -236
+ Partials 144 129 -15
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `55.26% <85.71%> (+3.59%)` | :arrow_up: |
| hive | `80.49% <95.23%> (+0.21%)` | :arrow_up: |
| javascript | `68.81% <4.16%> (-0.04%)` | :arrow_down: |
| mysql | `80.78% <95.23%> (+0.21%)` | :arrow_up: |
| postgres | `80.80% <95.23%> (+0.19%)` | :arrow_up: |
| presto | `80.51% <95.23%> (?)` | |
| python | `81.37% <95.23%> (+0.37%)` | :arrow_up: |
| sqlite | `80.38% <95.23%> (+0.21%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tend/src/filters/components/Select/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvY29udHJvbFBhbmVsLnRz) | `18.18% <0.00%> (-1.82%)` | :arrow_down: |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <ø> (ø)` | |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `92.82% <66.66%> (-0.41%)` | :arrow_down: |
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `78.43% <80.00%> (-2.53%)` | :arrow_down: |
| [...tersConfigModal/FiltersConfigForm/DefaultValue.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0RlZmF1bHRWYWx1ZS50c3g=) | `100.00% <100.00%> (ø)` | |
| [...nd/src/filters/components/Select/transformProps.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHJhbnNmb3JtUHJvcHMudHM=) | `81.81% <100.00%> (ø)` | |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `100.00% <100.00%> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.84% <100.00%> (+0.09%)` | :arrow_up: |
| [superset/reports/commands/alert.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9hbGVydC5weQ==) | `96.42% <100.00%> (+0.22%)` | :arrow_up: |
| [superset/reports/dao.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9kYW8ucHk=) | `82.50% <100.00%> (+2.32%)` | :arrow_up: |
| ... and [48 more](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=footer). Last update [b427a80...1c2f278](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13726: feat(native-filters): Add default first value to select filter
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13726:
URL: https://github.com/apache/superset/pull/13726#issuecomment-804173881
# [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=h1) Report
> Merging [#13726](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=desc) (9db8487) into [master](https://codecov.io/gh/apache/superset/commit/a4fd6b8f33e9e780084a71f3e5b579468cdd635b?el=desc) (a4fd6b8) will **decrease** coverage by `0.02%`.
> The diff coverage is `79.16%`.
> :exclamation: Current head 9db8487 differs from pull request most recent head 4919889. Consider uploading reports for the commit 4919889 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13726 +/- ##
==========================================
- Coverage 79.30% 79.28% -0.03%
==========================================
Files 939 939
Lines 47541 47552 +11
Branches 5938 5949 +11
==========================================
- Hits 37703 37701 -2
- Misses 9717 9730 +13
Partials 121 121
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.05% <85.71%> (+1.81%)` | :arrow_up: |
| hive | `?` | |
| javascript | `69.37% <4.16%> (-0.04%)` | :arrow_down: |
| presto | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tend/src/filters/components/Select/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvY29udHJvbFBhbmVsLnRz) | `18.18% <0.00%> (-1.82%)` | :arrow_down: |
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `78.00% <80.00%> (-2.49%)` | :arrow_down: |
| [...tersConfigModal/FiltersConfigForm/DefaultValue.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0RlZmF1bHRWYWx1ZS50c3g=) | `100.00% <100.00%> (ø)` | |
| [...nd/src/filters/components/Select/transformProps.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHJhbnNmb3JtUHJvcHMudHM=) | `81.81% <100.00%> (ø)` | |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.42% <0.00%> (-16.42%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.79% <0.00%> (-8.16%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.24% <0.00%> (-1.70%)` | :arrow_down: |
| ... and [20 more](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=footer). Last update [a4fd6b8...4919889](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13726: feat(native-filters): Add default first value to select filter
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13726:
URL: https://github.com/apache/superset/pull/13726#issuecomment-804173881
# [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=h1) Report
> Merging [#13726](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=desc) (57ff3b1) into [master](https://codecov.io/gh/apache/superset/commit/a4fd6b8f33e9e780084a71f3e5b579468cdd635b?el=desc) (a4fd6b8) will **decrease** coverage by `0.26%`.
> The diff coverage is `86.66%`.
> :exclamation: Current head 57ff3b1 differs from pull request most recent head 5f37308. Consider uploading reports for the commit 5f37308 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13726 +/- ##
==========================================
- Coverage 79.30% 79.04% -0.27%
==========================================
Files 939 939
Lines 47541 47541
Branches 5938 5938
==========================================
- Hits 37703 37579 -124
- Misses 9717 9841 +124
Partials 121 121
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `80.71% <ø> (ø)` | |
| postgres | `80.74% <ø> (+<0.01%)` | :arrow_up: |
| presto | `?` | |
| python | `80.82% <ø> (-0.49%)` | :arrow_down: |
| sqlite | `80.34% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tend/src/filters/components/Select/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvY29udHJvbFBhbmVsLnRz) | `20.00% <0.00%> (ø)` | |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `100.00% <ø> (ø)` | |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <ø> (ø)` | |
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `80.48% <85.00%> (ø)` | |
| [...tersConfigModal/FiltersConfigForm/DefaultValue.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0RlZmF1bHRWYWx1ZS50c3g=) | `100.00% <100.00%> (ø)` | |
| [...nd/src/filters/components/Select/transformProps.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHJhbnNmb3JtUHJvcHMudHM=) | `81.81% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.42% <0.00%> (-16.42%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.79% <0.00%> (-8.16%)` | :arrow_down: |
| ... and [7 more](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=footer). Last update [a4fd6b8...5f37308](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13726: feat(native-filters): Add default first value to select filter
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13726:
URL: https://github.com/apache/superset/pull/13726#issuecomment-804173881
# [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=h1) Report
> Merging [#13726](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=desc) (c9b96d5) into [master](https://codecov.io/gh/apache/superset/commit/b427a80a4f7e760e9fa8e9937a53995e1d076b6e?el=desc) (b427a80) will **decrease** coverage by `0.64%`.
> The diff coverage is `9.67%`.
> :exclamation: Current head c9b96d5 differs from pull request most recent head caed773. Consider uploading reports for the commit caed773 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13726 +/- ##
==========================================
- Coverage 78.54% 77.89% -0.65%
==========================================
Files 936 936
Lines 47408 47428 +20
Branches 5938 5949 +11
==========================================
- Hits 37238 36946 -292
- Misses 10026 10330 +304
- Partials 144 152 +8
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `47.15% <50.00%> (-4.53%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [...tend/src/filters/components/Select/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvY29udHJvbFBhbmVsLnRz) | `16.66% <0.00%> (-3.34%)` | :arrow_down: |
| [...nd/src/filters/components/Select/transformProps.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHJhbnNmb3JtUHJvcHMudHM=) | `0.00% <0.00%> (-81.82%)` | :arrow_down: |
| [...tersConfigModal/FiltersConfigForm/DefaultValue.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0RlZmF1bHRWYWx1ZS50c3g=) | `62.96% <100.00%> (-37.04%)` | :arrow_down: |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `66.66% <100.00%> (-33.34%)` | :arrow_down: |
| [...ponents/Select/WindowedSelect/WindowedMenuList.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1dpbmRvd2VkU2VsZWN0L1dpbmRvd2VkTWVudUxpc3QudHN4) | `10.71% <0.00%> (-85.72%)` | :arrow_down: |
| [...ontend/src/filters/components/Select/buildQuery.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvYnVpbGRRdWVyeS50cw==) | `0.00% <0.00%> (-77.78%)` | :arrow_down: |
| [superset-frontend/src/filters/components/common.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9jb21tb24udHM=) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
| [superset-frontend/src/dataMask/reducer.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFNYXNrL3JlZHVjZXIudHM=) | `44.00% <0.00%> (-56.00%)` | :arrow_down: |
| [...nd/src/dashboard/util/getFilterValuesByFilterId.js](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclZhbHVlc0J5RmlsdGVySWQuanM=) | `25.00% <0.00%> (-50.00%)` | :arrow_down: |
| ... and [119 more](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=footer). Last update [b427a80...caed773](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13726: feat(native-filters): Add default first value to select filter
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13726:
URL: https://github.com/apache/superset/pull/13726#issuecomment-804173881
# [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=h1) Report
> Merging [#13726](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=desc) (60ff6e1) into [master](https://codecov.io/gh/apache/superset/commit/b427a80a4f7e760e9fa8e9937a53995e1d076b6e?el=desc) (b427a80) will **increase** coverage by `0.43%`.
> The diff coverage is `86.66%`.
> :exclamation: Current head 60ff6e1 differs from pull request most recent head 1c2f278. Consider uploading reports for the commit 1c2f278 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13726 +/- ##
==========================================
+ Coverage 78.71% 79.14% +0.43%
==========================================
Files 936 936
Lines 47408 47438 +30
Branches 5938 5949 +11
==========================================
+ Hits 37315 37544 +229
+ Misses 9949 9765 -184
+ Partials 144 129 -15
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `55.26% <85.71%> (+3.59%)` | :arrow_up: |
| hive | `80.49% <95.23%> (+0.21%)` | :arrow_up: |
| javascript | `68.81% <4.16%> (-0.04%)` | :arrow_down: |
| mysql | `80.78% <95.23%> (+0.21%)` | :arrow_up: |
| postgres | `?` | |
| python | `81.16% <95.23%> (+0.16%)` | :arrow_up: |
| sqlite | `80.38% <95.23%> (+0.21%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tend/src/filters/components/Select/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvY29udHJvbFBhbmVsLnRz) | `18.18% <0.00%> (-1.82%)` | :arrow_down: |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <ø> (ø)` | |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `92.82% <66.66%> (-0.41%)` | :arrow_down: |
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `78.43% <80.00%> (-2.53%)` | :arrow_down: |
| [...tersConfigModal/FiltersConfigForm/DefaultValue.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0RlZmF1bHRWYWx1ZS50c3g=) | `100.00% <100.00%> (ø)` | |
| [...nd/src/filters/components/Select/transformProps.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHJhbnNmb3JtUHJvcHMudHM=) | `81.81% <100.00%> (ø)` | |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `100.00% <100.00%> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.84% <100.00%> (+0.09%)` | :arrow_up: |
| [superset/reports/commands/alert.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9hbGVydC5weQ==) | `96.42% <100.00%> (+0.22%)` | :arrow_up: |
| [superset/reports/dao.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9kYW8ucHk=) | `82.50% <100.00%> (+2.32%)` | :arrow_up: |
| ... and [48 more](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=footer). Last update [b427a80...1c2f278](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13726: feat(native-filters): Add default first value to select filter
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13726:
URL: https://github.com/apache/superset/pull/13726#issuecomment-804173881
# [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=h1) Report
> Merging [#13726](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=desc) (7a4b38c) into [master](https://codecov.io/gh/apache/superset/commit/abd4051f7a94b7e1a653ae6c0590645b0fe1dd33?el=desc) (abd4051) will **decrease** coverage by `4.93%`.
> The diff coverage is `75.00%`.
> :exclamation: Current head 7a4b38c differs from pull request most recent head ce4b2aa. Consider uploading reports for the commit ce4b2aa to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13726 +/- ##
==========================================
- Coverage 78.03% 73.10% -4.94%
==========================================
Files 934 626 -308
Lines 47349 22229 -25120
Branches 5943 5797 -146
==========================================
- Hits 36950 16251 -20699
+ Misses 10254 5836 -4418
+ Partials 145 142 -3
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.50% <85.71%> (+2.82%)` | :arrow_up: |
| hive | `?` | |
| javascript | `63.12% <0.00%> (-3.21%)` | :arrow_down: |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `?` | |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tend/src/filters/components/Select/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvY29udHJvbFBhbmVsLnRz) | `18.18% <0.00%> (-1.82%)` | :arrow_down: |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `100.00% <ø> (ø)` | |
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `80.43% <85.71%> (-0.52%)` | :arrow_down: |
| [...controls/DndColumnSelectControl/DndSelectLabel.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZFNlbGVjdExhYmVsLnRzeA==) | `35.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...trols/DateFilterControl/components/CustomFrame.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0N1c3RvbUZyYW1lLnRzeA==) | `42.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...ols/DateFilterControl/components/AdvancedFrame.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0FkdmFuY2VkRnJhbWUudHN4) | `53.84% <0.00%> (-46.16%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLnRz) | `46.66% <0.00%> (-40.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `63.63% <0.00%> (-36.37%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `63.63% <0.00%> (-36.37%)` | :arrow_down: |
| [...ontrols/DndColumnSelectControl/DndFilterSelect.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZEZpbHRlclNlbGVjdC50c3g=) | `9.23% <0.00%> (-36.16%)` | :arrow_down: |
| ... and [453 more](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=footer). Last update [abd4051...ce4b2aa](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #13726: feat(native-filters): Add default first value to select filter
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #13726:
URL: https://github.com/apache/superset/pull/13726#issuecomment-804382895
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13726: feat(native-filters): Add default first value to select filter
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13726:
URL: https://github.com/apache/superset/pull/13726#issuecomment-804173881
# [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=h1) Report
> Merging [#13726](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=desc) (9db8487) into [master](https://codecov.io/gh/apache/superset/commit/a4fd6b8f33e9e780084a71f3e5b579468cdd635b?el=desc) (a4fd6b8) will **decrease** coverage by `0.89%`.
> The diff coverage is `8.33%`.
[](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13726 +/- ##
==========================================
- Coverage 79.30% 78.41% -0.90%
==========================================
Files 939 939
Lines 47541 47551 +10
Branches 5938 5949 +11
==========================================
- Hits 37703 37287 -416
- Misses 9717 10126 +409
- Partials 121 138 +17
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `54.62% <50.00%> (+0.39%)` | :arrow_up: |
| hive | `?` | |
| javascript | `69.37% <4.16%> (-0.04%)` | :arrow_down: |
| presto | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `0.00% <0.00%> (-80.49%)` | :arrow_down: |
| [...tend/src/filters/components/Select/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvY29udHJvbFBhbmVsLnRz) | `18.18% <0.00%> (-1.82%)` | :arrow_down: |
| [...nd/src/filters/components/Select/transformProps.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHJhbnNmb3JtUHJvcHMudHM=) | `0.00% <0.00%> (-81.82%)` | :arrow_down: |
| [...tersConfigModal/FiltersConfigForm/DefaultValue.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0RlZmF1bHRWYWx1ZS50c3g=) | `88.88% <100.00%> (-11.12%)` | :arrow_down: |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...tend/src/visualizations/FilterBox/controlPanel.jsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9jb250cm9sUGFuZWwuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ponents/Select/WindowedSelect/WindowedMenuList.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1dpbmRvd2VkU2VsZWN0L1dpbmRvd2VkTWVudUxpc3QudHN4) | `10.71% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [...ontend/src/filters/components/Select/buildQuery.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvYnVpbGRRdWVyeS50cw==) | `0.00% <0.00%> (-77.78%)` | :arrow_down: |
| ... and [75 more](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=footer). Last update [a4fd6b8...9db8487](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13726: feat(native-filters): Add default first value to select filter
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13726:
URL: https://github.com/apache/superset/pull/13726#issuecomment-804173881
# [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=h1) Report
> Merging [#13726](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=desc) (7a4b38c) into [master](https://codecov.io/gh/apache/superset/commit/abd4051f7a94b7e1a653ae6c0590645b0fe1dd33?el=desc) (abd4051) will **decrease** coverage by `4.93%`.
> The diff coverage is `75.00%`.
> :exclamation: Current head 7a4b38c differs from pull request most recent head 4d4b371. Consider uploading reports for the commit 4d4b371 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13726 +/- ##
==========================================
- Coverage 78.03% 73.10% -4.94%
==========================================
Files 934 626 -308
Lines 47349 22229 -25120
Branches 5943 5797 -146
==========================================
- Hits 36950 16251 -20699
+ Misses 10254 5836 -4418
+ Partials 145 142 -3
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.50% <85.71%> (+2.82%)` | :arrow_up: |
| hive | `?` | |
| javascript | `63.12% <0.00%> (-3.21%)` | :arrow_down: |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `?` | |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tend/src/filters/components/Select/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvY29udHJvbFBhbmVsLnRz) | `18.18% <0.00%> (-1.82%)` | :arrow_down: |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `100.00% <ø> (ø)` | |
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `80.43% <85.71%> (-0.52%)` | :arrow_down: |
| [...controls/DndColumnSelectControl/DndSelectLabel.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZFNlbGVjdExhYmVsLnRzeA==) | `35.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...trols/DateFilterControl/components/CustomFrame.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0N1c3RvbUZyYW1lLnRzeA==) | `42.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...ols/DateFilterControl/components/AdvancedFrame.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0FkdmFuY2VkRnJhbWUudHN4) | `53.84% <0.00%> (-46.16%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLnRz) | `46.66% <0.00%> (-40.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `63.63% <0.00%> (-36.37%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `63.63% <0.00%> (-36.37%)` | :arrow_down: |
| [...ontrols/DndColumnSelectControl/DndFilterSelect.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZEZpbHRlclNlbGVjdC50c3g=) | `9.23% <0.00%> (-36.16%)` | :arrow_down: |
| ... and [453 more](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=footer). Last update [abd4051...4d4b371](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro merged pull request #13726: feat(native-filters): Add default first value to select filter
Posted by GitBox <gi...@apache.org>.
villebro merged pull request #13726:
URL: https://github.com/apache/superset/pull/13726
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13726: feat(native-filters): Add default first value to select filter
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13726:
URL: https://github.com/apache/superset/pull/13726#issuecomment-804173881
# [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=h1) Report
> Merging [#13726](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=desc) (80b6a01) into [master](https://codecov.io/gh/apache/superset/commit/b427a80a4f7e760e9fa8e9937a53995e1d076b6e?el=desc) (b427a80) will **decrease** coverage by `0.69%`.
> The diff coverage is `48.78%`.
> :exclamation: Current head 80b6a01 differs from pull request most recent head 95baf89. Consider uploading reports for the commit 95baf89 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13726 +/- ##
==========================================
- Coverage 78.71% 78.01% -0.70%
==========================================
Files 936 936
Lines 47408 47458 +50
Branches 5938 5962 +24
==========================================
- Hits 37315 37024 -291
- Misses 9949 10273 +324
- Partials 144 161 +17
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `46.99% <85.71%> (-4.68%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tend/src/filters/components/Select/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvY29udHJvbFBhbmVsLnRz) | `16.66% <0.00%> (-3.34%)` | :arrow_down: |
| [...nd/src/filters/components/Select/transformProps.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHJhbnNmb3JtUHJvcHMudHM=) | `50.00% <12.50%> (-31.82%)` | :arrow_down: |
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `55.55% <55.17%> (-25.40%)` | :arrow_down: |
| [...tersConfigModal/FiltersConfigForm/DefaultValue.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0RlZmF1bHRWYWx1ZS50c3g=) | `96.29% <100.00%> (-3.71%)` | :arrow_down: |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `66.66% <100.00%> (-33.34%)` | :arrow_down: |
| [...nd/src/dashboard/util/getFilterValuesByFilterId.js](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclZhbHVlc0J5RmlsdGVySWQuanM=) | `25.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...trols/DateFilterControl/components/CommonFrame.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0NvbW1vbkZyYW1lLnRzeA==) | `41.66% <0.00%> (-41.67%)` | :arrow_down: |
| [...ols/DateFilterControl/components/CalendarFrame.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0NhbGVuZGFyRnJhbWUudHN4) | `46.15% <0.00%> (-38.47%)` | :arrow_down: |
| [...nents/controls/MetricControl/AdhocMetricOption.jsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljT3B0aW9uLmpzeA==) | `72.72% <0.00%> (-27.28%)` | :arrow_down: |
| [...ntrols/MetricControl/AdhocMetricPopoverTrigger.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljUG9wb3ZlclRyaWdnZXIudHN4) | `70.00% <0.00%> (-25.00%)` | :arrow_down: |
| ... and [41 more](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=footer). Last update [b427a80...95baf89](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc removed a comment on pull request #13726: feat(native-filters): Add default first value to select filter
Posted by GitBox <gi...@apache.org>.
junlincc removed a comment on pull request #13726:
URL: https://github.com/apache/superset/pull/13726#issuecomment-804382895
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13726: feat(native-filters): Add default first value to select filter
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13726:
URL: https://github.com/apache/superset/pull/13726#issuecomment-804173881
# [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=h1) Report
> Merging [#13726](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=desc) (cc0dc6f) into [master](https://codecov.io/gh/apache/superset/commit/a4fd6b8f33e9e780084a71f3e5b579468cdd635b?el=desc) (a4fd6b8) will **decrease** coverage by `0.39%`.
> The diff coverage is `75.75%`.
> :exclamation: Current head cc0dc6f differs from pull request most recent head 4919889. Consider uploading reports for the commit 4919889 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13726 +/- ##
==========================================
- Coverage 79.30% 78.91% -0.40%
==========================================
Files 939 939
Lines 47541 47561 +20
Branches 5938 5949 +11
==========================================
- Hits 37703 37531 -172
- Misses 9717 9890 +173
- Partials 121 140 +19
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `51.72% <82.60%> (-2.52%)` | :arrow_down: |
| javascript | `69.36% <3.84%> (-0.05%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tend/src/filters/components/Select/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvY29udHJvbFBhbmVsLnRz) | `18.18% <0.00%> (-1.82%)` | :arrow_down: |
| [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `76.47% <50.00%> (-0.40%)` | :arrow_down: |
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `76.92% <77.27%> (-3.57%)` | :arrow_down: |
| [...tersConfigModal/FiltersConfigForm/DefaultValue.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0RlZmF1bHRWYWx1ZS50c3g=) | `100.00% <100.00%> (ø)` | |
| [...nd/src/filters/components/Select/transformProps.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHJhbnNmb3JtUHJvcHMudHM=) | `81.81% <100.00%> (ø)` | |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `100.00% <100.00%> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.68% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/utils/async\_query\_manager.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvYXN5bmNfcXVlcnlfbWFuYWdlci5weQ==) | `81.37% <100.00%> (+0.37%)` | :arrow_up: |
| [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...c/dashboard/components/dnd/AddSliceDragPreview.jsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9BZGRTbGljZURyYWdQcmV2aWV3LmpzeA==) | `35.71% <0.00%> (-64.29%)` | :arrow_down: |
| ... and [48 more](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=footer). Last update [a4fd6b8...4919889](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on a change in pull request #13726: feat(native-filters): Add default first value to select filter
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #13726:
URL: https://github.com/apache/superset/pull/13726#discussion_r611145614
##########
File path: superset-frontend/src/filters/components/Select/SelectFilterPlugin.tsx
##########
@@ -51,39 +53,62 @@ export default function PluginFilterSelect(props: PluginFilterSelectProps) {
currentValue,
inverseSelection,
inputRef,
+ defaultToFirstItem,
} = formData;
- const [values, setValues] = useState<(string | number | boolean)[]>(
- defaultValue ?? [],
- );
+ const forceFirstValue =
+ appSection === AppSection.FILTER_CONFIG_MODAL && defaultToFirstItem;
+
const groupby = ensureIsArray<string>(formData.groupby);
+ // Correct initial value for Ant Select
+ const initSelectValue: SelectValue =
+ // `defaultValue` can be `FIRST_VALUE` if `defaultToFirstItem` is checked, so need convert it to correct value for Select
+ defaultValue === FIRST_VALUE ? [] : defaultValue ?? [];
+
+ const firstItem: SelectValue = data[0]
+ ? (groupby.map(col => data[0][col]) as string[]) ?? initSelectValue
+ : initSelectValue;
+
+ // If we are in config modal we always need show empty select for `defaultToFirstItem`
+ const [values, setValues] = useState<SelectValue>(
+ defaultToFirstItem && appSection !== AppSection.FILTER_CONFIG_MODAL
+ ? firstItem
+ : initSelectValue,
+ );
const [col] = groupby;
const datatype: GenericDataType = coltypeMap[col];
const labelFormatter = getDataRecordFormatter({
timeFormatter: smartDateDetailedFormatter,
});
- const handleChange = (
- value?: (number | string)[] | number | string | null,
- ) => {
- const resultValue: (number | string)[] = ensureIsArray<number | string>(
- value,
- );
- setValues(resultValue);
+ const handleChange = (value?: SelectValue | number | string) => {
+ let selectValue: (number | string)[];
+ if (value === FIRST_VALUE) {
+ selectValue = forceFirstValue ? [] : firstItem;
+ } else {
+ selectValue = ensureIsArray<number | string>(value);
+ }
+ setValues(selectValue);
const emptyFilter =
- enableEmptyFilter && !inverseSelection && resultValue?.length === 0;
+ enableEmptyFilter && !inverseSelection && selectValue?.length === 0;
+
+ // Set currentState value for a case of non-`defaultToFirstItem`
+ const stateValue = selectValue.length ? selectValue : null;
const dataMask = {
extraFormData: getSelectExtraFormData(
col,
- resultValue,
+ selectValue,
emptyFilter,
inverseSelection,
),
currentState: {
- value: resultValue.length ? resultValue : null,
+ // We need to save in state `FIRST_VALUE` as some const and not as REAL value,
+ // because when FiltersBar check if all filters initialized it compares `defaultValue` with this value
+ // and because REAL value can be unpredictable for users that have different data for same dashboard we use `FIRST_VALUE`
+ value: value === FIRST_VALUE ? FIRST_VALUE : stateValue,
Review comment:
With the new logic this section is becoming slightly difficult to follow and could potentially be simplified. There's a few `value === FIRST_VALUE` checks, and the names `value`, `selectValue`, `stateValue` make it not obvious to the casual reader what these mean. I propose making these more explicit, e.g. renaming `value` to `selectedValue` (=what's the current selection) and constructing `stateValue` (=what goes in `currentState`) earlier on so we don't need to do a
```javascript
currentState: { value: value === FIRST_VALUE ? FIRST_VALUE : stateValue }
```
later on. It would be nice if `stateValue` would already be fully ready by the time we arrive at that point, making the final `currentState` look more like this:
```javascript
currentState: { value: stateValue }
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13726: feat(native-filters): Add default first value to select filter
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13726:
URL: https://github.com/apache/superset/pull/13726#issuecomment-804173881
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13726: feat(native-filters): Add default first value to select filter
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13726:
URL: https://github.com/apache/superset/pull/13726#issuecomment-804173881
# [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=h1) Report
> Merging [#13726](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=desc) (7a4b38c) into [master](https://codecov.io/gh/apache/superset/commit/abd4051f7a94b7e1a653ae6c0590645b0fe1dd33?el=desc) (abd4051) will **decrease** coverage by `4.93%`.
> The diff coverage is `75.00%`.
> :exclamation: Current head 7a4b38c differs from pull request most recent head 10cec8a. Consider uploading reports for the commit 10cec8a to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13726 +/- ##
==========================================
- Coverage 78.03% 73.10% -4.94%
==========================================
Files 934 626 -308
Lines 47349 22229 -25120
Branches 5943 5797 -146
==========================================
- Hits 36950 16251 -20699
+ Misses 10254 5836 -4418
+ Partials 145 142 -3
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.50% <85.71%> (+2.82%)` | :arrow_up: |
| hive | `?` | |
| javascript | `63.12% <0.00%> (-3.21%)` | :arrow_down: |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `?` | |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tend/src/filters/components/Select/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvY29udHJvbFBhbmVsLnRz) | `18.18% <0.00%> (-1.82%)` | :arrow_down: |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `100.00% <ø> (ø)` | |
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `80.43% <85.71%> (-0.52%)` | :arrow_down: |
| [...controls/DndColumnSelectControl/DndSelectLabel.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZFNlbGVjdExhYmVsLnRzeA==) | `35.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...trols/DateFilterControl/components/CustomFrame.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0N1c3RvbUZyYW1lLnRzeA==) | `42.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...ols/DateFilterControl/components/AdvancedFrame.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0FkdmFuY2VkRnJhbWUudHN4) | `53.84% <0.00%> (-46.16%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLnRz) | `46.66% <0.00%> (-40.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `63.63% <0.00%> (-36.37%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `63.63% <0.00%> (-36.37%)` | :arrow_down: |
| [...ontrols/DndColumnSelectControl/DndFilterSelect.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZEZpbHRlclNlbGVjdC50c3g=) | `9.23% <0.00%> (-36.16%)` | :arrow_down: |
| ... and [453 more](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=footer). Last update [abd4051...10cec8a](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13726: feat(native-filters): Add default first value to select filter
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13726:
URL: https://github.com/apache/superset/pull/13726#issuecomment-804173881
# [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=h1) Report
> Merging [#13726](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=desc) (7a4b38c) into [master](https://codecov.io/gh/apache/superset/commit/daefebb49deb255dad8514d62b6887ca1a00a723?el=desc) (daefebb) will **decrease** coverage by `4.28%`.
> The diff coverage is `75.00%`.
> :exclamation: Current head 7a4b38c differs from pull request most recent head 53f2a17. Consider uploading reports for the commit 53f2a17 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13726 +/- ##
==========================================
- Coverage 77.39% 73.10% -4.29%
==========================================
Files 928 626 -302
Lines 47024 22229 -24795
Branches 5812 5797 -15
==========================================
- Hits 36393 16251 -20142
+ Misses 10488 5836 -4652
+ Partials 143 142 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.50% <85.71%> (+0.06%)` | :arrow_up: |
| hive | `?` | |
| javascript | `63.12% <0.00%> (-0.02%)` | :arrow_down: |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `?` | |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tend/src/filters/components/Select/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvY29udHJvbFBhbmVsLnRz) | `18.18% <0.00%> (-1.82%)` | :arrow_down: |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `100.00% <ø> (ø)` | |
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `80.43% <85.71%> (-0.52%)` | :arrow_down: |
| [...tend/src/dashboard/containers/DashboardBuilder.jsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZEJ1aWxkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ponents/nativeFilters/FilterBar/CascadePopover.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nhc2NhZGVQb3BvdmVyLnRzeA==) | `63.38% <0.00%> (-19.72%)` | :arrow_down: |
| [...components/nativeFilters/FilterBar/FilterValue.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclZhbHVlLnRzeA==) | `69.09% <0.00%> (-16.37%)` | :arrow_down: |
| [...d/components/nativeFilters/FilterBar/FilterBar.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckJhci50c3g=) | `81.25% <0.00%> (-11.18%)` | :arrow_down: |
| [...tend/src/dashboard/components/DashboardBuilder.jsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Rhc2hib2FyZEJ1aWxkZXIuanN4) | `76.54% <0.00%> (-9.88%)` | :arrow_down: |
| [...nd/src/dashboard/containers/DashboardComponent.jsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZENvbXBvbmVudC5qc3g=) | `95.65% <0.00%> (-4.35%)` | :arrow_down: |
| [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `90.90% <0.00%> (ø)` | |
| ... and [327 more](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=footer). Last update [daefebb...53f2a17](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13726: feat(native-filters): Add default first value to select filter
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13726:
URL: https://github.com/apache/superset/pull/13726#issuecomment-804173881
# [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=h1) Report
> Merging [#13726](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=desc) (7a4b38c) into [master](https://codecov.io/gh/apache/superset/commit/abd4051f7a94b7e1a653ae6c0590645b0fe1dd33?el=desc) (abd4051) will **decrease** coverage by `4.93%`.
> The diff coverage is `75.00%`.
> :exclamation: Current head 7a4b38c differs from pull request most recent head 5da45bb. Consider uploading reports for the commit 5da45bb to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13726 +/- ##
==========================================
- Coverage 78.03% 73.10% -4.94%
==========================================
Files 934 626 -308
Lines 47349 22229 -25120
Branches 5943 5797 -146
==========================================
- Hits 36950 16251 -20699
+ Misses 10254 5836 -4418
+ Partials 145 142 -3
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.50% <85.71%> (+2.82%)` | :arrow_up: |
| hive | `?` | |
| javascript | `63.12% <0.00%> (-3.21%)` | :arrow_down: |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `?` | |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tend/src/filters/components/Select/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvY29udHJvbFBhbmVsLnRz) | `18.18% <0.00%> (-1.82%)` | :arrow_down: |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `100.00% <ø> (ø)` | |
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `80.43% <85.71%> (-0.52%)` | :arrow_down: |
| [...controls/DndColumnSelectControl/DndSelectLabel.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZFNlbGVjdExhYmVsLnRzeA==) | `35.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...trols/DateFilterControl/components/CustomFrame.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0N1c3RvbUZyYW1lLnRzeA==) | `42.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...ols/DateFilterControl/components/AdvancedFrame.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0FkdmFuY2VkRnJhbWUudHN4) | `53.84% <0.00%> (-46.16%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLnRz) | `46.66% <0.00%> (-40.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `63.63% <0.00%> (-36.37%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `63.63% <0.00%> (-36.37%)` | :arrow_down: |
| [...ontrols/DndColumnSelectControl/DndFilterSelect.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZEZpbHRlclNlbGVjdC50c3g=) | `9.23% <0.00%> (-36.16%)` | :arrow_down: |
| ... and [453 more](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=footer). Last update [abd4051...5da45bb](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13726: feat(native-filters): Add default first value to select filter
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13726:
URL: https://github.com/apache/superset/pull/13726#issuecomment-804173881
# [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=h1) Report
> Merging [#13726](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=desc) (60ff6e1) into [master](https://codecov.io/gh/apache/superset/commit/b427a80a4f7e760e9fa8e9937a53995e1d076b6e?el=desc) (b427a80) will **decrease** coverage by `0.76%`.
> The diff coverage is `86.66%`.
> :exclamation: Current head 60ff6e1 differs from pull request most recent head 1c2f278. Consider uploading reports for the commit 1c2f278 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13726 +/- ##
==========================================
- Coverage 78.71% 77.95% -0.77%
==========================================
Files 936 936
Lines 47408 47411 +3
Branches 5938 5949 +11
==========================================
- Hits 37315 36957 -358
- Misses 9949 10306 +357
- Partials 144 148 +4
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `47.07% <85.71%> (-4.61%)` | :arrow_down: |
| hive | `?` | |
| javascript | `68.81% <4.16%> (-0.04%)` | :arrow_down: |
| mysql | `80.78% <95.23%> (+0.21%)` | :arrow_up: |
| postgres | `?` | |
| python | `80.82% <95.23%> (-0.18%)` | :arrow_down: |
| sqlite | `80.38% <95.23%> (+0.21%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tend/src/filters/components/Select/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvY29udHJvbFBhbmVsLnRz) | `18.18% <0.00%> (-1.82%)` | :arrow_down: |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <ø> (ø)` | |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `92.82% <66.66%> (-0.41%)` | :arrow_down: |
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `78.43% <80.00%> (-2.53%)` | :arrow_down: |
| [...tersConfigModal/FiltersConfigForm/DefaultValue.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0RlZmF1bHRWYWx1ZS50c3g=) | `100.00% <100.00%> (ø)` | |
| [...nd/src/filters/components/Select/transformProps.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHJhbnNmb3JtUHJvcHMudHM=) | `81.81% <100.00%> (ø)` | |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `100.00% <100.00%> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.84% <100.00%> (+0.09%)` | :arrow_up: |
| [superset/reports/commands/alert.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9hbGVydC5weQ==) | `96.42% <100.00%> (+0.22%)` | :arrow_up: |
| [superset/reports/dao.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9kYW8ucHk=) | `82.50% <100.00%> (+2.32%)` | :arrow_up: |
| ... and [93 more](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=footer). Last update [b427a80...1c2f278](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on a change in pull request #13726: feat(native-filters): Add default first value to select filter
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #13726:
URL: https://github.com/apache/superset/pull/13726#discussion_r607785576
##########
File path: superset-frontend/src/filters/components/Select/SelectFilterPlugin.tsx
##########
@@ -115,18 +140,27 @@ export default function PluginFilterSelect(props: PluginFilterSelectProps) {
};
useEffect(() => {
- handleChange(currentValue ?? []);
+ // For currentValue we need set always `FIRST_VALUE` only if we in config modal for `defaultToFirstItem` mode
+ handleChange(
+ isDefaultToFirstItemInFilterConfigModal
+ ? FIRST_VALUE
+ : currentValue ?? [],
+ );
}, [
JSON.stringify(currentValue),
+ defaultToFirstItem,
Review comment:
Shouldn't this be `isDefaultToFirstItemInFilterConfigModal`?
##########
File path: superset-frontend/src/filters/components/Select/SelectFilterPlugin.tsx
##########
@@ -66,39 +68,62 @@ export default function PluginFilterSelect(props: PluginFilterSelectProps) {
currentValue,
inverseSelection,
inputRef,
+ defaultToFirstItem,
} = formData;
- const [values, setValues] = useState<(string | number | boolean)[]>(
- defaultValue ?? [],
- );
+ const isDefaultToFirstItemInFilterConfigModal =
+ appSection === AppSection.FILTER_CONFIG_MODAL && defaultToFirstItem;
Review comment:
This is a bit of a name monster 👹 . Could we just call this `forceFirstValue`, as I think it applies both to the change handler and the component disabler?
##########
File path: superset-frontend/src/filters/components/Select/SelectFilterPlugin.tsx
##########
@@ -17,17 +17,18 @@
* under the License.
*/
import {
- createMultiFormatter,
Behavior,
+ createMultiFormatter,
DataMask,
ensureIsArray,
GenericDataType,
+ AppSection,
Review comment:
ABC
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13726: feat(native-filters): Add default first value to select filter
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13726:
URL: https://github.com/apache/superset/pull/13726#issuecomment-804173881
# [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=h1) Report
> Merging [#13726](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=desc) (57ff3b1) into [master](https://codecov.io/gh/apache/superset/commit/a4fd6b8f33e9e780084a71f3e5b579468cdd635b?el=desc) (a4fd6b8) will **decrease** coverage by `0.58%`.
> The diff coverage is `48.78%`.
> :exclamation: Current head 57ff3b1 differs from pull request most recent head 5f37308. Consider uploading reports for the commit 5f37308 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13726 +/- ##
==========================================
- Coverage 79.30% 78.72% -0.59%
==========================================
Files 939 939
Lines 47541 47589 +48
Branches 5938 5962 +24
==========================================
- Hits 37703 37465 -238
- Misses 9717 9989 +272
- Partials 121 135 +14
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.75% <85.71%> (+2.51%)` | :arrow_up: |
| hive | `?` | |
| mysql | `80.71% <ø> (ø)` | |
| postgres | `80.74% <ø> (+<0.01%)` | :arrow_up: |
| presto | `?` | |
| python | `80.82% <ø> (-0.49%)` | :arrow_down: |
| sqlite | `80.34% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tend/src/filters/components/Select/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvY29udHJvbFBhbmVsLnRz) | `16.66% <0.00%> (-3.34%)` | :arrow_down: |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <ø> (ø)` | |
| [...nd/src/filters/components/Select/transformProps.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHJhbnNmb3JtUHJvcHMudHM=) | `50.00% <12.50%> (-31.82%)` | :arrow_down: |
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `55.71% <55.17%> (-24.78%)` | :arrow_down: |
| [...tersConfigModal/FiltersConfigForm/DefaultValue.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0RlZmF1bHRWYWx1ZS50c3g=) | `96.29% <100.00%> (-3.71%)` | :arrow_down: |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `66.66% <100.00%> (-33.34%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...tend/src/visualizations/FilterBox/controlPanel.jsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9jb250cm9sUGFuZWwuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [...trols/DateFilterControl/components/CommonFrame.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0NvbW1vbkZyYW1lLnRzeA==) | `41.66% <0.00%> (-41.67%)` | :arrow_down: |
| ... and [53 more](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=footer). Last update [a4fd6b8...5f37308](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] removed a comment on pull request #13726: feat(native-filters): Add default first value to select filter
Posted by GitBox <gi...@apache.org>.
github-actions[bot] removed a comment on pull request #13726:
URL: https://github.com/apache/superset/pull/13726#issuecomment-804384611
@junlincc Ephemeral environment spinning up at http://52.12.10.237:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13726: feat(native-filters): Add default first value to select filter
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13726:
URL: https://github.com/apache/superset/pull/13726#issuecomment-804173881
# [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=h1) Report
> Merging [#13726](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=desc) (80b6a01) into [master](https://codecov.io/gh/apache/superset/commit/b427a80a4f7e760e9fa8e9937a53995e1d076b6e?el=desc) (b427a80) will **decrease** coverage by `0.69%`.
> The diff coverage is `48.78%`.
> :exclamation: Current head 80b6a01 differs from pull request most recent head caed773. Consider uploading reports for the commit caed773 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13726 +/- ##
==========================================
- Coverage 78.71% 78.01% -0.70%
==========================================
Files 936 936
Lines 47408 47458 +50
Branches 5938 5962 +24
==========================================
- Hits 37315 37024 -291
- Misses 9949 10273 +324
- Partials 144 161 +17
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `46.99% <85.71%> (-4.68%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tend/src/filters/components/Select/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvY29udHJvbFBhbmVsLnRz) | `16.66% <0.00%> (-3.34%)` | :arrow_down: |
| [...nd/src/filters/components/Select/transformProps.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHJhbnNmb3JtUHJvcHMudHM=) | `50.00% <12.50%> (-31.82%)` | :arrow_down: |
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `55.55% <55.17%> (-25.40%)` | :arrow_down: |
| [...tersConfigModal/FiltersConfigForm/DefaultValue.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0RlZmF1bHRWYWx1ZS50c3g=) | `96.29% <100.00%> (-3.71%)` | :arrow_down: |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `66.66% <100.00%> (-33.34%)` | :arrow_down: |
| [...nd/src/dashboard/util/getFilterValuesByFilterId.js](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclZhbHVlc0J5RmlsdGVySWQuanM=) | `25.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...trols/DateFilterControl/components/CommonFrame.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0NvbW1vbkZyYW1lLnRzeA==) | `41.66% <0.00%> (-41.67%)` | :arrow_down: |
| [...ols/DateFilterControl/components/CalendarFrame.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0NhbGVuZGFyRnJhbWUudHN4) | `46.15% <0.00%> (-38.47%)` | :arrow_down: |
| [...nents/controls/MetricControl/AdhocMetricOption.jsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljT3B0aW9uLmpzeA==) | `72.72% <0.00%> (-27.28%)` | :arrow_down: |
| [...ntrols/MetricControl/AdhocMetricPopoverTrigger.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljUG9wb3ZlclRyaWdnZXIudHN4) | `70.00% <0.00%> (-25.00%)` | :arrow_down: |
| ... and [41 more](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=footer). Last update [b427a80...caed773](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13726: feat(native-filters): Add default first value to select filter
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13726:
URL: https://github.com/apache/superset/pull/13726#issuecomment-804173881
# [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=h1) Report
> Merging [#13726](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=desc) (60ff6e1) into [master](https://codecov.io/gh/apache/superset/commit/a4fd6b8f33e9e780084a71f3e5b579468cdd635b?el=desc) (a4fd6b8) will **decrease** coverage by `0.02%`.
> The diff coverage is `79.16%`.
> :exclamation: Current head 60ff6e1 differs from pull request most recent head 8ccb6f0. Consider uploading reports for the commit 8ccb6f0 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13726 +/- ##
==========================================
- Coverage 79.30% 79.28% -0.03%
==========================================
Files 939 936 -3
Lines 47541 47489 -52
Branches 5938 5966 +28
==========================================
- Hits 37703 37652 -51
+ Misses 9717 9710 -7
- Partials 121 127 +6
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `55.72% <85.71%> (+1.48%)` | :arrow_up: |
| hive | `80.49% <ø> (+0.05%)` | :arrow_up: |
| javascript | `68.81% <4.16%> (-0.60%)` | :arrow_down: |
| mysql | `80.78% <ø> (+0.07%)` | :arrow_up: |
| postgres | `80.82% <ø> (+0.07%)` | :arrow_up: |
| presto | `80.51% <ø> (+0.05%)` | :arrow_up: |
| python | `81.37% <ø> (+0.05%)` | :arrow_up: |
| sqlite | `80.38% <ø> (+0.03%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tend/src/filters/components/Select/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvY29udHJvbFBhbmVsLnRz) | `18.18% <0.00%> (-1.82%)` | :arrow_down: |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <ø> (ø)` | |
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `78.43% <80.00%> (-2.06%)` | :arrow_down: |
| [...tersConfigModal/FiltersConfigForm/DefaultValue.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0RlZmF1bHRWYWx1ZS50c3g=) | `100.00% <100.00%> (ø)` | |
| [...nd/src/filters/components/Select/transformProps.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHJhbnNmb3JtUHJvcHMudHM=) | `81.81% <100.00%> (ø)` | |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `100.00% <100.00%> (ø)` | |
| [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `58.46% <0.00%> (-30.57%)` | :arrow_down: |
| [...tersConfigModal/FiltersConfigForm/ControlItems.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0NvbnRyb2xJdGVtcy50c3g=) | `70.83% <0.00%> (-29.17%)` | :arrow_down: |
| [...tersConfigModal/FiltersConfigForm/ColumnSelect.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0NvbHVtblNlbGVjdC50c3g=) | `77.77% <0.00%> (-19.45%)` | :arrow_down: |
| [...d/src/dashboard/components/gridComponents/Tabs.jsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL1RhYnMuanN4) | `74.73% <0.00%> (-13.69%)` | :arrow_down: |
| ... and [52 more](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=footer). Last update [a4fd6b8...8ccb6f0](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13726: feat(native-filters): Add default first value to select filter
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13726:
URL: https://github.com/apache/superset/pull/13726#issuecomment-804173881
# [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=h1) Report
> Merging [#13726](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=desc) (be2a1b6) into [master](https://codecov.io/gh/apache/superset/commit/b427a80a4f7e760e9fa8e9937a53995e1d076b6e?el=desc) (b427a80) will **decrease** coverage by `0.48%`.
> The diff coverage is `8.33%`.
> :exclamation: Current head be2a1b6 differs from pull request most recent head 95baf89. Consider uploading reports for the commit 95baf89 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13726 +/- ##
==========================================
- Coverage 78.71% 78.22% -0.49%
==========================================
Files 936 936
Lines 47408 47419 +11
Branches 5938 5949 +11
==========================================
- Hits 37315 37093 -222
- Misses 9949 10187 +238
+ Partials 144 139 -5
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `49.86% <50.00%> (-1.81%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [...tend/src/filters/components/Select/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvY29udHJvbFBhbmVsLnRz) | `18.18% <0.00%> (-1.82%)` | :arrow_down: |
| [...nd/src/filters/components/Select/transformProps.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHJhbnNmb3JtUHJvcHMudHM=) | `0.00% <0.00%> (-81.82%)` | :arrow_down: |
| [...tersConfigModal/FiltersConfigForm/DefaultValue.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0RlZmF1bHRWYWx1ZS50c3g=) | `88.88% <100.00%> (-11.12%)` | :arrow_down: |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `100.00% <100.00%> (ø)` | |
| [...tend/src/visualizations/FilterBox/controlPanel.jsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9jb250cm9sUGFuZWwuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ponents/Select/WindowedSelect/WindowedMenuList.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1dpbmRvd2VkU2VsZWN0L1dpbmRvd2VkTWVudUxpc3QudHN4) | `10.71% <0.00%> (-85.72%)` | :arrow_down: |
| [...ontend/src/filters/components/Select/buildQuery.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvYnVpbGRRdWVyeS50cw==) | `0.00% <0.00%> (-77.78%)` | :arrow_down: |
| [superset-frontend/src/filters/components/common.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9jb21tb24udHM=) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
| [...ontend/src/dashboard/util/serializeFilterScopes.js](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3NlcmlhbGl6ZUZpbHRlclNjb3Blcy5qcw==) | `40.00% <0.00%> (-60.00%)` | :arrow_down: |
| ... and [82 more](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=footer). Last update [b427a80...95baf89](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13726: feat(native-filters): Add default first value to select filter
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13726:
URL: https://github.com/apache/superset/pull/13726#issuecomment-804173881
# [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=h1) Report
> Merging [#13726](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=desc) (57ff3b1) into [master](https://codecov.io/gh/apache/superset/commit/a4fd6b8f33e9e780084a71f3e5b579468cdd635b?el=desc) (a4fd6b8) will **decrease** coverage by `0.51%`.
> The diff coverage is `86.66%`.
> :exclamation: Current head 57ff3b1 differs from pull request most recent head 5f37308. Consider uploading reports for the commit 5f37308 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13726 +/- ##
==========================================
- Coverage 79.30% 78.78% -0.52%
==========================================
Files 939 939
Lines 47541 47514 -27
Branches 5938 5938
==========================================
- Hits 37703 37435 -268
- Misses 9717 9958 +241
Partials 121 121
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `80.34% <ø> (-0.97%)` | :arrow_down: |
| sqlite | `80.34% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tend/src/filters/components/Select/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvY29udHJvbFBhbmVsLnRz) | `20.00% <0.00%> (ø)` | |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `100.00% <ø> (ø)` | |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <ø> (ø)` | |
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `80.48% <85.00%> (ø)` | |
| [...tersConfigModal/FiltersConfigForm/DefaultValue.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0RlZmF1bHRWYWx1ZS50c3g=) | `100.00% <100.00%> (ø)` | |
| [...nd/src/filters/components/Select/transformProps.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHJhbnNmb3JtUHJvcHMudHM=) | `81.81% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `31.37% <0.00%> (-60.79%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/models/sql\_types/base.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF90eXBlcy9iYXNlLnB5) | `52.63% <0.00%> (-31.58%)` | :arrow_down: |
| ... and [30 more](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=footer). Last update [a4fd6b8...5f37308](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13726: feat(native-filters): Add default first value to select filter
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13726:
URL: https://github.com/apache/superset/pull/13726#issuecomment-804173881
# [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=h1) Report
> Merging [#13726](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=desc) (c9b96d5) into [master](https://codecov.io/gh/apache/superset/commit/56dc74e09f1665c1030a8e6ccf66e27fb4f24e9b?el=desc) (56dc74e) will **decrease** coverage by `1.34%`.
> The diff coverage is `9.67%`.
> :exclamation: Current head c9b96d5 differs from pull request most recent head de733f3. Consider uploading reports for the commit de733f3 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13726 +/- ##
==========================================
- Coverage 78.87% 77.53% -1.35%
==========================================
Files 936 936
Lines 47408 47427 +19
Branches 5941 5949 +8
==========================================
- Hits 37393 36772 -621
- Misses 9883 10500 +617
- Partials 132 155 +23
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `47.40% <50.00%> (-11.70%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [...tend/src/filters/components/Select/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvY29udHJvbFBhbmVsLnRz) | `16.66% <0.00%> (-3.34%)` | :arrow_down: |
| [...nd/src/filters/components/Select/transformProps.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHJhbnNmb3JtUHJvcHMudHM=) | `0.00% <0.00%> (-81.82%)` | :arrow_down: |
| [...tersConfigModal/FiltersConfigForm/DefaultValue.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0RlZmF1bHRWYWx1ZS50c3g=) | `62.96% <100.00%> (-37.04%)` | :arrow_down: |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `66.66% <100.00%> (-33.34%)` | :arrow_down: |
| [...ponents/Select/WindowedSelect/WindowedMenuList.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1dpbmRvd2VkU2VsZWN0L1dpbmRvd2VkTWVudUxpc3QudHN4) | `10.71% <0.00%> (-85.72%)` | :arrow_down: |
| [...ontend/src/filters/components/Select/buildQuery.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvYnVpbGRRdWVyeS50cw==) | `0.00% <0.00%> (-77.78%)` | :arrow_down: |
| [superset-frontend/src/filters/components/common.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9jb21tb24udHM=) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
| [superset-frontend/src/dataMask/reducer.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFNYXNrL3JlZHVjZXIudHM=) | `44.00% <0.00%> (-56.00%)` | :arrow_down: |
| [...nd/src/dashboard/util/getFilterValuesByFilterId.js](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclZhbHVlc0J5RmlsdGVySWQuanM=) | `25.00% <0.00%> (-50.00%)` | :arrow_down: |
| ... and [92 more](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=footer). Last update [56dc74e...de733f3](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13726: feat(native-filters): Add default first value to select filter
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13726:
URL: https://github.com/apache/superset/pull/13726#issuecomment-804173881
# [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=h1) Report
> Merging [#13726](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=desc) (9db8487) into [master](https://codecov.io/gh/apache/superset/commit/a4fd6b8f33e9e780084a71f3e5b579468cdd635b?el=desc) (a4fd6b8) will **decrease** coverage by `0.02%`.
> The diff coverage is `79.16%`.
[](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13726 +/- ##
==========================================
- Coverage 79.30% 79.28% -0.03%
==========================================
Files 939 939
Lines 47541 47552 +11
Branches 5938 5949 +11
==========================================
- Hits 37703 37701 -2
- Misses 9717 9730 +13
Partials 121 121
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.05% <85.71%> (+1.81%)` | :arrow_up: |
| hive | `?` | |
| javascript | `69.37% <4.16%> (-0.04%)` | :arrow_down: |
| presto | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tend/src/filters/components/Select/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvY29udHJvbFBhbmVsLnRz) | `18.18% <0.00%> (-1.82%)` | :arrow_down: |
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `78.00% <80.00%> (-2.49%)` | :arrow_down: |
| [...tersConfigModal/FiltersConfigForm/DefaultValue.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0RlZmF1bHRWYWx1ZS50c3g=) | `100.00% <100.00%> (ø)` | |
| [...nd/src/filters/components/Select/transformProps.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHJhbnNmb3JtUHJvcHMudHM=) | `81.81% <100.00%> (ø)` | |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.42% <0.00%> (-16.42%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.79% <0.00%> (-8.16%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.24% <0.00%> (-1.70%)` | :arrow_down: |
| ... and [20 more](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=footer). Last update [a4fd6b8...9db8487](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13726: feat(native-filters): Add default first value to select filter
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13726:
URL: https://github.com/apache/superset/pull/13726#issuecomment-804173881
# [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=h1) Report
> Merging [#13726](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=desc) (57ff3b1) into [master](https://codecov.io/gh/apache/superset/commit/a4fd6b8f33e9e780084a71f3e5b579468cdd635b?el=desc) (a4fd6b8) will **decrease** coverage by `0.28%`.
> The diff coverage is `86.66%`.
> :exclamation: Current head 57ff3b1 differs from pull request most recent head 5f37308. Consider uploading reports for the commit 5f37308 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13726 +/- ##
==========================================
- Coverage 79.30% 79.02% -0.29%
==========================================
Files 939 939
Lines 47541 47541
Branches 5938 5938
==========================================
- Hits 37703 37569 -134
- Misses 9717 9851 +134
Partials 121 121
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `80.74% <ø> (+<0.01%)` | :arrow_up: |
| presto | `?` | |
| python | `80.78% <ø> (-0.53%)` | :arrow_down: |
| sqlite | `80.34% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tend/src/filters/components/Select/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvY29udHJvbFBhbmVsLnRz) | `20.00% <0.00%> (ø)` | |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `100.00% <ø> (ø)` | |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <ø> (ø)` | |
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `80.48% <85.00%> (ø)` | |
| [...tersConfigModal/FiltersConfigForm/DefaultValue.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0RlZmF1bHRWYWx1ZS50c3g=) | `100.00% <100.00%> (ø)` | |
| [...nd/src/filters/components/Select/transformProps.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHJhbnNmb3JtUHJvcHMudHM=) | `81.81% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.42% <0.00%> (-16.42%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.79% <0.00%> (-8.16%)` | :arrow_down: |
| ... and [9 more](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=footer). Last update [a4fd6b8...5f37308](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13726: feat(native-filters): Add default first value to select filter
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13726:
URL: https://github.com/apache/superset/pull/13726#issuecomment-804173881
# [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=h1) Report
> Merging [#13726](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=desc) (cc0dc6f) into [master](https://codecov.io/gh/apache/superset/commit/a4fd6b8f33e9e780084a71f3e5b579468cdd635b?el=desc) (a4fd6b8) will **decrease** coverage by `0.83%`.
> The diff coverage is `52.00%`.
> :exclamation: Current head cc0dc6f differs from pull request most recent head 4919889. Consider uploading reports for the commit 4919889 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13726 +/- ##
==========================================
- Coverage 79.30% 78.47% -0.84%
==========================================
Files 939 939
Lines 47541 47598 +57
Branches 5938 5960 +22
==========================================
- Hits 37703 37351 -352
- Misses 9717 10099 +382
- Partials 121 148 +27
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `53.27% <82.60%> (-0.97%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tend/src/filters/components/Select/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvY29udHJvbFBhbmVsLnRz) | `16.66% <0.00%> (-3.34%)` | :arrow_down: |
| [...nd/src/filters/components/Select/transformProps.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHJhbnNmb3JtUHJvcHMudHM=) | `50.00% <12.50%> (-31.82%)` | :arrow_down: |
| [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `76.47% <50.00%> (-0.40%)` | :arrow_down: |
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `55.55% <54.83%> (-24.94%)` | :arrow_down: |
| [...tersConfigModal/FiltersConfigForm/DefaultValue.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0RlZmF1bHRWYWx1ZS50c3g=) | `96.29% <100.00%> (-3.71%)` | :arrow_down: |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `66.66% <100.00%> (-33.34%)` | :arrow_down: |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.68% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/utils/async\_query\_manager.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvYXN5bmNfcXVlcnlfbWFuYWdlci5weQ==) | `81.37% <100.00%> (+0.37%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [67 more](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=footer). Last update [a4fd6b8...4919889](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #13726: feat(native-filters): Add default first value to select filter
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13726:
URL: https://github.com/apache/superset/pull/13726#issuecomment-804384611
@junlincc Ephemeral environment spinning up at http://52.12.10.237:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13726: feat(native-filters): Add default first value to select filter
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13726:
URL: https://github.com/apache/superset/pull/13726#issuecomment-804173881
# [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=h1) Report
> Merging [#13726](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=desc) (cc0dc6f) into [master](https://codecov.io/gh/apache/superset/commit/a4fd6b8f33e9e780084a71f3e5b579468cdd635b?el=desc) (a4fd6b8) will **decrease** coverage by `0.44%`.
> The diff coverage is `52.00%`.
> :exclamation: Current head cc0dc6f differs from pull request most recent head 4919889. Consider uploading reports for the commit 4919889 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13726 +/- ##
==========================================
- Coverage 79.30% 78.86% -0.45%
==========================================
Files 939 939
Lines 47541 47599 +58
Branches 5938 5960 +22
==========================================
- Hits 37703 37539 -164
- Misses 9717 9919 +202
- Partials 121 141 +20
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `51.72% <82.60%> (-2.52%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tend/src/filters/components/Select/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvY29udHJvbFBhbmVsLnRz) | `16.66% <0.00%> (-3.34%)` | :arrow_down: |
| [...nd/src/filters/components/Select/transformProps.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHJhbnNmb3JtUHJvcHMudHM=) | `50.00% <12.50%> (-31.82%)` | :arrow_down: |
| [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `76.47% <50.00%> (-0.40%)` | :arrow_down: |
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `55.55% <54.83%> (-24.94%)` | :arrow_down: |
| [...tersConfigModal/FiltersConfigForm/DefaultValue.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0RlZmF1bHRWYWx1ZS50c3g=) | `96.29% <100.00%> (-3.71%)` | :arrow_down: |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `66.66% <100.00%> (-33.34%)` | :arrow_down: |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.68% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/utils/async\_query\_manager.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvYXN5bmNfcXVlcnlfbWFuYWdlci5weQ==) | `81.37% <100.00%> (+0.37%)` | :arrow_up: |
| [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...c/dashboard/components/dnd/AddSliceDragPreview.jsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9BZGRTbGljZURyYWdQcmV2aWV3LmpzeA==) | `35.71% <0.00%> (-64.29%)` | :arrow_down: |
| ... and [51 more](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=footer). Last update [a4fd6b8...4919889](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13726: feat(native-filters): Add default first value to select filter
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13726:
URL: https://github.com/apache/superset/pull/13726#issuecomment-804173881
# [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=h1) Report
> Merging [#13726](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=desc) (c9b96d5) into [master](https://codecov.io/gh/apache/superset/commit/56dc74e09f1665c1030a8e6ccf66e27fb4f24e9b?el=desc) (56dc74e) will **decrease** coverage by `0.97%`.
> The diff coverage is `9.67%`.
> :exclamation: Current head c9b96d5 differs from pull request most recent head de733f3. Consider uploading reports for the commit de733f3 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13726 +/- ##
==========================================
- Coverage 78.87% 77.89% -0.98%
==========================================
Files 936 936
Lines 47408 47428 +20
Branches 5941 5949 +8
==========================================
- Hits 37393 36946 -447
- Misses 9883 10330 +447
- Partials 132 152 +20
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `47.15% <50.00%> (-11.95%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [...tend/src/filters/components/Select/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvY29udHJvbFBhbmVsLnRz) | `16.66% <0.00%> (-3.34%)` | :arrow_down: |
| [...nd/src/filters/components/Select/transformProps.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHJhbnNmb3JtUHJvcHMudHM=) | `0.00% <0.00%> (-81.82%)` | :arrow_down: |
| [...tersConfigModal/FiltersConfigForm/DefaultValue.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0RlZmF1bHRWYWx1ZS50c3g=) | `62.96% <100.00%> (-37.04%)` | :arrow_down: |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `66.66% <100.00%> (-33.34%)` | :arrow_down: |
| [...ponents/Select/WindowedSelect/WindowedMenuList.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1dpbmRvd2VkU2VsZWN0L1dpbmRvd2VkTWVudUxpc3QudHN4) | `10.71% <0.00%> (-85.72%)` | :arrow_down: |
| [...ontend/src/filters/components/Select/buildQuery.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvYnVpbGRRdWVyeS50cw==) | `0.00% <0.00%> (-77.78%)` | :arrow_down: |
| [superset-frontend/src/filters/components/common.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9jb21tb24udHM=) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
| [superset-frontend/src/dataMask/reducer.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFNYXNrL3JlZHVjZXIudHM=) | `44.00% <0.00%> (-56.00%)` | :arrow_down: |
| [...nd/src/dashboard/util/getFilterValuesByFilterId.js](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclZhbHVlc0J5RmlsdGVySWQuanM=) | `25.00% <0.00%> (-50.00%)` | :arrow_down: |
| ... and [95 more](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=footer). Last update [56dc74e...de733f3](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13726: feat(native-filters): Add default first value to select filter
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13726:
URL: https://github.com/apache/superset/pull/13726#issuecomment-804173881
# [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=h1) Report
> Merging [#13726](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=desc) (60ff6e1) into [master](https://codecov.io/gh/apache/superset/commit/b427a80a4f7e760e9fa8e9937a53995e1d076b6e?el=desc) (b427a80) will **increase** coverage by `0.39%`.
> The diff coverage is `90.19%`.
> :exclamation: Current head 60ff6e1 differs from pull request most recent head 1c2f278. Consider uploading reports for the commit 1c2f278 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13726 +/- ##
==========================================
+ Coverage 78.71% 79.10% +0.39%
==========================================
Files 936 936
Lines 47408 47400 -8
Branches 5938 5938
==========================================
+ Hits 37315 37498 +183
+ Misses 9949 9776 -173
+ Partials 144 126 -18
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `80.78% <95.23%> (+0.21%)` | :arrow_up: |
| postgres | `?` | |
| python | `80.82% <95.23%> (-0.18%)` | :arrow_down: |
| sqlite | `80.38% <95.23%> (+0.21%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tend/src/filters/components/Select/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvY29udHJvbFBhbmVsLnRz) | `20.00% <0.00%> (ø)` | |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `100.00% <ø> (ø)` | |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <ø> (ø)` | |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `92.82% <66.66%> (-0.41%)` | :arrow_down: |
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `80.95% <85.00%> (ø)` | |
| [...tersConfigModal/FiltersConfigForm/DefaultValue.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0RlZmF1bHRWYWx1ZS50c3g=) | `100.00% <100.00%> (ø)` | |
| [...nd/src/filters/components/Select/transformProps.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHJhbnNmb3JtUHJvcHMudHM=) | `81.81% <100.00%> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.84% <100.00%> (+0.09%)` | :arrow_up: |
| [superset/reports/commands/alert.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9hbGVydC5weQ==) | `96.42% <100.00%> (+0.22%)` | :arrow_up: |
| [superset/reports/dao.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9kYW8ucHk=) | `82.50% <100.00%> (+2.32%)` | :arrow_up: |
| ... and [55 more](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=footer). Last update [b427a80...1c2f278](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13726: feat(native-filters): Add default first value to select filter
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13726:
URL: https://github.com/apache/superset/pull/13726#issuecomment-804173881
# [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=h1) Report
> Merging [#13726](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=desc) (60ff6e1) into [master](https://codecov.io/gh/apache/superset/commit/b427a80a4f7e760e9fa8e9937a53995e1d076b6e?el=desc) (b427a80) will **increase** coverage by `0.51%`.
> The diff coverage is `86.66%`.
> :exclamation: Current head 60ff6e1 differs from pull request most recent head 1c2f278. Consider uploading reports for the commit 1c2f278 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13726 +/- ##
==========================================
+ Coverage 78.71% 79.22% +0.51%
==========================================
Files 936 936
Lines 47408 47438 +30
Branches 5938 5949 +11
==========================================
+ Hits 37315 37585 +270
+ Misses 9949 9724 -225
+ Partials 144 129 -15
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `55.26% <85.71%> (+3.59%)` | :arrow_up: |
| hive | `80.49% <95.23%> (+0.21%)` | :arrow_up: |
| javascript | `68.81% <4.16%> (-0.04%)` | :arrow_down: |
| mysql | `80.78% <95.23%> (+0.21%)` | :arrow_up: |
| postgres | `?` | |
| presto | `80.51% <95.23%> (?)` | |
| python | `81.32% <95.23%> (+0.33%)` | :arrow_up: |
| sqlite | `80.38% <95.23%> (+0.21%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tend/src/filters/components/Select/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvY29udHJvbFBhbmVsLnRz) | `18.18% <0.00%> (-1.82%)` | :arrow_down: |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <ø> (ø)` | |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `92.82% <66.66%> (-0.41%)` | :arrow_down: |
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `78.43% <80.00%> (-2.53%)` | :arrow_down: |
| [...tersConfigModal/FiltersConfigForm/DefaultValue.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0RlZmF1bHRWYWx1ZS50c3g=) | `100.00% <100.00%> (ø)` | |
| [...nd/src/filters/components/Select/transformProps.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHJhbnNmb3JtUHJvcHMudHM=) | `81.81% <100.00%> (ø)` | |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `100.00% <100.00%> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.84% <100.00%> (+0.09%)` | :arrow_up: |
| [superset/reports/commands/alert.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9hbGVydC5weQ==) | `96.42% <100.00%> (+0.22%)` | :arrow_up: |
| [superset/reports/dao.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9kYW8ucHk=) | `82.50% <100.00%> (+2.32%)` | :arrow_up: |
| ... and [51 more](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=footer). Last update [b427a80...1c2f278](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13726: feat(native-filters): Add default first value to select filter
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13726:
URL: https://github.com/apache/superset/pull/13726#issuecomment-804173881
# [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=h1) Report
> Merging [#13726](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=desc) (7a4b38c) into [master](https://codecov.io/gh/apache/superset/commit/56dc74e09f1665c1030a8e6ccf66e27fb4f24e9b?el=desc) (56dc74e) will **decrease** coverage by `5.68%`.
> The diff coverage is `75.00%`.
> :exclamation: Current head 7a4b38c differs from pull request most recent head 10b9557. Consider uploading reports for the commit 10b9557 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13726 +/- ##
==========================================
- Coverage 78.78% 73.10% -5.69%
==========================================
Files 936 626 -310
Lines 47408 22229 -25179
Branches 5941 5797 -144
==========================================
- Hits 37352 16251 -21101
+ Misses 9924 5836 -4088
- Partials 132 142 +10
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.50% <85.71%> (-2.59%)` | :arrow_down: |
| hive | `?` | |
| javascript | `63.12% <0.00%> (-5.33%)` | :arrow_down: |
| mysql | `?` | |
| postgres | `?` | |
| python | `?` | |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tend/src/filters/components/Select/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvY29udHJvbFBhbmVsLnRz) | `18.18% <0.00%> (-1.82%)` | :arrow_down: |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `100.00% <ø> (ø)` | |
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `80.43% <85.71%> (-0.52%)` | :arrow_down: |
| [...tend/src/dashboard/util/getFilterFieldNodesTree.js](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlckZpZWxkTm9kZXNUcmVlLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...end/src/dashboard/util/getKeyForFilterScopeTree.js](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEtleUZvckZpbHRlclNjb3BlVHJlZS5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...nd/src/dashboard/util/getFilterScopeParentNodes.js](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlUGFyZW50Tm9kZXMuanM=) | `0.00% <0.00%> (-91.67%)` | :arrow_down: |
| [...ponents/filterscope/renderFilterFieldTreeNodes.jsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL3JlbmRlckZpbHRlckZpZWxkVHJlZU5vZGVzLmpzeA==) | `0.00% <0.00%> (-90.00%)` | :arrow_down: |
| [...ponents/filterscope/renderFilterScopeTreeNodes.jsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL3JlbmRlckZpbHRlclNjb3BlVHJlZU5vZGVzLmpzeA==) | `0.00% <0.00%> (-86.67%)` | :arrow_down: |
| [...ard/components/filterscope/FilterScopeSelector.jsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlclNjb3BlU2VsZWN0b3IuanN4) | `2.05% <0.00%> (-85.62%)` | :arrow_down: |
| [...board/util/getSelectedChartIdForFilterScopeTree.js](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldFNlbGVjdGVkQ2hhcnRJZEZvckZpbHRlclNjb3BlVHJlZS5qcw==) | `0.00% <0.00%> (-80.00%)` | :arrow_down: |
| ... and [523 more](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=footer). Last update [56dc74e...10b9557](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13726: feat(native-filters): Add default first value to select filter
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13726:
URL: https://github.com/apache/superset/pull/13726#issuecomment-804173881
# [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=h1) Report
> Merging [#13726](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=desc) (60ff6e1) into [master](https://codecov.io/gh/apache/superset/commit/b427a80a4f7e760e9fa8e9937a53995e1d076b6e?el=desc) (b427a80) will **increase** coverage by `0.51%`.
> The diff coverage is `86.66%`.
> :exclamation: Current head 60ff6e1 differs from pull request most recent head 1c2f278. Consider uploading reports for the commit 1c2f278 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13726 +/- ##
==========================================
+ Coverage 78.71% 79.22% +0.51%
==========================================
Files 936 936
Lines 47408 47438 +30
Branches 5938 5949 +11
==========================================
+ Hits 37315 37585 +270
+ Misses 9949 9724 -225
+ Partials 144 129 -15
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `55.26% <85.71%> (+3.59%)` | :arrow_up: |
| hive | `80.49% <95.23%> (+0.21%)` | :arrow_up: |
| javascript | `68.81% <4.16%> (-0.04%)` | :arrow_down: |
| mysql | `80.78% <95.23%> (+0.21%)` | :arrow_up: |
| postgres | `?` | |
| presto | `80.51% <95.23%> (?)` | |
| python | `81.32% <95.23%> (+0.33%)` | :arrow_up: |
| sqlite | `80.38% <95.23%> (+0.21%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tend/src/filters/components/Select/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvY29udHJvbFBhbmVsLnRz) | `18.18% <0.00%> (-1.82%)` | :arrow_down: |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <ø> (ø)` | |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `92.82% <66.66%> (-0.41%)` | :arrow_down: |
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `78.43% <80.00%> (-2.53%)` | :arrow_down: |
| [...tersConfigModal/FiltersConfigForm/DefaultValue.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0RlZmF1bHRWYWx1ZS50c3g=) | `100.00% <100.00%> (ø)` | |
| [...nd/src/filters/components/Select/transformProps.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHJhbnNmb3JtUHJvcHMudHM=) | `81.81% <100.00%> (ø)` | |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `100.00% <100.00%> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.84% <100.00%> (+0.09%)` | :arrow_up: |
| [superset/reports/commands/alert.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9hbGVydC5weQ==) | `96.42% <100.00%> (+0.22%)` | :arrow_up: |
| [superset/reports/dao.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9kYW8ucHk=) | `82.50% <100.00%> (+2.32%)` | :arrow_up: |
| ... and [51 more](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=footer). Last update [b427a80...1c2f278](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13726: feat(native-filters): Add default first value to select filter
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13726:
URL: https://github.com/apache/superset/pull/13726#issuecomment-804173881
# [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=h1) Report
> Merging [#13726](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=desc) (9db8487) into [master](https://codecov.io/gh/apache/superset/commit/a4fd6b8f33e9e780084a71f3e5b579468cdd635b?el=desc) (a4fd6b8) will **decrease** coverage by `0.32%`.
> The diff coverage is `60.97%`.
[](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13726 +/- ##
==========================================
- Coverage 79.30% 78.97% -0.33%
==========================================
Files 939 939
Lines 47541 47592 +51
Branches 5938 5966 +28
==========================================
- Hits 37703 37587 -116
- Misses 9717 9883 +166
- Partials 121 122 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| javascript | `69.37% <4.16%> (-0.04%)` | :arrow_down: |
| presto | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tend/src/filters/components/Select/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvY29udHJvbFBhbmVsLnRz) | `16.66% <0.00%> (-3.34%)` | :arrow_down: |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `33.33% <0.00%> (-66.67%)` | :arrow_down: |
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `45.83% <56.66%> (-34.66%)` | :arrow_down: |
| [...nd/src/filters/components/Select/transformProps.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHJhbnNmb3JtUHJvcHMudHM=) | `50.00% <87.50%> (-31.82%)` | :arrow_down: |
| [...tersConfigModal/FiltersConfigForm/DefaultValue.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0RlZmF1bHRWYWx1ZS50c3g=) | `96.29% <100.00%> (-3.71%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.42% <0.00%> (-16.42%)` | :arrow_down: |
| ... and [9 more](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=footer). Last update [a4fd6b8...9db8487](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc removed a comment on pull request #13726: feat(native-filters): Add default first value to select filter
Posted by GitBox <gi...@apache.org>.
junlincc removed a comment on pull request #13726:
URL: https://github.com/apache/superset/pull/13726#issuecomment-806117947
@simcha90 Thanks for the PR! LGTM but the check box list is getting really long, we may need to tweak the UI and potentially remove some check boxes from the modal
@mihir174
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #13726: feat(native-filters): Add default first value to select filter
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #13726:
URL: https://github.com/apache/superset/pull/13726#issuecomment-806117947
@simcha90 Thanks for the PR! LGTM but the check box list is getting really long, we may need to tweak the UI and potentially remove some check boxes from the modal
@mihir174
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #13726: feat(native-filters): Add default first value to select filter
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13726:
URL: https://github.com/apache/superset/pull/13726#issuecomment-814908951
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13726: feat(native-filters): Add default first value to select filter
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13726:
URL: https://github.com/apache/superset/pull/13726#issuecomment-804173881
# [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=h1) Report
> Merging [#13726](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=desc) (7a4b38c) into [master](https://codecov.io/gh/apache/superset/commit/abd4051f7a94b7e1a653ae6c0590645b0fe1dd33?el=desc) (abd4051) will **decrease** coverage by `4.93%`.
> The diff coverage is `75.00%`.
> :exclamation: Current head 7a4b38c differs from pull request most recent head 22d7f7a. Consider uploading reports for the commit 22d7f7a to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13726 +/- ##
==========================================
- Coverage 78.03% 73.10% -4.94%
==========================================
Files 934 626 -308
Lines 47349 22229 -25120
Branches 5943 5797 -146
==========================================
- Hits 36950 16251 -20699
+ Misses 10254 5836 -4418
+ Partials 145 142 -3
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.50% <85.71%> (+2.82%)` | :arrow_up: |
| hive | `?` | |
| javascript | `63.12% <0.00%> (-3.21%)` | :arrow_down: |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `?` | |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tend/src/filters/components/Select/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvY29udHJvbFBhbmVsLnRz) | `18.18% <0.00%> (-1.82%)` | :arrow_down: |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `100.00% <ø> (ø)` | |
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `80.43% <85.71%> (-0.52%)` | :arrow_down: |
| [...controls/DndColumnSelectControl/DndSelectLabel.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZFNlbGVjdExhYmVsLnRzeA==) | `35.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...trols/DateFilterControl/components/CustomFrame.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0N1c3RvbUZyYW1lLnRzeA==) | `42.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...ols/DateFilterControl/components/AdvancedFrame.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0FkdmFuY2VkRnJhbWUudHN4) | `53.84% <0.00%> (-46.16%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLnRz) | `46.66% <0.00%> (-40.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `63.63% <0.00%> (-36.37%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `63.63% <0.00%> (-36.37%)` | :arrow_down: |
| [...ontrols/DndColumnSelectControl/DndFilterSelect.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZEZpbHRlclNlbGVjdC50c3g=) | `9.23% <0.00%> (-36.16%)` | :arrow_down: |
| ... and [453 more](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=footer). Last update [abd4051...22d7f7a](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13726: feat(native-filters): Add default first value to select filter
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13726:
URL: https://github.com/apache/superset/pull/13726#issuecomment-804173881
# [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=h1) Report
> Merging [#13726](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=desc) (57ff3b1) into [master](https://codecov.io/gh/apache/superset/commit/a4fd6b8f33e9e780084a71f3e5b579468cdd635b?el=desc) (a4fd6b8) will **decrease** coverage by `0.02%`.
> The diff coverage is `79.16%`.
> :exclamation: Current head 57ff3b1 differs from pull request most recent head 5f37308. Consider uploading reports for the commit 5f37308 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13726 +/- ##
==========================================
- Coverage 79.30% 79.28% -0.03%
==========================================
Files 939 939
Lines 47541 47552 +11
Branches 5938 5947 +9
==========================================
- Hits 37703 37702 -1
- Misses 9717 9729 +12
Partials 121 121
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.06% <85.71%> (+1.82%)` | :arrow_up: |
| hive | `?` | |
| javascript | `69.37% <4.16%> (-0.04%)` | :arrow_down: |
| mysql | `80.71% <ø> (ø)` | |
| postgres | `80.74% <ø> (+<0.01%)` | :arrow_up: |
| presto | `?` | |
| python | `80.82% <ø> (-0.49%)` | :arrow_down: |
| sqlite | `80.34% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tend/src/filters/components/Select/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvY29udHJvbFBhbmVsLnRz) | `18.18% <0.00%> (-1.82%)` | :arrow_down: |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <ø> (ø)` | |
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `78.00% <80.00%> (-2.49%)` | :arrow_down: |
| [...tersConfigModal/FiltersConfigForm/DefaultValue.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0RlZmF1bHRWYWx1ZS50c3g=) | `100.00% <100.00%> (ø)` | |
| [...nd/src/filters/components/Select/transformProps.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHJhbnNmb3JtUHJvcHMudHM=) | `81.81% <100.00%> (ø)` | |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.42% <0.00%> (-16.42%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.79% <0.00%> (-8.16%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| ... and [20 more](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=footer). Last update [a4fd6b8...5f37308](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13726: feat(native-filters): Add default first value to select filter
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13726:
URL: https://github.com/apache/superset/pull/13726#issuecomment-804173881
# [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=h1) Report
> Merging [#13726](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=desc) (60ff6e1) into [master](https://codecov.io/gh/apache/superset/commit/a4fd6b8f33e9e780084a71f3e5b579468cdd635b?el=desc) (a4fd6b8) will **decrease** coverage by `0.02%`.
> The diff coverage is `79.16%`.
> :exclamation: Current head 60ff6e1 differs from pull request most recent head 5f37308. Consider uploading reports for the commit 5f37308 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13726 +/- ##
==========================================
- Coverage 79.30% 79.28% -0.03%
==========================================
Files 939 936 -3
Lines 47541 47489 -52
Branches 5938 5966 +28
==========================================
- Hits 37703 37652 -51
+ Misses 9717 9710 -7
- Partials 121 127 +6
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `55.72% <85.71%> (+1.48%)` | :arrow_up: |
| hive | `80.49% <ø> (+0.05%)` | :arrow_up: |
| javascript | `68.81% <4.16%> (-0.60%)` | :arrow_down: |
| mysql | `80.78% <ø> (+0.07%)` | :arrow_up: |
| postgres | `80.82% <ø> (+0.07%)` | :arrow_up: |
| presto | `80.51% <ø> (+0.05%)` | :arrow_up: |
| python | `81.37% <ø> (+0.05%)` | :arrow_up: |
| sqlite | `80.38% <ø> (+0.03%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tend/src/filters/components/Select/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvY29udHJvbFBhbmVsLnRz) | `18.18% <0.00%> (-1.82%)` | :arrow_down: |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <ø> (ø)` | |
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `78.43% <80.00%> (-2.06%)` | :arrow_down: |
| [...tersConfigModal/FiltersConfigForm/DefaultValue.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0RlZmF1bHRWYWx1ZS50c3g=) | `100.00% <100.00%> (ø)` | |
| [...nd/src/filters/components/Select/transformProps.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHJhbnNmb3JtUHJvcHMudHM=) | `81.81% <100.00%> (ø)` | |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `100.00% <100.00%> (ø)` | |
| [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `58.46% <0.00%> (-30.57%)` | :arrow_down: |
| [...tersConfigModal/FiltersConfigForm/ControlItems.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0NvbnRyb2xJdGVtcy50c3g=) | `70.83% <0.00%> (-29.17%)` | :arrow_down: |
| [...tersConfigModal/FiltersConfigForm/ColumnSelect.tsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0NvbHVtblNlbGVjdC50c3g=) | `77.77% <0.00%> (-19.45%)` | :arrow_down: |
| [...d/src/dashboard/components/gridComponents/Tabs.jsx](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL1RhYnMuanN4) | `74.73% <0.00%> (-13.69%)` | :arrow_down: |
| ... and [52 more](https://codecov.io/gh/apache/superset/pull/13726/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=footer). Last update [a4fd6b8...5f37308](https://codecov.io/gh/apache/superset/pull/13726?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org