[GitHub] [skywalking] afriqs opened a new issue #7744: [INFRA/eyes] Support for Ruby/Rails files

[GitBox <gi...@apache.org>]

afriqs opened a new issue #7744:
URL: https://github.com/apache/skywalking/issues/7744


   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar feature requirement.
   
   
   ### Description
   
   License headers for ruby (`.rb`) ans rails (`.erb`) files are not supported yet due to lack of `comment_style_id`.
   
   ### Use case
   
   Add license headers to such files.
   
   ### Related issues
   
   _No response_
   
   ### Are you willing to submit a PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] afriqs commented on issue #7744: [INFRA/eyes] Support for Ruby/Rails files

[GitBox <gi...@apache.org>]

afriqs commented on issue #7744:
URL: https://github.com/apache/skywalking/issues/7744#issuecomment-923001975


   Hi,
   
   I would like to provide tests but I don't see how :shrug: 
   
   When I `cd test && go test -v` I only see two passing tests : *TestConfigHeaderSpdxASF* and *TestConfigHeaderSpdxPlain*.
   
   I think it may be related to `test/tesdata/include_test/with[out]_license` but don't know how ti use them...
   
   Note : not a `go` developer :innocent: 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] kezhenxu94 commented on issue #7744: [INFRA/eyes] Support for Ruby/Rails files

[GitBox <gi...@apache.org>]

kezhenxu94 commented on issue #7744:
URL: https://github.com/apache/skywalking/issues/7744#issuecomment-923026302


   Hi @afriqs , thank you. The `tests` directory serves as a demonstration data actually. And for new file support, you might want to add a case in https://github.com/apache/skywalking-eyes/blob/main/pkg/header/fix_test.go


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org