You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/11/28 00:10:03 UTC

[GitHub] [spark] HyukjinKwon commented on a change in pull request #30522: [SPARK-33578][CORE] enableHiveSupport is invalid after sparkContext t…

HyukjinKwon commented on a change in pull request #30522:
URL: https://github.com/apache/spark/pull/30522#discussion_r531811066



##########
File path: core/src/main/scala/org/apache/spark/SparkContext.scala
##########
@@ -710,6 +710,11 @@ class SparkContext(config: SparkConf) extends Logging {
     }
   }
 
+  /** Set spark conf */
+  def setSparkConf(sparkConf: SparkConf): Unit = {

Review comment:
       Spark cknfig is supposed to be immutable. I don't think we should allow this in Spark context. If you should set a static SQL config, you should either stop and start the context again or set it initially when you create a Spark context.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org