[jira] [Commented] (HADOOP-8424) Web UI broken on Windows because classpath not setup correctly

["Ivan Mitic (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-8424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13284588#comment-13284588 ] 

Ivan Mitic commented on HADOOP-8424:
------------------------------------

Looks good overall. Three minor comments:
1. It seems that you misplaced the comment "for developers, add Hadoop classes to CLASSPATH", it should be left on its original location
2. Can you please remove the "if exist %HADOOP_CORE_HOME%\..." before "for" loops as it is not needed
3. Can you also please break the two if's and place: 
{code}
for %%i in (%HADOOP_CORE_HOME%\build\*.jar) do (
  set CLASSPATH=!CLASSPATH!;%%i
)
{code}
under "for releases, add core hadoop jar & webapps to CLASSPATH", and place:
{code}
for %%i in (%HADOOP_CORE_HOME%\build\ivy\lib\Hadoop\common\*.jar) do (
  set CLASSPATH=!CLASSPATH!;%%i
)
{code}
under: "add libs to CLASSPATH" right after
{code}for %%i in (%HADOOP_CORE_HOME%\lib\*.jar) do (
  set CLASSPATH=!CLASSPATH!;%%i
){code}
This way, we will be more consistent with the script layout from "bin\hadoop" used for non-Windows platforms.

Separately, what do you think about having a tracking Jira on making .sh and .cmd scripts fully consistent, as they aren't at the moment?

                
> Web UI broken on Windows because classpath not setup correctly
> --------------------------------------------------------------
>
>                 Key: HADOOP-8424
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8424
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 1.0.0
>            Reporter: Bikas Saha
>            Assignee: Bikas Saha
>             Fix For: 1.1.0
>
>         Attachments: HADOOP-8424.branch-1-win.patch
>
>
> The classpath is setup to include the hadoop jars before the build webapps directory and that upsets jetty when it is trying to resolve the webapp classes.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira