You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "ArnavBalyan (via GitHub)" <gi...@apache.org> on 2023/09/22 18:20:38 UTC

[GitHub] [pinot] ArnavBalyan commented on a diff in pull request #11625: Force FileChannel to commit data to disk

ArnavBalyan commented on code in PR #11625:
URL: https://github.com/apache/pinot/pull/11625#discussion_r1334697119


##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/startree/v2/builder/StarTreeIndexSeparator.java:
##########
@@ -143,6 +143,7 @@ private void writeIndexToFile(File destFile, StarTreeIndexMapUtils.IndexValue va
       throws IOException {
     try (FileChannel dest = new RandomAccessFile(destFile, "rw").getChannel()) {
       org.apache.pinot.common.utils.FileUtils.transferBytes(_indexFileChannel, value._offset, value._size, dest);
+      _indexFileChannel.force(true);

Review Comment:
   Done thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org