You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/09/10 22:25:39 UTC
[GitHub] codecov-io edited a comment on issue #5848: fix sqlab progress bar
and status inconsistency
codecov-io edited a comment on issue #5848: fix sqlab progress bar and status inconsistency
URL: https://github.com/apache/incubator-superset/pull/5848#issuecomment-420080186
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5848?src=pr&el=h1) Report
> Merging [#5848](https://codecov.io/gh/apache/incubator-superset/pull/5848?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/73db918fbe0995375b442a1596a402ca27eac9d2?src=pr&el=desc) will **decrease** coverage by `0.12%`.
> The diff coverage is `50%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/5848/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/5848?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5848 +/- ##
==========================================
- Coverage 63.75% 63.62% -0.13%
==========================================
Files 374 374
Lines 23320 23320
Branches 2608 2608
==========================================
- Hits 14867 14837 -30
- Misses 8440 8470 +30
Partials 13 13
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5848?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/assets/src/SqlLab/reducers.js](https://codecov.io/gh/apache/incubator-superset/pull/5848/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvcmVkdWNlcnMuanM=) | `58.18% <ø> (ø)` | :arrow_up: |
| [superset/assets/src/SqlLab/constants.js](https://codecov.io/gh/apache/incubator-superset/pull/5848/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29uc3RhbnRzLmpz) | `100% <ø> (ø)` | :arrow_up: |
| [.../assets/src/SqlLab/components/QueryAutoRefresh.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5848/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9RdWVyeUF1dG9SZWZyZXNoLmpzeA==) | `52.5% <0%> (ø)` | :arrow_up: |
| [...uperset/assets/src/SqlLab/components/ResultSet.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5848/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9SZXN1bHRTZXQuanN4) | `87.36% <100%> (ø)` | :arrow_up: |
| [superset/db\_engine\_specs.py](https://codecov.io/gh/apache/incubator-superset/pull/5848/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzLnB5) | `53.14% <0%> (-2.05%)` | :arrow_down: |
| [superset/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/5848/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMucHk=) | `88.12% <0%> (-0.9%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/5848/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `80.37% <0%> (-0.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/5848/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `84.6% <0%> (-0.5%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/5848/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.03% <0%> (-0.3%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5848?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5848?src=pr&el=footer). Last update [73db918...cb92739](https://codecov.io/gh/apache/incubator-superset/pull/5848?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org