[GitHub] [iceberg] hililiwei commented on pull request #4734: ORC: Upgrade orc version to use the built-in estimate memory method

[GitBox <gi...@apache.org>]

hililiwei commented on PR #4734:
URL: https://github.com/apache/iceberg/pull/4734#issuecomment-1121780430

   Hi @kbendick, thank you for your timely review.
   In the latest revision, I adopted the split scheme for subsequent review.
   1. Keep the original method for the common part of the test.
   2. separated the different tests(for no_nans) into two methods, one for ORC and one for Parquet, named `testIsNanOrc` and `testIsNanParquet`. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org