[jira] [Commented] (GUACAMOLE-876) RDP "reconnect" resizing breaks Drive Mapping

["Mike Jumper (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GUACAMOLE-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17009340#comment-17009340 ] 

Mike Jumper commented on GUACAMOLE-876:
---------------------------------------

{quote}
In the attached video you can see resizing a connection with the resize method "reconnect", will halt any current file transfers (leaving corrupted files) ...
{quote}

Avoiding reconnect if a transfer is underway may be as simple as checking whether {{filesystem->open_files}} is non-zero within {{guac_rdp_disp_reconnect_needed()}}. That would avoid reconnecting for a resize so long as anything has an open file on the shared drive. The same should probably be done for print jobs and via {{rdp_client->active_job}}.

Worth addressing, but leveraging GUACAMOLE-249 and reliable support for the Display Update channel is probably a better solution in general, assuming the Windows machines in question are recent enough to support Display Update.

{quote}
... and sporadically leave the drive map unconnected for the new session.
{quote}

This has been reported separately as GUACAMOLE-900. I'd say let's use that issue for that and leave this issue dedicated to allowing in-progress transfers to complete despite "resize-method" being set set to "reconnect".

> RDP "reconnect" resizing breaks Drive Mapping
> ---------------------------------------------
>
>                 Key: GUACAMOLE-876
>                 URL: https://issues.apache.org/jira/browse/GUACAMOLE-876
>             Project: Guacamole
>          Issue Type: Bug
>          Components: guacd
>    Affects Versions: 1.1.0
>            Reporter: Richard Lancaster
>            Priority: Minor
>         Attachments: guacd.log, guacd_resize_file_trasfer.mp4
>
>
> In the attached video you can see resizing a connection with the resize method "reconnect", will halt any current file transfers (leaving corrupted files) and sporadically leave the drive map unconnected for the new session.
>  
> The associated guacd logs associated with the video are attached.
>  
> Running:
>  * Web frontend - 1.0.0 (the official guacamole/guacamole docker image)
>  * Guacd - staging/1.1.0 (381ff1a4214e06803f0f587f1ed97cf7e54853e7) (Built against ubuntu 18.04's libfreerdb-dev)
>  
> Let me know if there is any more info you need.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)