[jira] [Commented] (SHIRO-892) No Guice binding for newly introduced ShiroFilterConfiguration

["Brian Demers (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SHIRO-892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17617973#comment-17617973 ] 

Brian Demers commented on SHIRO-892:
------------------------------------

[~cstamas] 
Do you have an example of this ?

I think I'm missing something here; the UT and ITs don't seem to show this problem.
For example: https://github.com/apache/shiro/blob/main/support/guice/src/test/java/org/apache/shiro/guice/web/ShiroWebModuleTest.java

We could probably do something like this:
https://gist.github.com/bdemers/620f58bd8c6e59f31e3b4be129c2a444

But we should probably figure out why this isn't getting caught by our existing tests first

> No Guice binding for newly introduced ShiroFilterConfiguration
> --------------------------------------------------------------
>
>                 Key: SHIRO-892
>                 URL: https://issues.apache.org/jira/browse/SHIRO-892
>             Project: Shiro
>          Issue Type: Bug
>          Components: Integration: Guice
>    Affects Versions: 1.10.0
>            Reporter: Tamas Cservenak
>            Assignee: Jared Bunting
>            Priority: Major
>
> When using Shiro 1.10.0 using Guice, the object graph is incomplete (no binding for ShiroFilterConfiguration). Release notes did not mention that user must provide it either.
> Personally, I'd prefer to have Shiro provide one "out of the box" if possible, as otherwise this may count as "breaking change"?
> Cause is this commit: [https://github.com/apache/shiro/commit/28e10e0ca1cdcd2cede86802fde8464b29265fc8]
> Reproducer: try to "boot off" Shiro as an "Guice app would" (using Guice integration, ie. prep a sample app using 1.9.1 then migrate it to 1.10.0 -> incomplete graph)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@shiro.apache.org
For additional commands, e-mail: issues-help@shiro.apache.org