[GitHub] [incubator-superset] john-bodley opened a new pull request #7888: [sqla] Adding check for invalid filter columns

[GitBox <gi...@apache.org>]

john-bodley opened a new pull request #7888: [sqla] Adding check for invalid filter columns
URL: https://github.com/apache/incubator-superset/pull/7888
 
 
   ### CATEGORY
   
   Choose one
   
   - [x] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   
   This PR fixes an issue where if you specified an invalid column (achievable in the URL) in a simple filter, i.e., not custom SQL, then the filter was simply ignored and the the query would execute sans the filter with no clear indication to the user that the filter wasn't being applied. 
   
   This PR applies the same logic as invalid metrics and raises an exception if the column is invalid. Note I added unit tests to cover both the invalid metric and column use cases.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   ##### BEFORE 
   ![Screen Shot 2019-07-17 at 3 32 12 PM](https://user-images.githubusercontent.com/4567245/61416309-1746d180-a8a8-11e9-9c27-24c21d8173b0.png)
   
   ##### AFTER 
   ![Screen Shot 2019-07-17 at 3 29 58 PM](https://user-images.githubusercontent.com/4567245/61416308-1746d180-a8a8-11e9-86ff-67e6dfd7de94.png)
   
   
   
   <!--- Skip this if not applicable -->
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   
   to: @michellethomas @mistercrunch @williaster 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org