[GitHub] [arrow] andygrove commented on a change in pull request #8076: ARROW-9885: [Rust][DataFusion] Minor code simplification

[GitBox <gi...@apache.org>]

andygrove commented on a change in pull request #8076:
URL: https://github.com/apache/arrow/pull/8076#discussion_r480611387



##########
File path: rust/datafusion/src/execution/physical_plan/expressions.rs
##########
@@ -991,48 +991,36 @@ impl fmt::Display for BinaryExpr {
     }
 }
 
-// Returns a formatted error about being impossible to coerce types for the binary operator.
-fn coercion_error<T>(
-    lhs_type: &DataType,
-    op: &Operator,
-    rhs_type: &DataType,
-) -> Result<T> {
+// Returns a formatted error about being impossible to coerce types to a common type
+fn coercion_error<T>(lhs_type: &DataType, rhs_type: &DataType) -> Result<T> {
     Err(ExecutionError::General(
         format!(
-            "The binary operator '{}' can't evaluate with lhs = '{:?}' and rhs = '{:?}'",

Review comment:
       I agree that this seems like a regression in UX. It is useful to know which operator was involved to reduce the effort to debug an error like this.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org