You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/05/31 14:48:56 UTC

[GitHub] [incubator-pinot] sunithabeeram opened a new issue #4265: Cleanup pinot-api interfaces

sunithabeeram opened a new issue #4265: Cleanup pinot-api interfaces
URL: https://github.com/apache/incubator-pinot/issues/4265
 
 
   This issue tracks discussion in https://github.com/apache/incubator-pinot/pull/4243. The current structure of the module isn't clean in terms of relationship within the classes/interfaces in the module and its hard to understand which of the interfaces are truly external/extensible and which are not. Ideally, most all classes in pinot-api should be considered "external" facing.
   
   Some specific issues from #4243: ConnectionFactory is considered to be the external facing interface; however the functionality is exposed through static methods and a specific transport-factory implementation is tied to the class that makes it inflexible to drop in other transports (For e.g., its unclear how one might use a Https transport).
   
   It would be good to clarify/cleanup the interfaces.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org