You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/12/21 21:11:05 UTC
[GitHub] [airflow] KKcorps opened a new pull request #6875: [Airflow-6076]
Fix dag.cli() Key error
KKcorps opened a new pull request #6875: [Airflow-6076] Fix dag.cli() Key error
URL: https://github.com/apache/airflow/pull/6875
Make sure you have checked _all_ steps below.
### Jira
- [X] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-6076
### Description
- [X] Here are some details about my PR, including screenshots of any UI changes:
DAG subcommands are now nested inside the main command. However, the subcommand dictionary contained only the main commands. This resulted in a KeyError when querying for a subcommand from the dict.
### Tests
- [X] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
Tests already exist.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] KKcorps commented on issue #6875: [AIRFLOW-6076] Fix
dag.cli() Key error
Posted by GitBox <gi...@apache.org>.
KKcorps commented on issue #6875: [AIRFLOW-6076] Fix dag.cli() Key error
URL: https://github.com/apache/airflow/pull/6875#issuecomment-568418175
Hi, What is the difference between using dag_parser or using the common parser to parse the dag subcommands?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6875:
[Airflow-6076] Fix dag.cli() Key error
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6875: [Airflow-6076] Fix dag.cli() Key error
URL: https://github.com/apache/airflow/pull/6875#issuecomment-568214414
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=h1) Report
> Merging [#6875](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a6bc4165ff3d3588ec5dc802f411e071adf80cb3?src=pr&el=desc) will **decrease** coverage by `0.28%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6875 +/- ##
==========================================
- Coverage 84.61% 84.33% -0.29%
==========================================
Files 680 680
Lines 38501 38505 +4
==========================================
- Hits 32578 32472 -106
- Misses 5923 6033 +110
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `95.83% <100%> (+0.24%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=footer). Last update [a6bc416...4d8e22a](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] stale[bot] commented on issue #6875: [AIRFLOW-6076] Fix
dag.cli() Key error
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on issue #6875: [AIRFLOW-6076] Fix dag.cli() Key error
URL: https://github.com/apache/airflow/pull/6875#issuecomment-607945275
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] nuclearpinguin commented on issue #6875: [AIRFLOW-6076]
Fix dag.cli() Key error
Posted by GitBox <gi...@apache.org>.
nuclearpinguin commented on issue #6875: [AIRFLOW-6076] Fix dag.cli() Key error
URL: https://github.com/apache/airflow/pull/6875#issuecomment-568542791
@mik-laj can you provide use case for this command?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6875:
[Airflow-6076] Fix dag.cli() Key error
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6875: [Airflow-6076] Fix dag.cli() Key error
URL: https://github.com/apache/airflow/pull/6875#issuecomment-568214414
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=h1) Report
> Merging [#6875](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a6bc4165ff3d3588ec5dc802f411e071adf80cb3?src=pr&el=desc) will **decrease** coverage by `0.28%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6875 +/- ##
==========================================
- Coverage 84.61% 84.33% -0.29%
==========================================
Files 680 680
Lines 38501 38505 +4
==========================================
- Hits 32578 32472 -106
- Misses 5923 6033 +110
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `95.83% <100%> (+0.24%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=footer). Last update [a6bc416...4d8e22a](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6875:
[Airflow-6076] Fix dag.cli() Key error
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6875: [Airflow-6076] Fix dag.cli() Key error
URL: https://github.com/apache/airflow/pull/6875#issuecomment-568214414
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=h1) Report
> Merging [#6875](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/6a5a4ef4e435de4c911e9e130d6ff7313f52a37b?src=pr&el=desc) will **decrease** coverage by `0.28%`.
> The diff coverage is `50%`.
[](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6875 +/- ##
==========================================
- Coverage 84.61% 84.32% -0.29%
==========================================
Files 680 680
Lines 38501 38499 -2
==========================================
- Hits 32577 32465 -112
- Misses 5924 6034 +110
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/models/dag.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvZGFnLnB5) | `90.95% <0%> (ø)` | :arrow_up: |
| [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `95.45% <100%> (-0.14%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/utils/dates.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kYXRlcy5weQ==) | `89.36% <0%> (ø)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=footer). Last update [6a5a4ef...3559560](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6875:
[Airflow-6076] Fix dag.cli() Key error
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6875: [Airflow-6076] Fix dag.cli() Key error
URL: https://github.com/apache/airflow/pull/6875#issuecomment-568214414
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=h1) Report
> Merging [#6875](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a6bc4165ff3d3588ec5dc802f411e071adf80cb3?src=pr&el=desc) will **decrease** coverage by `0.28%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6875 +/- ##
==========================================
- Coverage 84.61% 84.33% -0.29%
==========================================
Files 680 680
Lines 38501 38505 +4
==========================================
- Hits 32578 32472 -106
- Misses 5923 6033 +110
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `95.83% <100%> (+0.24%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=footer). Last update [a6bc416...4d8e22a](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj edited a comment on issue #6875: [AIRFLOW-6076]
Fix dag.cli() Key error
Posted by GitBox <gi...@apache.org>.
mik-laj edited a comment on issue #6875: [AIRFLOW-6076] Fix dag.cli() Key error
URL: https://github.com/apache/airflow/pull/6875#issuecomment-568535748
Nobody complained because it was a very simple alternative - use normal CLI. In addition, this option hadn't documentation, so very few people were aware of this feature. It will not be difficult to fix, and then we should complete the documentation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj edited a comment on issue #6875: [AIRFLOW-6076]
Fix dag.cli() Key error
Posted by GitBox <gi...@apache.org>.
mik-laj edited a comment on issue #6875: [AIRFLOW-6076] Fix dag.cli() Key error
URL: https://github.com/apache/airflow/pull/6875#issuecomment-568573491
We don't need to copy a lot of code. Here is the quick POC that shows it.
https://github.com/mik-laj/incubator-airflow/pull/9/commits/ef4a6e65d39c22521e97ef5a3fc651f07c60c9a9
This also improves the code because huge dictionaries that are difficult to read are not created in one assignment.
This allows you to show DAG using the following command.
```
python airflow/example_dags/example_bash_operator.py show --imgcat
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] KKcorps closed pull request #6875: [AIRFLOW-6076] Fix
dag.cli() Key error
Posted by GitBox <gi...@apache.org>.
KKcorps closed pull request #6875: [AIRFLOW-6076] Fix dag.cli() Key error
URL: https://github.com/apache/airflow/pull/6875
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on issue #6875: [AIRFLOW-6076] Fix
dag.cli() Key error
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #6875: [AIRFLOW-6076] Fix dag.cli() Key error
URL: https://github.com/apache/airflow/pull/6875#issuecomment-568299821
Hi. I don't think we want to delete this feature. However, fixing this feature will be very difficult. From what I've looked at, it's easiest to do another CLI that will contain only a small set of commands. You also asked how you can test these CLIs. Here I attach an example code of test.
```
class TestDagCli(unittest.TestCase):
def test_should_display_list_command(self):
from airflow.example_dags import example_bash_operator
with contextlib.redirect_stdout(io.StringIO()) as temp_stdout, \
mock.patch('sys.argv', [example_bash_operator.__file__, "list_runs"]):
example_bash_operator.dag.cli()
stdout = temp_stdout.getvalue()
self.assertEqual("TODO", stdout)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6875:
[Airflow-6076] Fix dag.cli() Key error
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6875: [Airflow-6076] Fix dag.cli() Key error
URL: https://github.com/apache/airflow/pull/6875#issuecomment-568214414
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=h1) Report
> Merging [#6875](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a6bc4165ff3d3588ec5dc802f411e071adf80cb3?src=pr&el=desc) will **decrease** coverage by `0.28%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6875 +/- ##
==========================================
- Coverage 84.61% 84.33% -0.29%
==========================================
Files 680 680
Lines 38501 38505 +4
==========================================
- Hits 32578 32472 -106
- Misses 5923 6033 +110
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `95.83% <100%> (+0.24%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=footer). Last update [a6bc416...4d8e22a](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6875:
[Airflow-6076] Fix dag.cli() Key error
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6875: [Airflow-6076] Fix dag.cli() Key error
URL: https://github.com/apache/airflow/pull/6875#issuecomment-568214414
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=h1) Report
> Merging [#6875](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a6bc4165ff3d3588ec5dc802f411e071adf80cb3?src=pr&el=desc) will **decrease** coverage by `0.28%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6875 +/- ##
==========================================
- Coverage 84.61% 84.33% -0.29%
==========================================
Files 680 680
Lines 38501 38505 +4
==========================================
- Hits 32578 32472 -106
- Misses 5923 6033 +110
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `95.83% <100%> (+0.24%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=footer). Last update [a6bc416...4d8e22a](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] KKcorps commented on issue #6875: [AIRFLOW-6076] Fix
dag.cli() Key error
Posted by GitBox <gi...@apache.org>.
KKcorps commented on issue #6875: [AIRFLOW-6076] Fix dag.cli() Key error
URL: https://github.com/apache/airflow/pull/6875#issuecomment-582744947
@mik-laj These PR changes are already there in the master. I think I should close it then?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on issue #6875: [AIRFLOW-6076] Fix
dag.cli() Key error
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #6875: [AIRFLOW-6076] Fix dag.cli() Key error
URL: https://github.com/apache/airflow/pull/6875#issuecomment-568535748
Nobody complained because it was a very simple alternative - use normal CLI. In addition, this option had no documentation, so very few people were aware of this feature. It will not be difficult to fix, and then we should complete the documentation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on issue #6875: [AIRFLOW-6076] Fix
dag.cli() Key error
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #6875: [AIRFLOW-6076] Fix dag.cli() Key error
URL: https://github.com/apache/airflow/pull/6875#issuecomment-568573491
We don't need to copy a lot of code. Here is the quick POC that shows it.
https://github.com/mik-laj/incubator-airflow/pull/9/commits/ef4a6e65d39c22521e97ef5a3fc651f07c60c9a9
This allows you to show DAG using the following command.
```
python airflow/example_dags/example_bash_operator.py show --imgcat
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj edited a comment on issue #6875: [AIRFLOW-6076]
Fix dag.cli() Key error
Posted by GitBox <gi...@apache.org>.
mik-laj edited a comment on issue #6875: [AIRFLOW-6076] Fix dag.cli() Key error
URL: https://github.com/apache/airflow/pull/6875#issuecomment-568299821
Hi. I don't think we want to delete this feature. However, fixing this feature will be very difficult. From what I've looked at, it's easiest to do another CLI that will contain only a small set of commands. You also asked how you can test these CLIs. Here I attach an example code of test.
```python
class TestDagCli(unittest.TestCase):
def test_should_display_list_command(self):
from airflow.example_dags import example_bash_operator
with contextlib.redirect_stdout(io.StringIO()) as temp_stdout, \
mock.patch('sys.argv', [example_bash_operator.__file__, "list_runs"]):
example_bash_operator.dag.cli()
stdout = temp_stdout.getvalue()
self.assertEqual("TODO", stdout)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] stale[bot] closed pull request #6875: [AIRFLOW-6076] Fix
dag.cli() Key error
Posted by GitBox <gi...@apache.org>.
stale[bot] closed pull request #6875: [AIRFLOW-6076] Fix dag.cli() Key error
URL: https://github.com/apache/airflow/pull/6875
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #6875: [Airflow-6076] Fix
dag.cli() Key error
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #6875: [Airflow-6076] Fix dag.cli() Key error
URL: https://github.com/apache/airflow/pull/6875#issuecomment-568214414
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=h1) Report
> Merging [#6875](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a6bc4165ff3d3588ec5dc802f411e071adf80cb3?src=pr&el=desc) will **decrease** coverage by `0.28%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6875 +/- ##
==========================================
- Coverage 84.61% 84.33% -0.29%
==========================================
Files 680 680
Lines 38501 38505 +4
==========================================
- Hits 32578 32472 -106
- Misses 5923 6033 +110
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `95.83% <100%> (+0.24%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=footer). Last update [a6bc416...4d8e22a](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on issue #6875: [AIRFLOW-6076] Fix
dag.cli() Key error
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #6875: [AIRFLOW-6076] Fix dag.cli() Key error
URL: https://github.com/apache/airflow/pull/6875#issuecomment-568422651
I imagine that the user will not have to give DAG_ID. Only subsequent command will be available.
In the current code, dag parser is broken and there is no possibility to properly work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj edited a comment on issue #6875: [AIRFLOW-6076]
Fix dag.cli() Key error
Posted by GitBox <gi...@apache.org>.
mik-laj edited a comment on issue #6875: [AIRFLOW-6076] Fix dag.cli() Key error
URL: https://github.com/apache/airflow/pull/6875#issuecomment-568299821
Hi. I don't think we want to delete this feature. However, fixing this feature will be very difficult. From what I've looked at, it's easiest to do another CLI that will contain only a small set of commands. You also asked how you can test these CLI commands. Here I attach an example code of test.
```python
class TestDagCli(unittest.TestCase):
def test_should_display_list_command(self):
from airflow.example_dags import example_bash_operator
with contextlib.redirect_stdout(io.StringIO()) as temp_stdout, \
mock.patch('sys.argv', [example_bash_operator.__file__, "list_runs"]):
example_bash_operator.dag.cli()
stdout = temp_stdout.getvalue()
self.assertEqual("TODO", stdout)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on issue #6875: [AIRFLOW-6076] Fix
dag.cli() Key error
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #6875: [AIRFLOW-6076] Fix dag.cli() Key error
URL: https://github.com/apache/airflow/pull/6875#issuecomment-587051727
`dag.cli()` still doesn't work.
```
16:39 $ python airflow/example_dags/example_complex.py
Traceback (most recent call last):
File "airflow/example_dags/example_complex.py", line 224, in <module>
dag.cli()
File "/Users/kamilbregula/devel/google-airflow/airflow/airflow/models/dag.py", line 1398, in cli
parser = cli.CLIFactory.get_parser(dag_parser=True)
File "/Users/kamilbregula/devel/google-airflow/airflow/airflow/bin/cli.py", line 1057, in get_parser
sub = cls.subparsers_dict[sub]
KeyError: 'backfill'
```
What do you mean by "These PR changes are already there in the master"? CLI is developing very intensively, but all the issues have not yet been resolved.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6875:
[Airflow-6076] Fix dag.cli() Key error
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6875: [Airflow-6076] Fix dag.cli() Key error
URL: https://github.com/apache/airflow/pull/6875#issuecomment-568214414
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=h1) Report
> Merging [#6875](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a6bc4165ff3d3588ec5dc802f411e071adf80cb3?src=pr&el=desc) will **decrease** coverage by `0.28%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6875 +/- ##
==========================================
- Coverage 84.61% 84.33% -0.29%
==========================================
Files 680 680
Lines 38501 38505 +4
==========================================
- Hits 32578 32472 -106
- Misses 5923 6033 +110
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `95.83% <100%> (+0.24%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=footer). Last update [a6bc416...4d8e22a](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6875:
[Airflow-6076] Fix dag.cli() Key error
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6875: [Airflow-6076] Fix dag.cli() Key error
URL: https://github.com/apache/airflow/pull/6875#issuecomment-568214414
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=h1) Report
> Merging [#6875](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a6bc4165ff3d3588ec5dc802f411e071adf80cb3?src=pr&el=desc) will **decrease** coverage by `0.28%`.
> The diff coverage is `50%`.
[](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6875 +/- ##
==========================================
- Coverage 84.61% 84.32% -0.29%
==========================================
Files 680 680
Lines 38501 38499 -2
==========================================
- Hits 32578 32465 -113
- Misses 5923 6034 +111
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/models/dag.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvZGFnLnB5) | `90.95% <0%> (ø)` | :arrow_up: |
| [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `95.45% <100%> (-0.14%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `91.59% <0%> (-0.29%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=footer). Last update [a6bc416...3559560](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on issue #6875: [AIRFLOW-6076] Fix
dag.cli() Key error
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #6875: [AIRFLOW-6076] Fix dag.cli() Key error
URL: https://github.com/apache/airflow/pull/6875#issuecomment-569798017
@KKcorps Can I help you somehow? Do you have other questions?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6875:
[Airflow-6076] Fix dag.cli() Key error
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6875: [Airflow-6076] Fix dag.cli() Key error
URL: https://github.com/apache/airflow/pull/6875#issuecomment-568214414
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=h1) Report
> Merging [#6875](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a6bc4165ff3d3588ec5dc802f411e071adf80cb3?src=pr&el=desc) will **decrease** coverage by `0.28%`.
> The diff coverage is `50%`.
[](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6875 +/- ##
==========================================
- Coverage 84.61% 84.32% -0.29%
==========================================
Files 680 680
Lines 38501 38499 -2
==========================================
- Hits 32578 32465 -113
- Misses 5923 6034 +111
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/models/dag.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvZGFnLnB5) | `90.95% <0%> (ø)` | :arrow_up: |
| [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `95.45% <100%> (-0.14%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `91.59% <0%> (-0.29%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=footer). Last update [a6bc416...3559560](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6875:
[Airflow-6076] Fix dag.cli() Key error
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6875: [Airflow-6076] Fix dag.cli() Key error
URL: https://github.com/apache/airflow/pull/6875#issuecomment-568214414
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=h1) Report
> Merging [#6875](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/6a5a4ef4e435de4c911e9e130d6ff7313f52a37b?src=pr&el=desc) will **decrease** coverage by `0.28%`.
> The diff coverage is `50%`.
[](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6875 +/- ##
==========================================
- Coverage 84.61% 84.32% -0.29%
==========================================
Files 680 680
Lines 38501 38499 -2
==========================================
- Hits 32577 32465 -112
- Misses 5924 6034 +110
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/models/dag.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvZGFnLnB5) | `90.95% <0%> (ø)` | :arrow_up: |
| [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `95.45% <100%> (-0.14%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/utils/dates.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kYXRlcy5weQ==) | `89.36% <0%> (ø)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=footer). Last update [6a5a4ef...3559560](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6875:
[Airflow-6076] Fix dag.cli() Key error
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6875: [Airflow-6076] Fix dag.cli() Key error
URL: https://github.com/apache/airflow/pull/6875#issuecomment-568214414
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=h1) Report
> Merging [#6875](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a6bc4165ff3d3588ec5dc802f411e071adf80cb3?src=pr&el=desc) will **decrease** coverage by `0.28%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6875 +/- ##
==========================================
- Coverage 84.61% 84.33% -0.29%
==========================================
Files 680 680
Lines 38501 38505 +4
==========================================
- Hits 32578 32472 -106
- Misses 5923 6033 +110
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `95.83% <100%> (+0.24%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=footer). Last update [a6bc416...4d8e22a](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6875:
[Airflow-6076] Fix dag.cli() Key error
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6875: [Airflow-6076] Fix dag.cli() Key error
URL: https://github.com/apache/airflow/pull/6875#issuecomment-568214414
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=h1) Report
> Merging [#6875](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a6bc4165ff3d3588ec5dc802f411e071adf80cb3?src=pr&el=desc) will **decrease** coverage by `0.28%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6875 +/- ##
==========================================
- Coverage 84.61% 84.33% -0.29%
==========================================
Files 680 680
Lines 38501 38505 +4
==========================================
- Hits 32578 32472 -106
- Misses 5923 6033 +110
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `95.83% <100%> (+0.24%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=footer). Last update [a6bc416...4d8e22a](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6875:
[Airflow-6076] Fix dag.cli() Key error
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6875: [Airflow-6076] Fix dag.cli() Key error
URL: https://github.com/apache/airflow/pull/6875#issuecomment-568214414
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=h1) Report
> Merging [#6875](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a6bc4165ff3d3588ec5dc802f411e071adf80cb3?src=pr&el=desc) will **decrease** coverage by `0.28%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6875 +/- ##
==========================================
- Coverage 84.61% 84.33% -0.29%
==========================================
Files 680 680
Lines 38501 38505 +4
==========================================
- Hits 32578 32472 -106
- Misses 5923 6033 +110
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `95.83% <100%> (+0.24%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=footer). Last update [a6bc416...4d8e22a](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on a change in pull request #6875:
[AIRFLOW-6076] Fix dag.cli() Key error
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #6875: [AIRFLOW-6076] Fix dag.cli() Key error
URL: https://github.com/apache/airflow/pull/6875#discussion_r362484935
##########
File path: airflow/bin/cli.py
##########
@@ -1028,38 +1025,59 @@ def error(self, message):
help='sub-command help', dest='subcommand')
subparsers.required = True
- subparser_list = cls.dag_subparsers if dag_parser else cls.subparsers_dict.keys()
- for sub in sorted(subparser_list):
- sub = cls.subparsers_dict[sub]
- cls._add_subcommand(subparsers, sub)
+ for sub in sorted(self.subparsers, key=lambda d: d['name']):
+ self._add_subcommand(subparsers, sub)
return parser
- @classmethod
- def _add_subcommand(cls, subparsers, sub):
- dag_parser = False
+ def _add_subcommand(self, subparsers, sub):
sub_proc = subparsers.add_parser(
sub.get('name') or sub['func'].__name__, help=sub['help'] # type: ignore
)
sub_proc.formatter_class = RawTextHelpFormatter
- subcommands = sub.get('subcommands', [])
- if subcommands:
+ if 'subcommands' in sub:
+ subcommands = sub.get('subcommands', [])
Review comment:
Can you create functions from the content of this "if"? This will simplify the understanding of the code, because this function will have one purpose. Do you think function names now have a good name? Maybe it's worth changing the name also?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] nuclearpinguin commented on issue #6875: [AIRFLOW-6076]
Fix dag.cli() Key error
Posted by GitBox <gi...@apache.org>.
nuclearpinguin commented on issue #6875: [AIRFLOW-6076] Fix dag.cli() Key error
URL: https://github.com/apache/airflow/pull/6875#issuecomment-568430866
I think the `dag.cli` is broken for long time now, no one was complaining as far as I know so maybe we can remove it? @ash @kaxil @potiuk
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] KKcorps commented on issue #6875: [AIRFLOW-6076] Fix
dag.cli() Key error
Posted by GitBox <gi...@apache.org>.
KKcorps commented on issue #6875: [AIRFLOW-6076] Fix dag.cli() Key error
URL: https://github.com/apache/airflow/pull/6875#issuecomment-570167608
@mik-laj I have resolved the conflicts. Is there anything else pending in this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on issue #6875: [AIRFLOW-6076] Fix
dag.cli() Key error
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #6875: [AIRFLOW-6076] Fix dag.cli() Key error
URL: https://github.com/apache/airflow/pull/6875#issuecomment-570217435
@KKcorps Can you add some tests to avoid regression? https://github.com/apache/airflow/pull/6875#issuecomment-568299821
Some commands also accept unused dag argument. Now we pass the dag in a different way.
https://github.com/apache/airflow/blob/master/airflow/cli/commands/task_command.py#L137
Can you remove it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6875:
[Airflow-6076] Fix dag.cli() Key error
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6875: [Airflow-6076] Fix dag.cli() Key error
URL: https://github.com/apache/airflow/pull/6875#issuecomment-568214414
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=h1) Report
> Merging [#6875](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/6a5a4ef4e435de4c911e9e130d6ff7313f52a37b?src=pr&el=desc) will **decrease** coverage by `0.28%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6875 +/- ##
==========================================
- Coverage 84.61% 84.33% -0.29%
==========================================
Files 680 680
Lines 38501 38505 +4
==========================================
- Hits 32577 32472 -105
- Misses 5924 6033 +109
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `95.83% <100%> (+0.24%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/utils/dates.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kYXRlcy5weQ==) | `89.36% <0%> (ø)` | :arrow_up: |
| [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/6875/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `91.88% <0%> (+0.28%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=footer). Last update [6a5a4ef...4d8e22a](https://codecov.io/gh/apache/airflow/pull/6875?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] KKcorps opened a new pull request #6875: [AIRFLOW-6076]
Fix dag.cli() Key error
Posted by GitBox <gi...@apache.org>.
KKcorps opened a new pull request #6875: [AIRFLOW-6076] Fix dag.cli() Key error
URL: https://github.com/apache/airflow/pull/6875
Make sure you have checked _all_ steps below.
### Jira
- [X] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-6076
### Description
- [x] Here are some details about my PR, including screenshots of any UI changes:
DAG subcommands are now nested inside the main command. However, the subcommand dictionary contained only the main commands. This resulted in a KeyError when querying for a subcommand from the dict.
### Tests
- [X] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
Tests already exist.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj edited a comment on issue #6875: [AIRFLOW-6076]
Fix dag.cli() Key error
Posted by GitBox <gi...@apache.org>.
mik-laj edited a comment on issue #6875: [AIRFLOW-6076] Fix dag.cli() Key error
URL: https://github.com/apache/airflow/pull/6875#issuecomment-568573491
We don't need to copy a lot of code. Here is the quick POC that shows it.
https://github.com/mik-laj/incubator-airflow/pull/9/commits/ef4a6e65d39c22521e97ef5a3fc651f07c60c9a9
This also improves the code because huge dictionaries that are difficult to read are not created.
This allows you to show DAG using the following command.
```
python airflow/example_dags/example_bash_operator.py show --imgcat
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] KKcorps commented on issue #6875: [AIRFLOW-6076] Fix
dag.cli() Key error
Posted by GitBox <gi...@apache.org>.
KKcorps commented on issue #6875: [AIRFLOW-6076] Fix dag.cli() Key error
URL: https://github.com/apache/airflow/pull/6875#issuecomment-568540838
Accidentally, closed the PR. Reopened it now.
@mik-laj It's not a difficult fix but it will involve some code repetition such as copying the dag subcommands in a separate file and then using the CLI from the new class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services