You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/22 12:02:23 UTC

[GitHub] [airflow] mik-laj commented on a change in pull request #13127: Improve compatibility with google-cloud-pubsub>=2.0.0

mik-laj commented on a change in pull request #13127:
URL: https://github.com/apache/airflow/pull/13127#discussion_r547238996



##########
File path: setup.py
##########
@@ -266,7 +266,7 @@ def write_version(filename: str = os.path.join(*[my_dir, "airflow", "git_version
     'google-cloud-memcache>=0.2.0',
     'google-cloud-monitoring>=0.34.0,<2.0.0',
     'google-cloud-os-login>=2.0.0,<3.0.0',
-    'google-cloud-pubsub>=1.0.0,<2.0.0',
+    'google-cloud-pubsub>=2.0.0,<3.0.0',

Review comment:
       How will it benefit us? In the remaining lines, I have one convention and I think it's worth keeping one style.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org