You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "JingsongLi (via GitHub)" <gi...@apache.org> on 2023/11/16 10:02:59 UTC

Re: [PR] [core] Introduce RawFile public API to indicate files which can be read without merging [incubator-paimon]

JingsongLi commented on code in PR #2319:
URL: https://github.com/apache/incubator-paimon/pull/2319#discussion_r1395448511


##########
paimon-core/src/main/java/org/apache/paimon/table/source/RawFile.java:
##########
@@ -0,0 +1,96 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.paimon.table.source;
+
+import org.apache.paimon.CoreOptions;
+import org.apache.paimon.annotation.Public;
+
+import java.util.Objects;
+
+/**
+ * A data file from the table which can be read directly without merging.
+ *
+ * @since 0.6.0
+ */
+@Public
+public class RawFile {
+
+    private final String path;
+    private final long offset;
+    private final long length;
+    private final CoreOptions.FileFormatType format;

Review Comment:
   just String? It is not so good to expose `CoreOptions.FileFormatType`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org