[jira] [Commented] (DRILL-6952) Merge row set based "compliant" text reader

["Paul Rogers (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DRILL-6952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16872951#comment-16872951 ] 

Paul Rogers commented on DRILL-6952:
------------------------------------

[~angozhiy], thank you for running the tests. Very glad to hear that we've got the issues resolved.

I suspect we do not have complex queries that run using CSV. The new version sends an empty schema batch. I found that some of the "advanced" operators (project, selection vector remover, hash agg, etc.) appear to fail when given an empty batch.

We have another PR open to disable the empty schema batch. Once that PR is merged, would be great to run a few complex queries with joins, aggregates, WHERE-clause, etc. over CSV to make sure we have no other issues in this area.

> Merge row set based "compliant" text reader
> -------------------------------------------
>
>                 Key: DRILL-6952
>                 URL: https://issues.apache.org/jira/browse/DRILL-6952
>             Project: Apache Drill
>          Issue Type: Improvement
>    Affects Versions: 1.15.0
>            Reporter: Paul Rogers
>            Assignee: Paul Rogers
>            Priority: Major
>              Labels: ready-to-commit
>             Fix For: 1.16.0
>
>
> The result set loader project created a revised version of the compliant text reader that uses the result set loader framework (which includes the schema-based projection framework.)
> This task merges that work into master:
> * Review the history of the complaint text reader for changes made in the last year since the code was written.
> * Apply those changes to the row set-based code, as necessary.
> * Issue a PR for the new version of the compliant text reader
> * Work through any test issues that crop up in the pre-commit tests.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)