[GitHub] [spark] cloud-fan commented on a diff in pull request #37462: [SPARK-40028][SQL][FollowUp] Improve examples of string functions

[GitBox <gi...@apache.org>]

cloud-fan commented on code in PR #37462:
URL: https://github.com/apache/spark/pull/37462#discussion_r942511381


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala:
##########
@@ -250,8 +250,8 @@ case class ConcatWs(children: Seq[Expression])
     Examples:
       > SELECT _FUNC_(1, 'scala', 'java');
        scala
-      > SELECT _FUNC_(1, encode('scala', 'utf-8'), encode('java', 'utf-8'));
-       scala
+      > SELECT _FUNC_(2, 'a', 1);

Review Comment:
   does this example involve type coercion?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org