You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2022/07/28 18:01:40 UTC

[GitHub] [trafficcontrol] ocket8888 opened a new pull request, #6989: Convert Delivery Services table to use "common" grid controller

ocket8888 opened a new pull request, #6989:
URL: https://github.com/apache/trafficcontrol/pull/6989

   This converts the Delivery Services table from using a copy/pasted AG-Grid implementation to using an embedded "common" grid controller.
   
   I also fixed an issue where tables that set the title directly instead of using breadcrumbs had no title.
   
   <hr/>
   
   ## Which Traffic Control components are affected by this PR?
   - Traffic Portal
   
   ## What is the best way to verify this PR?
   The functionality should be fully replicated, so just make sure the existing tests still pass.
   
   ## PR submission checklist
   - [x] This PR uses the existing tests
   - [x] This PR doesn't need documentation
   - [x] This PR doesn't need a CHANGELOG.md entry
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY**


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] shamrickus commented on pull request #6989: Convert Delivery Services table to use "common" grid controller

Posted by GitBox <gi...@apache.org>.
shamrickus commented on PR #6989:
URL: https://github.com/apache/trafficcontrol/pull/6989#issuecomment-1211096917

   This broke several tables that extended The `TableDeliveryServiceController` such as server delivery serviecs, cdn delivery services, tenant delivery services, and several others. Not really sure how the tests are passing 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] shamrickus merged pull request #6989: Convert Delivery Services table to use "common" grid controller

Posted by GitBox <gi...@apache.org>.
shamrickus merged PR #6989:
URL: https://github.com/apache/trafficcontrol/pull/6989


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org