[jira] [Commented] (OFBIZ-9504) [FB] Package org.apache.ofbiz.accounting.finaccount

["Pranay Pandey (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-9504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16096126#comment-16096126 ] 

Pranay Pandey commented on OFBIZ-9504:
--------------------------------------

Hello Kyra Pritzel-Hentley,

Thanks for reporting the issue. Please put a clear summary of the issue in ticket summary and provide steps to regenerate the issue in the description. Both of these details are very important in tracking down the issue. It's also required even if you are going to provide a patch for fixing the reported issue.

It's recommended study for every OFBiz contributor - https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Contributors+Best+Practices#OFBizContributorsBestPractices-HowtoContributetoOFBiz

Thanks!

> [FB] Package org.apache.ofbiz.accounting.finaccount
> ---------------------------------------------------
>
>                 Key: OFBIZ-9504
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9504
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>    Affects Versions: Trunk
>            Reporter: Kyra Pritzel-Hentley
>            Priority: Minor
>
> FinAccountPaymentServices.java:72, RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE
> * RCN: Nullcheck of paymentPref at line 72 of value previously dereferenced in org.apache.ofbiz.accounting.finaccount.FinAccountPaymentServices.finAccountPreAuth(DispatchContext, Map)
> A value is checked here to see whether it is null, but this value can't be null because it was previously dereferenced and if it were null a null pointer exception would have occurred at the earlier dereference. Essentially, this code and the previous dereference disagree as to whether this value is allowed to be null. Either the check is redundant or the previous dereference is erroneous.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)