You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "harshithasudhakar (via GitHub)" <gi...@apache.org> on 2023/04/05 10:15:59 UTC

[GitHub] [eventmesh] harshithasudhakar opened a new pull request, #3632: [ISSUE#3402]"getExtension()" can return null.[Trace]

harshithasudhakar opened a new pull request, #3632:
URL: https://github.com/apache/eventmesh/pull/3632

   Fixes #3402 
   
   ### Motivation
   
   Using requireNonNull() to check incoming references, can control the point in time when the exception will be thrown.
   
   ### Modifications
   
   Included "Object.requireNonNull()"
   
   ### Documentation
   
   - Does this pull request introduce a new feature? (yes / no)
    No
   - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
    No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org

[GitHub] [eventmesh] Alonexc commented on a diff in pull request #3632: [ISSUE #3402]"getExtension()" can return null.[Trace]

Posted by "Alonexc (via GitHub)" <gi...@apache.org>.
Alonexc commented on code in PR #3632:
URL: https://github.com/apache/eventmesh/pull/3632#discussion_r1162215484


##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/trace/Trace.java:
##########
@@ -140,7 +141,7 @@ public Span addTraceInfoToSpan(Span span, CloudEvent cloudEvent) {
         }
 
         for (String entry : cloudEvent.getExtensionNames()) {
-            span.setAttribute(entry, cloudEvent.getExtension(entry) == null ? "" : cloudEvent.getExtension(entry).toString());
+            span.setAttribute(entry, cloudEvent.getExtension(entry) == null ? "" : Object.requireNonNull(cloudEvent.getExtension(entry)).toString());

Review Comment:
   is Objects.requireNonNull, not Object.requireNonNull.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org

[GitHub] [eventmesh] harshithasudhakar commented on pull request #3632: [ISSUE #3402]"getExtension()" can return null.[Trace]

Posted by "harshithasudhakar (via GitHub)" <gi...@apache.org>.
harshithasudhakar commented on PR #3632:
URL: https://github.com/apache/eventmesh/pull/3632#issuecomment-1499288368

   > Hi @harshithasudhakar CI not pass, Please check it
   
   I have rectified the issue now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org

[GitHub] [eventmesh] pandaapo commented on a diff in pull request #3632: [ISSUE #3402]"getExtension()" can return null.[Trace]

Posted by "pandaapo (via GitHub)" <gi...@apache.org>.
pandaapo commented on code in PR #3632:
URL: https://github.com/apache/eventmesh/pull/3632#discussion_r1199499713


##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/trace/Trace.java:
##########
@@ -140,7 +141,7 @@ public Span addTraceInfoToSpan(Span span, CloudEvent cloudEvent) {
         }
 
         for (String entry : cloudEvent.getExtensionNames()) {
-            span.setAttribute(entry, cloudEvent.getExtension(entry) == null ? "" : cloudEvent.getExtension(entry).toString());
+            span.setAttribute(entry, cloudEvent.getExtension(entry) != null ? cloudEvent.getExtension(entry).toString() : "");
         }

Review Comment:
   Now you see there is no problem with the original code here. The other one is in the same situation. 
   In conclusion, this issue should not be posted. So let's wait the maintainer to make the final decision.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org

Re: [PR] [ISSUE #3402]"getExtension()" can return null.[Trace] (eventmesh)

Posted by "scwlkq (via GitHub)" <gi...@apache.org>.
scwlkq commented on PR #3632:
URL: https://github.com/apache/eventmesh/pull/3632#issuecomment-1774129235

   @pandaapo 你好👋 我想找一些初级的issue但是看这个貌似已经解决了但是没有关闭，这里还有其他直接commit的点吗？
   
   hello 👋 I am looking for some beginner issues, but it seems that they have been resolved but not closed. Are there any other direct commit points here?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org

[GitHub] [eventmesh] Alonexc commented on a diff in pull request #3632: [ISSUE #3402]"getExtension()" can return null.[Trace]

Posted by "Alonexc (via GitHub)" <gi...@apache.org>.
Alonexc commented on code in PR #3632:
URL: https://github.com/apache/eventmesh/pull/3632#discussion_r1162215400


##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/trace/Trace.java:
##########
@@ -120,7 +121,7 @@ public Span addTraceInfoToSpan(ChannelHandlerContext ctx, CloudEvent cloudEvent)
 
         //add trace info
         for (String entry : cloudEvent.getExtensionNames()) {
-            span.setAttribute(entry, cloudEvent.getExtension(entry) == null ? "" : cloudEvent.getExtension(entry).toString());
+            span.setAttribute(entry, cloudEvent.getExtension(entry) == null ? "" : Object.requireNonNull(cloudEvent.getExtension(entry)).toString());

Review Comment:
   is Objects.requireNonNull, not Object.requireNonNull.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org

Re: [PR] [ISSUE #3402]"getExtension()" can return null.[Trace] (eventmesh)

Posted by "Pil0tXia (via GitHub)" <gi...@apache.org>.
Pil0tXia commented on PR #3632:
URL: https://github.com/apache/eventmesh/pull/3632#issuecomment-1883123010

   Any progress can be made in this PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org

Re: [PR] [ISSUE #3402]"getExtension()" can return null.[Trace] (eventmesh)

Posted by "Pil0tXia (via GitHub)" <gi...@apache.org>.
Pil0tXia commented on PR #3632:
URL: https://github.com/apache/eventmesh/pull/3632#issuecomment-1776816518

   > What is the significance of these modifications in this PR? @mxsm
   
   @pandaapo In your screenshots, it seems little changes have been made indeed.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org

Re: [PR] [ISSUE #3402]"getExtension()" can return null.[Trace] (eventmesh)

Posted by "mxsm (via GitHub)" <gi...@apache.org>.
mxsm commented on PR #3632:
URL: https://github.com/apache/eventmesh/pull/3632#issuecomment-1774130081

   > @pandaapo 你好👋 我想找一些初级的issue但是看这个貌似已经解决了但是没有关闭，这里还有其他直接commit的点吗？
   > 
   > hello 👋 I am looking for some beginner issues, but it seems that they have been resolved but not closed. Are there any other direct commit points here?
   
   @scwlkq Hi you can try this issue #4502 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org

[GitHub] [eventmesh] pandaapo commented on a diff in pull request #3632: [ISSUE #3402]"getExtension()" can return null.[Trace]

Posted by "pandaapo (via GitHub)" <gi...@apache.org>.
pandaapo commented on code in PR #3632:
URL: https://github.com/apache/eventmesh/pull/3632#discussion_r1199498107


##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/trace/Trace.java:
##########
@@ -140,7 +141,7 @@ public Span addTraceInfoToSpan(Span span, CloudEvent cloudEvent) {
         }
 
         for (String entry : cloudEvent.getExtensionNames()) {
-            span.setAttribute(entry, cloudEvent.getExtension(entry) == null ? "" : cloudEvent.getExtension(entry).toString());
+            span.setAttribute(entry, cloudEvent.getExtension(entry) != null ? cloudEvent.getExtension(entry).toString() : "");
         }

Review Comment:
   It is OK now. The other one has the same problem. 
   But in fact, this issue should not be posted as there is no problem in the original code here. So let's wait the maintainer to make the final decision.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org

[GitHub] [eventmesh] xwm1992 commented on a diff in pull request #3632: [ISSUE #3402]"getExtension()" can return null.[Trace]

Posted by "xwm1992 (via GitHub)" <gi...@apache.org>.
xwm1992 commented on code in PR #3632:
URL: https://github.com/apache/eventmesh/pull/3632#discussion_r1159222217


##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/trace/Trace.java:
##########
@@ -140,7 +140,7 @@ public Span addTraceInfoToSpan(Span span, CloudEvent cloudEvent) {
         }
 
         for (String entry : cloudEvent.getExtensionNames()) {
-            span.setAttribute(entry, cloudEvent.getExtension(entry) == null ? "" : cloudEvent.getExtension(entry).toString());
+            span.setAttribute(entry, cloudEvent.getExtension(entry) == null ? "" : Object.requireNonNull(cloudEvent.getExtension(entry)).toString());

Review Comment:
   same as above



##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/trace/Trace.java:
##########
@@ -120,7 +120,7 @@ public Span addTraceInfoToSpan(ChannelHandlerContext ctx, CloudEvent cloudEvent)
 
         //add trace info
         for (String entry : cloudEvent.getExtensionNames()) {
-            span.setAttribute(entry, cloudEvent.getExtension(entry) == null ? "" : cloudEvent.getExtension(entry).toString());
+            span.setAttribute(entry, cloudEvent.getExtension(entry) == null ? "" : Object.requireNonNull(cloudEvent.getExtension(entry)).toString());

Review Comment:
   this dependent on `java.util.Objects` please import, and change it to `Objects.requireNonNull`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org

Re: [PR] [ISSUE #3402]"getExtension()" can return null.[Trace] (eventmesh)

Posted by "pandaapo (via GitHub)" <gi...@apache.org>.
pandaapo commented on PR #3632:
URL: https://github.com/apache/eventmesh/pull/3632#issuecomment-1774396240

   https://github.com/apache/eventmesh/pull/3632#pullrequestreview-1434053124
   ![捕获](https://github.com/apache/eventmesh/assets/35672972/9b8e1c66-1e12-4c81-ab96-cb19ab6f8dfe)
   
   https://github.com/apache/eventmesh/pull/3632#discussion_r1199499713
   ![捕获](https://github.com/apache/eventmesh/assets/35672972/b4c777c9-6f01-4fd2-a0ac-6ee6439b7c3e)
   
   What is the significance of these modifications in this PR? @mxsm 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org

[GitHub] [eventmesh] Alonexc commented on a diff in pull request #3632: [ISSUE #3402]"getExtension()" can return null.[Trace]

Posted by "Alonexc (via GitHub)" <gi...@apache.org>.
Alonexc commented on code in PR #3632:
URL: https://github.com/apache/eventmesh/pull/3632#discussion_r1162215400


##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/trace/Trace.java:
##########
@@ -120,7 +121,7 @@ public Span addTraceInfoToSpan(ChannelHandlerContext ctx, CloudEvent cloudEvent)
 
         //add trace info
         for (String entry : cloudEvent.getExtensionNames()) {
-            span.setAttribute(entry, cloudEvent.getExtension(entry) == null ? "" : cloudEvent.getExtension(entry).toString());
+            span.setAttribute(entry, cloudEvent.getExtension(entry) == null ? "" : Object.requireNonNull(cloudEvent.getExtension(entry)).toString());

Review Comment:
   is Objects.requireNonNull(), not Object.requireNonNull().



##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/trace/Trace.java:
##########
@@ -140,7 +141,7 @@ public Span addTraceInfoToSpan(Span span, CloudEvent cloudEvent) {
         }
 
         for (String entry : cloudEvent.getExtensionNames()) {
-            span.setAttribute(entry, cloudEvent.getExtension(entry) == null ? "" : cloudEvent.getExtension(entry).toString());
+            span.setAttribute(entry, cloudEvent.getExtension(entry) == null ? "" : Object.requireNonNull(cloudEvent.getExtension(entry)).toString());

Review Comment:
   is Objects.requireNonNull(), not Object.requireNonNull().



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org

[GitHub] [eventmesh] Alonexc commented on a diff in pull request #3632: [ISSUE #3402]"getExtension()" can return null.[Trace]

Posted by "Alonexc (via GitHub)" <gi...@apache.org>.
Alonexc commented on code in PR #3632:
URL: https://github.com/apache/eventmesh/pull/3632#discussion_r1166228912


##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/trace/Trace.java:
##########
@@ -24,6 +24,7 @@
 import java.util.Map;
 import java.util.concurrent.TimeUnit;
 import java.util.concurrent.atomic.AtomicBoolean;
+import java.util.Objects;

Review Comment:
   This import is not in the right order and will result in checkstyle not passing:
   ![image](https://user-images.githubusercontent.com/91315508/231930110-a9b717e4-d942-412c-ac12-b1cfdb29ad8f.png)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org

[GitHub] [eventmesh] pandaapo commented on a diff in pull request #3632: [ISSUE #3402]"getExtension()" can return null.[Trace]

Posted by "pandaapo (via GitHub)" <gi...@apache.org>.
pandaapo commented on code in PR #3632:
URL: https://github.com/apache/eventmesh/pull/3632#discussion_r1198716351


##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/trace/Trace.java:
##########
@@ -120,7 +121,7 @@ public Span addTraceInfoToSpan(ChannelHandlerContext ctx, CloudEvent cloudEvent)
 
         //add trace info
         for (String entry : cloudEvent.getExtensionNames()) {
-            span.setAttribute(entry, cloudEvent.getExtension(entry) == null ? "" : cloudEvent.getExtension(entry).toString());
+            span.setAttribute(entry, cloudEvent.getExtension(entry) == null ? "" : Objects.requireNonNull(cloudEvent.getExtension(entry)).toString());

Review Comment:
   The judgment of ternary operation ensures that 'cloudEvent. getExtension (entry)' cannot return null here. `Objects.requireNonNull()` is redundant.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org

Re: [PR] [ISSUE #3402]"getExtension()" can return null.[Trace] (eventmesh)

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3632:
URL: https://github.com/apache/eventmesh/pull/3632#issuecomment-1774168037

   ## [Codecov](https://app.codecov.io/gh/apache/eventmesh/pull/3632?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   > Merging [#3632](https://app.codecov.io/gh/apache/eventmesh/pull/3632?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (97c99de) into [master](https://app.codecov.io/gh/apache/eventmesh/commit/d3f688dd09d51e4dee275cae1d334f4c6138ae59?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (d3f688d) will **decrease** coverage by `0.02%`.
   > The diff coverage is `0.00%`.
   
   > :exclamation: Current head 97c99de differs from pull request most recent head ab4d13a. Consider uploading reports for the commit ab4d13a to get more accurate results
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #3632      +/-   ##
   ============================================
   - Coverage     15.47%   15.45%   -0.02%     
     Complexity     1452     1452              
   ============================================
     Files           691      691              
     Lines         28106    28107       +1     
     Branches       2626     2627       +1     
   ============================================
   - Hits           4349     4345       -4     
   - Misses        23312    23315       +3     
   - Partials        445      447       +2     
   ```
   
   
   | [Files](https://app.codecov.io/gh/apache/eventmesh/pull/3632?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...java/org/apache/eventmesh/runtime/trace/Trace.java](https://app.codecov.io/gh/apache/eventmesh/pull/3632?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL3RyYWNlL1RyYWNlLmphdmE=) | `0.00% <0.00%> (ø)` | |
   
   ... and [8 files with indirect coverage changes](https://app.codecov.io/gh/apache/eventmesh/pull/3632/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org

Re: [PR] [ISSUE #3402]"getExtension()" can return null.[Trace] (eventmesh)

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #3632:
URL: https://github.com/apache/eventmesh/pull/3632#issuecomment-2070570511

   ## [Codecov](https://app.codecov.io/gh/apache/eventmesh/pull/3632?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   Attention: Patch coverage is `0%` with `8 lines` in your changes are missing coverage. Please review.
   > Project coverage is 15.47%. Comparing base [(`d3f688d`)](https://app.codecov.io/gh/apache/eventmesh/commit/d3f688dd09d51e4dee275cae1d334f4c6138ae59?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`97c99de`)](https://app.codecov.io/gh/apache/eventmesh/pull/3632?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   > Report is 146 commits behind head on master.
   
   > :exclamation: Current head 97c99de differs from pull request most recent head ab4d13a. Consider uploading reports for the commit ab4d13a to get more accurate results
   
   | [Files](https://app.codecov.io/gh/apache/eventmesh/pull/3632?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...java/org/apache/eventmesh/runtime/trace/Trace.java](https://app.codecov.io/gh/apache/eventmesh/pull/3632?src=pr&el=tree&filepath=eventmesh-runtime%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Feventmesh%2Fruntime%2Ftrace%2FTrace.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL3RyYWNlL1RyYWNlLmphdmE=) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/eventmesh/pull/3632?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #3632      +/-   ##
   ============================================
   - Coverage     15.47%   15.47%   -0.01%     
     Complexity     1452     1452              
   ============================================
     Files           691      691              
     Lines         28106    28112       +6     
     Branches       2626     2629       +3     
   ============================================
     Hits           4349     4349              
   - Misses        23312    23318       +6     
     Partials        445      445              
   ```
   
   
   
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/eventmesh/pull/3632?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org

Re: [PR] [ISSUE #3402]"getExtension()" can return null.[Trace] (eventmesh)

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #3632:
URL: https://github.com/apache/eventmesh/pull/3632#issuecomment-2070569978

   It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback.
   
   If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org