You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2018/08/24 20:54:40 UTC
[kudu-CR] [build] Fix build jar verification
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11318
Change subject: [build] Fix build jar verification
......................................................................
[build] Fix build jar verification
- Adjusts the verify_jars.pl script to ignore jars in
build/jars path. This is where all the dependency jars
are staged for dist-tests. They are not included in the
distribution.
- Shades gson and scopt in kudu-backup and adjusts
verify_jars.pl to allow it to be relocated when shading.
- Adjust the kudu-backup pom to relocate the
needed classes.
Change-Id: Ib3789b6ec379bf715499d1142576218ed7344258
---
M build-support/verify_jars.pl
M java/gradle/shadow.gradle
M java/kudu-backup/pom.xml
3 files changed, 46 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/18/11318/1
--
To view, visit http://gerrit.cloudera.org:8080/11318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib3789b6ec379bf715499d1142576218ed7344258
Gerrit-Change-Number: 11318
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [build] Fix build jar verification
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11318 )
Change subject: [build] Fix build jar verification
......................................................................
[build] Fix build jar verification
- Adjusts the verify_jars.pl script to ignore jars in
build/jars path. This is where all the dependency jars
are staged for dist-tests. They are not included in the
distribution.
- Shades gson and scopt in kudu-backup and adjusts
verify_jars.pl to allow it to be relocated when shading.
- Adjust the kudu-backup pom to relocate the
needed classes.
Change-Id: Ib3789b6ec379bf715499d1142576218ed7344258
Reviewed-on: http://gerrit.cloudera.org:8080/11318
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Grant Henke <gr...@apache.org>
---
M build-support/verify_jars.pl
M java/gradle/shadow.gradle
M java/kudu-backup/pom.xml
3 files changed, 46 insertions(+), 4 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Grant Henke: Verified
--
To view, visit http://gerrit.cloudera.org:8080/11318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib3789b6ec379bf715499d1142576218ed7344258
Gerrit-Change-Number: 11318
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] [build] Fix build jar verification
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11318 )
Change subject: [build] Fix build jar verification
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/11318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib3789b6ec379bf715499d1142576218ed7344258
Gerrit-Change-Number: 11318
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Sat, 25 Aug 2018 02:33:17 +0000
Gerrit-HasComments: No
[kudu-CR] [build] Fix build jar verification
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11318 )
Change subject: [build] Fix build jar verification
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib3789b6ec379bf715499d1142576218ed7344258
Gerrit-Change-Number: 11318
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Fri, 24 Aug 2018 21:16:26 +0000
Gerrit-HasComments: No
[kudu-CR] [build] Fix build jar verification
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has removed a vote on this change.
Change subject: [build] Fix build jar verification
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/11318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ib3789b6ec379bf715499d1142576218ed7344258
Gerrit-Change-Number: 11318
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>