You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "Ilan Ginzburg (Jira)" <ji...@apache.org> on 2021/02/02 18:17:00 UTC
[jira] [Comment Edited] (SOLR-15122)
ClusterEventProducerTest.testEvents is unstable
[ https://issues.apache.org/jira/browse/SOLR-15122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17277360#comment-17277360 ]
Ilan Ginzburg edited comment on SOLR-15122 at 2/2/21, 6:16 PM:
---------------------------------------------------------------
??We shouldn't use postfix increment with a volatile variable, as that is not an atomic operation??
I wouldn't make this a blanket statement. One reason to use a volatile is to conform to the Java Memory Model and not require synchronization for access from different threads. In some cases atomocity is not needed.
Also, using an AtomicInteger and using it only from within a synchronized section seems a bit overkill. Any Integer would do (or even an integer if the mutex block is using another object).
was (Author: murblanc):
??We shouldn't use postfix increment with a volatile variable, as that is not an atomic operation??
I wouldn't make this a blanket statement. One reason to use a volatile if to conform to the Java Memory Model and not require synchronization for access from different threads. In some cases atomocity is not needed.
Also, using an AtomicInteger and using it only from within a synchronized section seems a bit overkill. Any Integer would do (or even an integer if the mutex block is using another object).
> ClusterEventProducerTest.testEvents is unstable
> -----------------------------------------------
>
> Key: SOLR-15122
> URL: https://issues.apache.org/jira/browse/SOLR-15122
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Tests
> Reporter: Mike Drob
> Assignee: Andrzej Bialecki
> Priority: Major
> Fix For: master (9.0)
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> This test looks to be unstable according to Jenkins since about Nov 5. I just started seeing occasional failures locally when running the whole suite but cannot reproduce when running in isolation.
> https://lists.apache.org/thread.html/rf0c16b257bc3236ea414be51451806352b55f15d4949f4fd54a3b71a%40%3Cbuilds.lucene.apache.org%3E
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org