You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/06/04 10:03:20 UTC

[GitHub] [druid] FrankChen021 commented on a change in pull request #11307: Add an option to enable bitmap in IncrementalIndex during real time ingestion

FrankChen021 commented on a change in pull request #11307:
URL: https://github.com/apache/druid/pull/11307#discussion_r645451553



##########
File path: processing/src/main/java/org/apache/druid/segment/QueryableIndexStorageAdapter.java
##########
@@ -270,7 +270,8 @@ public VectorCursor makeVectorCursor(
       VirtualColumns virtualColumns,
       Granularity gran,
       boolean descending,
-      @Nullable QueryMetrics<?> queryMetrics
+      @Nullable QueryMetrics<?> queryMetrics,
+      boolean useInMemoryBitmapInQuery

Review comment:
       `useInMemoryBitmapInQuery` is not used inside this function. Is this the final version ? This new parameter introduces lots of changes in other files.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org