[GitHub] [hudi] hechao-ustc commented on a diff in pull request #7499: [HUDI-5413] Add record count payload to support pv/uv

[GitBox <gi...@apache.org>]

hechao-ustc commented on code in PR #7499:
URL: https://github.com/apache/hudi/pull/7499#discussion_r1052834597


##########
hudi-common/src/main/java/org/apache/hudi/common/model/OverwriteWithLatestAvroPayload.java:
##########
@@ -90,4 +94,35 @@ public Boolean overwriteField(Object value, Object defaultValue) {
   public Comparable<?> getOrderingValue() {
     return this.orderingVal;
   }
+
+  /**
+   * Returns whether the given record is newer than the record of this payload.
+   *
+   * @param orderingVal
+   * @param record The record
+   * @param prop   The payload properties
+   *
+   * @return true if the given record is newer
+   */
+  protected static boolean isRecordNewer(Comparable orderingVal, IndexedRecord record, Properties prop) {

Review Comment:
   don't need it, I have already removed it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org