You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/01/24 02:02:32 UTC

[GitHub] [spark] weixiuli opened a new pull request #35297: [SPARK-37993][SHUFFLE] Avoid multiple calls to configuration parameter values.

weixiuli opened a new pull request #35297:
URL: https://github.com/apache/spark/pull/35297


   
   ### What changes were proposed in this pull request?
   Avoid multiple calls to configuration parameter values.
   
   ### Why are the changes needed?
   Improve performance.
   
   ### Does this PR introduce _any_ user-facing change?
   No.
   
   
   ### How was this patch tested?
   Existed UT.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] srowen commented on pull request #35297: [SPARK-37993][SHUFFLE] Avoid multiple calls to configuration parameter values.

Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #35297:
URL: https://github.com/apache/spark/pull/35297#issuecomment-1032143681


   If you have a case that this increases perf a tiny bit, are there other similar changes that would benefit?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] srowen commented on pull request #35297: [SPARK-37993][SHUFFLE] Avoid multiple calls to configuration parameter values.

Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #35297:
URL: https://github.com/apache/spark/pull/35297#issuecomment-1032678927


   I don't think this is worth it, just too small


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #35297: [SPARK-37993][SHUFFLE] Avoid multiple calls to configuration parameter values.

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #35297:
URL: https://github.com/apache/spark/pull/35297#issuecomment-1019657037


   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] weixiuli commented on pull request #35297: [SPARK-37993][SHUFFLE] Avoid multiple calls to configuration parameter values.

Posted by GitBox <gi...@apache.org>.
weixiuli commented on pull request #35297:
URL: https://github.com/apache/spark/pull/35297#issuecomment-1032167938


   @srowen Thanks. It may not benefit performance enough, but it can make the code cleaner.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] weixiuli commented on pull request #35297: [SPARK-37993][SHUFFLE] Avoid multiple calls to configuration parameter values.

Posted by GitBox <gi...@apache.org>.
weixiuli commented on pull request #35297:
URL: https://github.com/apache/spark/pull/35297#issuecomment-1032127317


   Friendly ping @srowen 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] srowen commented on pull request #35297: [SPARK-37993][SHUFFLE] Avoid multiple calls to configuration parameter values.

Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #35297:
URL: https://github.com/apache/spark/pull/35297#issuecomment-1032142874


   Simple enough, but can this make a difference to perf?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] srowen closed pull request #35297: [SPARK-37993][SHUFFLE] Avoid multiple calls to configuration parameter values.

Posted by GitBox <gi...@apache.org>.
srowen closed pull request #35297:
URL: https://github.com/apache/spark/pull/35297


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org