You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@arrow.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/01/17 12:54:00 UTC

[jira] [Updated] (ARROW-15316) [R] Make a one-function pointer function

     [ https://issues.apache.org/jira/browse/ARROW-15316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

ASF GitHub Bot updated ARROW-15316:
-----------------------------------
    Labels: pull-request-available  (was: )

> [R] Make a one-function pointer function
> ----------------------------------------
>
>                 Key: ARROW-15316
>                 URL: https://issues.apache.org/jira/browse/ARROW-15316
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: R
>            Reporter: Jonathan Keane
>            Assignee: Dragoș Moldovan-Grünfeld
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> In ARROW-15173 [PR|https://github.com/apache/arrow/pull/12062/files] we added backwards compatibly to pointers between R and Python where we use `external_pointer_addr_double()` with old python versions. We could take a number of the blocks like:
> {code}
>  if (pyarrow_version() >= pyarrow_version_pointers_changed) {
>     x$`_export_to_c`(schema_ptr)
>   } else {
>     x$`_export_to_c`(external_pointer_addr_double(schema_ptr))
>   }
> {code}
> to 
> {code}
> x$`_export_to_c`(backwards_compatible_pointer(schema_ptr))
> {code}
> with {{backwards_compatible_pointer}} including the if/else



--
This message was sent by Atlassian Jira
(v8.20.1#820001)