You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@amoro.apache.org by "zhongqishang (via GitHub)" <gi...@apache.org> on 2025/07/18 09:09:32 UTC
[PR] [Hotfix] Replace Jersey Guava imports with Amoro shaded Guava [amoro]
zhongqishang opened a new pull request, #3674:
URL: https://github.com/apache/amoro/pull/3674
## Why are the changes needed?
Close #xxx.
## Brief change log
- Replace Jersey Guava imports with Amoro shaded Guava
- Add checkstyle rule
## How was this patch tested?
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [x] Run test locally before making a pull request
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Hotfix] Replace Jersey Guava imports with Amoro shaded Guava [amoro]
Posted by "zhoujinsong (via GitHub)" <gi...@apache.org>.
zhoujinsong commented on PR #3674:
URL: https://github.com/apache/amoro/pull/3674#issuecomment-3101368879
Thanks for the contribution! @zhongqishang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Hotfix] Replace Jersey Guava imports with Amoro shaded Guava [amoro]
Posted by "zhongqishang (via GitHub)" <gi...@apache.org>.
zhongqishang commented on code in PR #3674:
URL: https://github.com/apache/amoro/pull/3674#discussion_r2218613232
##########
tools/maven/checkstyle.xml:
##########
@@ -120,6 +120,11 @@ This file is based on the checkstyle file of Apache Beam.
<message key="import.illegal" value="{0}; Use amoro shaded guava instead."/>
</module>
+ <module name="IllegalImport">
Review Comment:
This package may have been imported accidentally. I think `IllegalImport` is enough.
Of course, `Regex` can better detect the error introduction in the code.
If need to check for incorrect references in code, it is best to use `Regex`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Hotfix] Replace Jersey Guava imports with Amoro shaded Guava [amoro]
Posted by "klion26 (via GitHub)" <gi...@apache.org>.
klion26 commented on code in PR #3674:
URL: https://github.com/apache/amoro/pull/3674#discussion_r2218461855
##########
tools/maven/checkstyle.xml:
##########
@@ -120,6 +120,11 @@ This file is based on the checkstyle file of Apache Beam.
<message key="import.illegal" value="{0}; Use amoro shaded guava instead."/>
</module>
+ <module name="IllegalImport">
Review Comment:
Not sure if we need to update this with `Regex` property on?
https://checkstyle.sourceforge.io/checks/imports/illegalimport.html#Properties
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Hotfix] Replace Jersey Guava imports with Amoro shaded Guava [amoro]
Posted by "zhoujinsong (via GitHub)" <gi...@apache.org>.
zhoujinsong merged PR #3674:
URL: https://github.com/apache/amoro/pull/3674
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org