You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jmeter-dev@jakarta.apache.org by se...@apache.org on 2006/05/18 23:53:19 UTC
svn commit: r407640 -
/jakarta/jmeter/branches/rel-2-1/src/core/org/apache/jmeter/engine/util/DisabledComponentRemover.java
Author: sebb
Date: Thu May 18 14:53:18 2006
New Revision: 407640
URL: http://svn.apache.org/viewvc?rev=407640&view=rev
Log:
Is this class still needed?
Modified:
jakarta/jmeter/branches/rel-2-1/src/core/org/apache/jmeter/engine/util/DisabledComponentRemover.java
Modified: jakarta/jmeter/branches/rel-2-1/src/core/org/apache/jmeter/engine/util/DisabledComponentRemover.java
URL: http://svn.apache.org/viewvc/jakarta/jmeter/branches/rel-2-1/src/core/org/apache/jmeter/engine/util/DisabledComponentRemover.java?rev=407640&r1=407639&r2=407640&view=diff
==============================================================================
--- jakarta/jmeter/branches/rel-2-1/src/core/org/apache/jmeter/engine/util/DisabledComponentRemover.java (original)
+++ jakarta/jmeter/branches/rel-2-1/src/core/org/apache/jmeter/engine/util/DisabledComponentRemover.java Thu May 18 14:53:18 2006
@@ -1,4 +1,3 @@
-// $Header$
/*
* Copyright 2003-2004 The Apache Software Foundation.
*
@@ -30,7 +29,14 @@
* @version $Revision$
*/
public class DisabledComponentRemover implements HashTreeTraverser {
-
+
+ /*
+ * TODO - does this class work? and is it needed?
+ * It is only called by Start, and then only after
+ * having called convertTree - which removes the disabled elements anyway.
+ * When tried in IncludeController, it failed to work.
+ */
+
private static final Logger log = LoggingManager.getLoggerForClass();
HashTree tree;
@@ -53,6 +59,7 @@
}
TestElement lastNode = (TestElement) removeLast;
if (!lastNode.getPropertyAsBoolean(TestElement.ENABLED)) {
+ log.info("*** Removing *** "+lastNode);// TODO not sure this is ever called
tree.getTree(stack).remove(lastNode);
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org