You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/07/28 15:38:23 UTC
[GitHub] [airflow] jedcunningham commented on a diff in pull request #25219: Update statsd-exporter setup
jedcunningham commented on code in PR #25219:
URL: https://github.com/apache/airflow/pull/25219#discussion_r932333388
##########
chart/values.schema.json:
##########
@@ -3751,11 +3751,207 @@
"$ref": "#/definitions/io.k8s.api.core.v1.TopologySpreadConstraint"
}
},
+ "histogramBuckets": {
+ "description": "A list of histogram buckets for the StatsD exporter.",
+ "type": "array",
+ "default": [
+ ".005",
+ ".01",
+ ".025",
+ ".05",
+ ".1",
+ ".25",
+ ".5",
+ "1",
+ "2.5"
+ ],
+ "items": {
+ "type": "string"
+ }
+ },
+ "defaultMappings": {
+ "description": "Default mappings for StatsD exporter.",
+ "type": "array",
+ "default": [
+ {
+ "match": "airflow.dagrun.dependency-check.*.*",
+ "name": "airflow_dagrun_dependency_check",
+ "labels": {
+ "dag_id": "$1"
+ }
+ },
+ {
+ "match": "airflow.ti_failures",
+ "name": "airflow_ti_tasks_failures_total"
+ },
+ {
+ "match": "airflow.ti_successes",
+ "name": "airflow_ti_tasks_succeeded_total"
+ },
+ {
+ "match": "airflow.ti.start.*.*",
+ "name": "airflow_ti_tasks_started_total",
+ "labels": {
+ "dag_id": "$1",
+ "task_id": "$2"
+ }
+ },
+ {
+ "match": "airflow.ti.finish.*.*.*",
+ "name": "airflow_ti_tasks_finished_total",
+ "labels": {
+ "dag_id": "$1",
+ "task_id": "$2",
+ "task_state": "$3"
+ }
+ },
+ {
+ "match": "airflow.operator_successes_(.*)",
+ "match_type": "regex",
+ "name": "airflow_operator_successes",
+ "labels": {
+ "operator": "$1"
+ }
+ },
+ {
+ "match": "airflow.operator_failures_(.*)",
+ "match_type": "regex",
+ "name": "airflow_operator_failures",
+ "labels": {
+ "operator": "$1"
+ }
+ },
+ {
+ "match": "airflow.scheduler_heartbeat",
+ "match_type": "regex",
+ "name": "airflow_scheduler_heartbeat",
+ "labels": {
+ "type": "counter"
+ }
+ },
+ {
+ "match": "airflow.dag.*.*.duration",
+ "name": "airflow_task_duration",
+ "labels": {
+ "dag_id": "$1",
+ "task_id": "$2"
+ }
+ },
+ {
+ "match": "airflow.dagrun.duration.success.*",
+ "name": "airflow_dagrun_duration",
+ "labels": {
+ "dag_id": "$1"
+ }
+ },
+ {
+ "match": "airflow.dagrun.duration.failed.*",
+ "name": "airflow_dagrun_failed",
+ "labels": {
+ "dag_id": "$1"
+ }
+ },
+ {
+ "match": "airflow.dagrun.schedule_delay.*",
+ "name": "airflow_dagrun_schedule_delay",
+ "labels": {
+ "dag_id": "$1"
+ }
+ },
+ {
+ "match": "airflow.dag_processing.last_runtime.*",
+ "name": "airflow_dag_processing_last_runtime",
+ "labels": {
+ "dag_file": "$1"
+ }
+ },
+ {
+ "match": "airflow.dag_processing.last_run.seconds_ago.*",
+ "name": "airflow_dag_processing_last_run_seconds_ago",
+ "labels": {
+ "dag_file": "$1"
+ }
+ },
+ {
+ "match": "airflow.pool.open_slots.*",
+ "name": "airflow_pool_open_slots",
+ "labels": {
+ "pool": "$1"
+ }
+ },
+ {
+ "match": "airflow.pool.used_slots.*",
+ "name": "airflow_pool_used_slots",
+ "labels": {
+ "pool": "$1"
+ }
+ },
+ {
+ "match": "airflow.pool.starving_tasks.*",
+ "name": "airflow_pool_starving_tasks",
+ "labels": {
+ "pool": "$1"
+ }
+ }
+ ],
+ "items": {
+ "type": "object",
+ "description": "Prometheus statsd_exporter mapping configuration",
+ "properties": {
Review Comment:
```suggestion
"additionalProperties": false,
"properties": {
```
Probably want this as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org