You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/04/08 04:48:00 UTC

[jira] [Commented] (AIRFLOW-6918) don't use 'is' in if conditions comparing STATE

    [ https://issues.apache.org/jira/browse/AIRFLOW-6918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17077829#comment-17077829 ] 

ASF GitHub Bot commented on AIRFLOW-6918:
-----------------------------------------

tooptoop4 commented on pull request #7536: [AIRFLOW-6918] don't use 'is' in if conditions comparing STATE
URL: https://github.com/apache/airflow/pull/7536
 
 
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> don't use 'is' in if conditions comparing STATE
> -----------------------------------------------
>
>                 Key: AIRFLOW-6918
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-6918
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: scheduler
>    Affects Versions: 1.10.9
>            Reporter: t oo
>            Assignee: t oo
>            Priority: Trivial
>
> Trivial code tidy-up - 'is' usually is used for testing booleans or None presence. This change ensures STATE values are tested with == / != instead of 'is'



--
This message was sent by Atlassian Jira
(v8.3.4#803005)