You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mxnet.apache.org by Serge Panev <no...@github.com> on 2020/07/29 23:17:16 UTC
[apache/incubator-mxnet] [RFC] Double dependency for ONNX (#18824)
## Description
ONNX is integrated as a dependency of onnx_tensorrt, which is itself a dependency (3rd party) of MXNet.
In parallel, ONNX is directly used by MXNet for its import and export functionalities.
Updating onnx_tensorrt can break the ONNX import/export functionalities.
This is not necessarily an issue, but it makes the ONNX dependency brittle.
Opening this issue to track it and potentially find a better way to track the dependency.
## References
- [Export ONNX C++](https://github.com/apache/incubator-mxnet/blob/master/src/operator/subgraph/tensorrt/nnvm_to_onnx-inl.h)
- [Export/Import ONNX Python](https://github.com/apache/incubator-mxnet/tree/master/python/mxnet/contrib/onnx)
- https://github.com/onnx/onnx-tensorrt
cc @ChaiBapchya
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-mxnet/issues/18824
Re: [apache/incubator-mxnet] [RFC] Double dependency for ONNX
(#18824)
Posted by Sheng Zha <no...@github.com>.
Can we drop onnx-tensorrt in favor of native tensorrt integration? It seems perfectly ok to run that outside of MXNet as it's more of an ONNX feature.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-mxnet/issues/18824#issuecomment-666989953
Re: [apache/incubator-mxnet] [RFC] Double dependency for ONNX
(#18824)
Posted by Chaitanya Prakash Bapat <no...@github.com>.
Thanks for creating the RFC. For readers to understand this issue better, could you substantiate with the PR example of how onnx_tensorrt updates can break the MX-ONNX import/export functionalities?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-mxnet/issues/18824#issuecomment-665983516